From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Duje Mihanović" <duje.mihanovic@skole.hr>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, afaerber@suse.com
Subject: Re: [PATCH 05/10] dt-bindings: clock: Add Marvell PXA1908 clock bindings
Date: Sat, 22 Jul 2023 11:21:59 +0200 [thread overview]
Message-ID: <25689bef-2dc9-a1ac-1ba4-0321813d5793@linaro.org> (raw)
In-Reply-To: <20230721210042.21535-6-duje.mihanovic@skole.hr>
On 21/07/2023 22:37, Duje Mihanović wrote:
> Add the dt bindings for Marvell PXA1908 clock controller.
>
Squash the patch with bindings change. It has little sense on its own,
> Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
> ---
> include/dt-bindings/clock/marvell,pxa1908.h | 93 +++++++++++++++++++++
> 1 file changed, 93 insertions(+)
> create mode 100644 include/dt-bindings/clock/marvell,pxa1908.h
>
> diff --git a/include/dt-bindings/clock/marvell,pxa1908.h b/include/dt-bindings/clock/marvell,pxa1908.h
> new file mode 100644
> index 000000000000..da9c5d499ae4
> --- /dev/null
> +++ b/include/dt-bindings/clock/marvell,pxa1908.h
> @@ -0,0 +1,93 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
Dual license. Didn't checkpatch complain?
> +#ifndef __DTS_MARVELL_PXA1908_CLOCK_H
> +#define __DTS_MARVELL_PXA1908_CLOCK_H
> +
> +/* plls */
> +#define PXA1908_CLK_CLK32 0x1
> +#define PXA1908_CLK_VCTCXO 0x2
> +#define PXA1908_CLK_PLL1_624 0x3
IDs are decimal numbers.
> +#define PXA1908_CLK_PLL1_416 0x4
> +#define PXA1908_CLK_PLL1_499 0x5
> +#define PXA1908_CLK_PLL1_832 0x6
> +#define PXA1908_CLK_PLL1_1248 0x7
> +#define PXA1908_CLK_PLL1_D2 0x8
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-22 9:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230721210042.21535-1-duje.mihanovic@skole.hr>
2023-07-21 20:37 ` [PATCH 05/10] dt-bindings: clock: Add Marvell PXA1908 clock bindings Duje Mihanović
2023-07-22 9:21 ` Krzysztof Kozlowski [this message]
2023-07-21 20:37 ` [PATCH 06/10] dt-bindings: clock: Add documentation for Marvell PXA1908 Duje Mihanović
2023-07-22 9:23 ` Krzysztof Kozlowski
2023-07-21 20:37 ` [PATCH 08/10] arm64: dts: Add DTS for Marvell PXA1908 and samsung,coreprimevelte Duje Mihanović
2023-07-22 9:25 ` Krzysztof Kozlowski
2023-07-21 20:37 ` [PATCH 09/10] dt-bindings: marvell: Document PXA1908 SoC Duje Mihanović
2023-07-21 22:28 ` Rob Herring
2023-07-22 9:27 ` Krzysztof Kozlowski
2023-07-22 21:52 ` Duje Mihanović
2023-07-24 14:14 ` Rob Herring
2023-07-24 21:37 ` Duje Mihanović
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25689bef-2dc9-a1ac-1ba4-0321813d5793@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afaerber@suse.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).