From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 1/9] ARM: dts: consolidate aliases for Cygnus dt files Date: Fri, 18 Sep 2015 23:27:37 +0200 Message-ID: <25764744.UdkoAR05y0@wuerfel> References: <1442611454-16331-1-git-send-email-rjui@broadcom.com> <1442611454-16331-2-git-send-email-rjui@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1442611454-16331-2-git-send-email-rjui-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ray Jui Cc: Florian Fainelli , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Friday 18 September 2015 14:24:06 Ray Jui wrote: > Move aliases into bcm-cygnus.dtsi to avoid duplications in Cygnus dts > files > We generally recommend keeping them separate: > diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi > index e1ac07a..30903ba 100644 > --- a/arch/arm/boot/dts/bcm-cygnus.dtsi > +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi > @@ -40,6 +40,10 @@ > model = "Broadcom Cygnus SoC"; > interrupt-parent = <&gic>; > > + aliases { > + serial0 = &uart3; > + }; > + The SoC has at least four uarts according to this, so it seems unlikely that each board really only uses only the fourth one of them and labels it '0' on the board. As soon as you get one board that has more than one uart wired up, you would need to undo this. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html