Re: [PATCH 4/9] clk: Add clock driver for mb86s7x

Jassi Brar
2014-11-21T13:22:47Z

On 21 November 2014 18:33, Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> wrote:
> On Thursday 20 November 2014 20:36:15 Vincent Yang wrote:
>> +#define __DTS_MB86S70_CLK_H
>> +
>> +#define MB86S70_CRG11_ALW 0
>> +#define MB86S70_CRG11_DDR3 1
>> +#define MB86S70_CRG11_MAIN 2
>> +#define MB86S70_CRG11_CA15 3
>> +#define MB86S70_CRG11_HDMI 4
>> +#define MB86S70_CRG11_DPHY 5
>> +
>> +#define MB86S70_CRG11_UNGPRT 8
>>
>
> The clock driver doesn't seem to use those macros at all, how does the
> driver know which clock you are referring to?
>
That was just an attempt to make a bit verbose the controller
instance. Instead of specifying controller:=4, it reads better
controller:=MB86S70_CRG11_HDMI in the clock DT nodes. The clock driver
simply fills in controller+domain+port of the given clock into mailbox
payload.

Only MB86S70_CRG11_UNGPRT is marked to mean one special (non-maskable)
port on the controller, which the clock driver does make use of.

Thanks
Jassi