Re: [PATCH 7/9] dt: mb86s7x: add dt files for MB86S7x evbs

Arnd Bergmann
2014-11-21T17:09:34Z

On Friday 21 November 2014 22:19:43 Jassi Brar wrote:
> >
> > This seems weird: rather than have one clock controller node per
> > clock source, why not just have one node with #clock-cells = >?
> >
> > Your controller seems perfectly capable of this, and you even
> > put the numbers in the label. It would be much more straightforward
> > to do
> >
> > clocks = <&clk_alw 0 1>;
> >
> > than
> >
> > clocks = <&clk_alw_0_1>;
> >
> > here. Possibly even
> >
> > clocks = <&clk MB86S70_CRG11_ALW 0 1>;
> >
> > with #clock-cells = >
> >
> Is there a way to compact the dtsi and yet populate only clocks that
> are actually ever used (instead of 6x16x9)?

I believe the clock driver just wouldn't create the clocks until
a device driver requests them.

Arnd