From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9BD5C32796 for ; Wed, 24 Aug 2022 12:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234910AbiHXMrj (ORCPT ); Wed, 24 Aug 2022 08:47:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235737AbiHXMrh (ORCPT ); Wed, 24 Aug 2022 08:47:37 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8BB910BF for ; Wed, 24 Aug 2022 05:47:35 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id m5so13173412lfj.4 for ; Wed, 24 Aug 2022 05:47:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=ZUpMSIDqsTgGgd5HUMEVbQG3gXHxQEJwHf+JxBOfjok=; b=OADfvvWHsXfdJrIU6icvXfguqE9THxW6oz3hk1h+6Aam4fSImoFKp+FD8DZWqH08Xs bkw6eTky+GiGJ4B0ZtLz2EQkbizXh41RNFK6YC4ujGcn8KpLrHVBhwYSSQfNnXXRbSVu /pEEoKH1UI0PaX7WVNYK9fBneV6XchHxJpjnA/NeZW9BGE5eEwfXB3H9yXK6SPRs/imw CtemRasRteWwDwV/Wrw4POPdOsYRJqK0npdehfIpNbFy9d3F8xSwGKGJjLWeAFQi0eJP KC8xmCUgVRFny+JQ9Mt4Xo9A7KTSJ7yS9GkE5BSrkPkA5JOXu5oZJv+c/O0l22YdfSbP zEJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=ZUpMSIDqsTgGgd5HUMEVbQG3gXHxQEJwHf+JxBOfjok=; b=yRbVgSh9ORGURqPJxT1wJQautr1E5YVk6cO+UTRk3ff4SiPH+Dj2VjXOlOGHnr0AuT xIWwkZ993HS5niAg6W4la11jyEZpVezCzXfmBlW0YeXwY8bY5mzs61tQkKeG0ZLljWd9 vFbIHC9ZD1KHfqWM4yXvzKsFGxQ4dextU6y65RoCnjBCav3N16Ta+A5/TYXgUGcknuok Ct809QdnpRuA4z3Wp6bDK1GsQGh3wOTsAARWDCIsvkSwNNfI0JVLWt2y94HGxU+zvSPn M1iCkeKM/3RRopXgHu2gVxAEEKjEyZXAUHAJlIugbVjwDQXMbLWGhBKvtTq50AUqpCfL mVZA== X-Gm-Message-State: ACgBeo0xag5WKKkEaDlBUYjdguh73OCb1YUGtpdcJvIYJZWbuigInjEU 5atOUDmY2zMuraVpryY0dwYELnu7gvXYW7vHGZY= X-Google-Smtp-Source: AA6agR6cZ6914v1H2yOOzs8QziISFTpV/gKx4PI2mgNZIJ4eUl6+V3xKe+l/W0/ITEsLKGcKGO5XSg== X-Received: by 2002:ac2:5f43:0:b0:492:d6e3:1dd3 with SMTP id 3-20020ac25f43000000b00492d6e31dd3mr7798393lfz.326.1661345254041; Wed, 24 Aug 2022 05:47:34 -0700 (PDT) Received: from [10.243.4.185] ([194.204.13.210]) by smtp.gmail.com with ESMTPSA id p5-20020a05651238c500b0048a83336343sm3007721lft.252.2022.08.24.05.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Aug 2022 05:47:33 -0700 (PDT) Message-ID: <25820bbe-c232-fb5c-0654-fc917ed8ad92@linaro.org> Date: Wed, 24 Aug 2022 15:47:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 3/4] arm64: dts: ti: Add initial support for J784s4 SoC Content-Language: en-US To: Nishanth Menon Cc: Apurva Nandan , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Linus Walleij , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Hari Nagalla References: <20220819190054.31348-1-a-nandan@ti.com> <20220819190054.31348-4-a-nandan@ti.com> <20220824050233.u4457ldxiqtiia4p@nineteen> From: Krzysztof Kozlowski In-Reply-To: <20220824050233.u4457ldxiqtiia4p@nineteen> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/08/2022 08:02, Nishanth Menon wrote: > On 13:18-20220823, Krzysztof Kozlowski wrote: >>> + main_gpio_intr: interrupt-controller@a00000 { >>> + compatible = "ti,sci-intr"; >>> + reg = <0x00 0x00a00000 0x00 0x800>; >> >> 0x0, not 0x00. Here and all other places. > > > Krzysztof is this a convention we have started following strongly? > > The reason I ask is to be able to cleanup elsewhere in the dts as well.. > > > So far, I have insisted on 0x00 usage. Not really, just stick to one. Your other nodes have 0x0, so just choose one. Anyway additional zeros seem redundant, but it is up to you which convention you prefer. Just choose one, not mixed. Best regards, Krzysztof