From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2] clk-rcar-gen2: RCAN clock support Date: Mon, 05 Jan 2015 10:58:12 +0200 Message-ID: <2588771.7HSTAuAcWR@avalon> References: <3007073.i0ghnTEhxV@wasted.cogentembedded.com> <1550804.XpyQtHjy2T@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1550804.XpyQtHjy2T@avalon> Sender: linux-sh-owner@vger.kernel.org To: Sergei Shtylyov Cc: mturquette@linaro.org, linux-kernel@vger.kernel.org, sboyd@codeaurora.org, linux-sh@vger.kernel.org, vksavl@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Sergei, On Monday 05 January 2015 10:53:02 Laurent Pinchart wrote: > On Thursday 25 December 2014 01:17:29 Sergei Shtylyov wrote: > > Add the RCAN clock support to the R-Car generation 2 CPG driver. This > > clock gets derived from the USB_EXTAL clock, dividing it by 6. The > > layout of the RCANCKCR register is similar to those of the clocks > > supported by the 'clk-div6' driver but has no divider field, and so can't > > be supported by that driver... > > > > Signed-off-by: Sergei Shtylyov > > > > --- > > The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' > > repo. > > > > Changes in version 2: > > - switched to using the composite clock driver with the fixed factor and > > gated clock component drivers; > > - removed *static* from 'parent_name' definition, switching from > > assignment to initializer; > > - modified the binding document; > > - modified the changelog. > > > > Documentation/devicetree/bindings/clock/renesas,rcar-gen2-cpg-clocks.txt > > | 5 - > > drivers/clk/shmobile/clk-rcar-gen2.c | 40 ++++++++++ > > Could you please also add a #define for the RCAN clock in include/dt- > bindings/clock/r8a779*-clock.h ? Same comment for the ADSP clock in "[PATCH] > clk-rcar-gen2: ADSP clock support". Scratch that, I see you add the #define's in the patches that add the corresponding MSTP clocks. -- Regards, Laurent Pinchart