From: Krzysztof Kozlowski <krzk@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>, Yao Zi <me@ziyao.cc>,
Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, devicetree@vger.kernel.org
Subject: Re: [PATCH 7/7] LoongArch: dts: loongson-2k1000: Fix i2c-gpio node names
Date: Tue, 16 Dec 2025 17:25:56 +0100 [thread overview]
Message-ID: <2589f9de-cb75-445b-b6ed-0773f972e845@kernel.org> (raw)
In-Reply-To: <9684ae4e58fd1e9768cccf6e3ae730eff46fb29c.1765778124.git.zhoubinbin@loongson.cn>
On 16/12/2025 08:56, Binbin Zhou wrote:
> From: Binbin Zhou <zhoubb.aaron@gmail.com>
>
> The binding wants the node to be named "i2c-number", alternatively
> "i2c@address", but those are named "i2c-gpio-number" instead.
i2c@address is wrong here, don't mention it.
>
> Rename those to i2c-0, i2c-1 to adhere to the binding and suppress
> dtbs_check warnings.
With fixed commit msg:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-16 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 7:54 [PATCH 0/7] LoongArch: DTS: Fix dtbs_check warnings Binbin Zhou
2025-12-16 7:54 ` [PATCH 1/7] dt-bindings: PCI: loongson: Document msi-parent property Binbin Zhou
2025-12-16 7:55 ` [PATCH 2/7] dt-bindings: interrupt-controller: loongson,pch-pic: Change to unevaluatedProperties Binbin Zhou
2025-12-16 16:16 ` Rob Herring
2025-12-17 7:17 ` Binbin Zhou
2025-12-16 7:55 ` [PATCH 3/7] LoongArch: dts: Describe PCI sideband IRQ through interrupt-extended Binbin Zhou
2025-12-16 7:56 ` [PATCH 4/7] LoongArch: dts: loongson-2k0500: Add default Extend I/O Interrupt controller address cells Binbin Zhou
2025-12-16 7:56 ` [PATCH 5/7] LoongArch: dts: loongson-2k1000: Add default Local " Binbin Zhou
2025-12-17 4:49 ` Huacai Chen
2025-12-16 7:56 ` [PATCH 6/7] LoongArch: dts: loongson-2k2000: Add default PCH PIC " Binbin Zhou
2025-12-16 7:56 ` [PATCH 7/7] LoongArch: dts: loongson-2k1000: Fix i2c-gpio node names Binbin Zhou
2025-12-16 9:44 ` Yao Zi
2025-12-16 16:24 ` Krzysztof Kozlowski
2025-12-16 16:25 ` Krzysztof Kozlowski [this message]
2025-12-16 9:31 ` [PATCH 0/7] LoongArch: DTS: Fix dtbs_check warnings Yao Zi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2589f9de-cb75-445b-b6ed-0773f972e845@kernel.org \
--to=krzk@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=me@ziyao.cc \
--cc=robh+dt@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).