From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2B5AC25B4E for ; Fri, 20 Jan 2023 07:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjATHso (ORCPT ); Fri, 20 Jan 2023 02:48:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230225AbjATHsh (ORCPT ); Fri, 20 Jan 2023 02:48:37 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 994CE85348 for ; Thu, 19 Jan 2023 23:48:13 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id q10so4073585wrs.2 for ; Thu, 19 Jan 2023 23:48:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SUbYG6CNFZkAaSfmbsiOn5ZLfVicT6OQUe0wKNSaOFg=; b=E/gsgiKDlovjPEr1wVqqhP64WUTBcW7LnrIaA4cGorpachmtdKSTBYWEnqah2dt/ro 1xumU7oIe5rQIZ6aGhYE5xSJwLTldpojPXW1rqA1+1h/HnlvGwt1yQMMJaWTfnLw+fGJ /jhjZNOe4+iFJYnBW5/8uANdzqMhKWVjryvU9eCf4ZpwED4iiCqNoKE/i7ftjwXzlMUN uQYg8rgLbc27HtpviXGt4mc51RFmQYU6aTIPJ1+GtcDafEg0fhIv9mkBvEfHRoRskB7d 0+jHp1P1kPTFwujMCz268zCKy1yN454PEPflBYCbr14i5q4hrSusYofS/dqyeGNzriFe jOBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SUbYG6CNFZkAaSfmbsiOn5ZLfVicT6OQUe0wKNSaOFg=; b=KZj2Qxt/RUeL0PdkzbCmTVWacbEdHAnnYlkji2zVHJyEzEbRpbGh7ry6yAwWIJZ6zt e704Egjvp01hodCH+JG2OwLriul+NDjIySQc2xAgP9WZuEjei7auhxIp885pfH9mqq4+ lyBGYGKEGVINwiygAPDianD+gYPNlfRMgpsqraS440UCq/S7UZzi6SXQpCPHMCk8vlKn 7UM3ZMLLGC70IZQB+bzBNQLmPze0iZCQYusIK4VsgqXODAGtTCKN/eDUK3kLM8niEITq f8onYF79abEPNu+gFxTAey749rVbZHfBIlhRkDsLbpFLFgr0cdXzJElLKOa89sJjDPqJ gY1A== X-Gm-Message-State: AFqh2kpsEZ5Hf5sCixNId0dF+0Mo/NOC6INONS2VLgqVlNUEbLsh/UuO I+xsWelo8EAbw7DYYymVWsY2uQ== X-Google-Smtp-Source: AMrXdXuXFnAh8TD3IFzfCwiyzZGic0IxxbCUXc7p1siPzKJJVl9d52SoYbHlIXsU456hEn0aOzJiQw== X-Received: by 2002:a5d:58e8:0:b0:2be:b07:d411 with SMTP id f8-20020a5d58e8000000b002be0b07d411mr11456316wrd.3.1674200825135; Thu, 19 Jan 2023 23:47:05 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id f3-20020adfdb43000000b00236883f2f5csm35975719wrj.94.2023.01.19.23.47.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Jan 2023 23:47:04 -0800 (PST) Message-ID: <259d738b-5717-8fda-22f0-c61db4660e95@linaro.org> Date: Fri, 20 Jan 2023 08:47:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH 2/2] spi: spidev: add new mediatek support Content-Language: en-US To: Alexandre Mergnat Cc: Krzysztof Kozlowski , Mark Brown , Rob Herring , Matthias Brugger , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230118-mt8365-spi-support-v1-0-842a21e50494@baylibre.com> <20230118-mt8365-spi-support-v1-2-842a21e50494@baylibre.com> <60766c7b-abb2-3afb-aa16-0e1385b88a73@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/01/2023 20:18, Alexandre Mergnat wrote: > Le jeu. 19 janv. 2023 à 17:49, Krzysztof Kozlowski > a écrit : >> >> On 19/01/2023 17:28, Alexandre Mergnat wrote: >>> { .compatible = "micron,spi-authenta", .data = &spidev_of_check }, >>> + { .compatible = "mediatek,genio", .data = &spidev_of_check }, >> >> Please run scripts/checkpatch.pl and fix reported warnings. > > Actually I did. > I saw: "WARNING: DT compatible string "mediatek,genio" appears > un-documented -- check ./Documentation/devicetree/bindings/" > But there are no bindings for spidev. I've made some grep on already > supported compatible devices like "micron,spi-authenta", but I didn't > find documentation to add "mediatek,genio". Another point - why is this after "micron"? Don't add entries to the end but in order. Best regards, Krzysztof