* [PATCH 2/2] dt-bindings: arm: Document the rest of i.MX28 based boards
2023-01-21 14:00 [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board Stefan Wahren
@ 2023-01-21 14:00 ` Stefan Wahren
2023-01-21 19:55 ` Krzysztof Kozlowski
2023-01-21 19:54 ` [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board Krzysztof Kozlowski
2023-01-26 9:49 ` Shawn Guo
2 siblings, 1 reply; 5+ messages in thread
From: Stefan Wahren @ 2023-01-21 14:00 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sébastien Szymanski, Fabio Estevam
Cc: devicetree, linux-arm-kernel, Stefan Wahren
Not all compatibles of i.MX28 based boards are documented, which
cause dtbs_check warnings. So add the missing compatibles to
fsl.yaml.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
.../devicetree/bindings/arm/fsl.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 599e8fcec6bc..ce5b5a82ee3a 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -88,18 +88,56 @@ properties:
items:
- enum:
- armadeus,imx28-apf28 # APF28 SoM
+ - bluegiga,apx4devkit # Bluegiga APx4 SoM on dev board
+ - crystalfontz,cfa10036 # Crystalfontz CFA-10036 SoM
+ - eukrea,mbmx28lc
- fsl,imx28-evk
- i2se,duckbill
- i2se,duckbill-2
+ - karo,tx28 # Ka-Ro electronics TX28 module
+ - lwn,imx28-xea
+ - msr,m28cu3 # M28 SoM with custom base board
+ - schulercontrol,imx28-sps1
- technologic,imx28-ts4600
- const: fsl,imx28
+ - description: i.MX28 Aries M28 SoM Board
+ items:
+ - const: aries,m28
+ - const: denx,m28
+ - const: fsl,imx28
+
+ - description: i.MX28 Aries M28EVK Board
+ items:
+ - const: aries,m28evk
+ - const: denx,m28evk
+ - const: fsl,imx28
+
- description: i.MX28 Armadeus Systems APF28Dev Board
items:
- const: armadeus,imx28-apf28dev
- const: armadeus,imx28-apf28
- const: fsl,imx28
+ - description: i.MX28 Crystalfontz CFA-10036 based Boards
+ items:
+ - enum:
+ - crystalfontz,cfa10037
+ - crystalfontz,cfa10049
+ - crystalfontz,cfa10057
+ - crystalfontz,cfa10058
+ - const: crystalfontz,cfa10036
+ - const: fsl,imx28
+
+ - description: i.MX28 Crystalfontz CFA-10037 based Boards
+ items:
+ - enum:
+ - crystalfontz,cfa10055
+ - crystalfontz,cfa10056
+ - const: crystalfontz,cfa10037
+ - const: crystalfontz,cfa10036
+ - const: fsl,imx28
+
- description: i.MX28 Duckbill 2 based Boards
items:
- enum:
@@ -109,6 +147,19 @@ properties:
- const: i2se,duckbill-2
- const: fsl,imx28
+ - description: i.MX28 Eukrea Electromatique MBMX283LC Board
+ items:
+ - const: eukrea,mbmx283lc
+ - const: eukrea,mbmx28lc
+ - const: fsl,imx28
+
+ - description: i.MX28 Eukrea Electromatique MBMX287LC Board
+ items:
+ - const: eukrea,mbmx287lc
+ - const: eukrea,mbmx283lc
+ - const: eukrea,mbmx28lc
+ - const: fsl,imx28
+
- description: i.MX31 based Boards
items:
- enum:
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board
2023-01-21 14:00 [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board Stefan Wahren
2023-01-21 14:00 ` [PATCH 2/2] dt-bindings: arm: Document the rest of i.MX28 based boards Stefan Wahren
@ 2023-01-21 19:54 ` Krzysztof Kozlowski
2023-01-26 9:49 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-21 19:54 UTC (permalink / raw)
To: Stefan Wahren, Rob Herring, Krzysztof Kozlowski, Shawn Guo,
Sébastien Szymanski, Fabio Estevam
Cc: devicetree, linux-arm-kernel
On 21/01/2023 15:00, Stefan Wahren wrote:
> Adjust the compatibles for the APF28Dev board in order to fix the
> dtbs_check warning:
>
> DTC_CHK arch/arm/boot/dts/imx28-apf28dev.dtb
> /home/stefanw/torvalds/arch/arm/boot/dts/imx28-apf28dev.dtb: /: compatible:
> oneOf' conditional failed, one must be fixed:
> ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too long
> ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too short
> ...
>
> Fixes: 3d735471d066 ("dt-bindings: arm: Document Armadeus SoM and Dev boards devicetree binding")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 3ba354578e8f..599e8fcec6bc 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -88,12 +88,18 @@ properties:
> items:
> - enum:
> - armadeus,imx28-apf28 # APF28 SoM
Not related to your patch, but this looks odd. This is SoM, so even if
it was made a DTS, it cannot be standalone board. The DTS or the
compatible or both are misleading/incorrect.
For the patch:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> - - armadeus,imx28-apf28dev # APF28 SoM on APF28Dev board
> - fsl,imx28-evk
> - i2se,duckbill
> - i2se,duckbill-2
> - technologic,imx28-ts4600
> - const: fsl,imx28
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board
2023-01-21 14:00 [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board Stefan Wahren
2023-01-21 14:00 ` [PATCH 2/2] dt-bindings: arm: Document the rest of i.MX28 based boards Stefan Wahren
2023-01-21 19:54 ` [PATCH 1/2] dt-bindings: arm: fsl: Fix bindings for APF28Dev board Krzysztof Kozlowski
@ 2023-01-26 9:49 ` Shawn Guo
2 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2023-01-26 9:49 UTC (permalink / raw)
To: Stefan Wahren
Cc: Rob Herring, Krzysztof Kozlowski, Sébastien Szymanski,
Fabio Estevam, devicetree, linux-arm-kernel
On Sat, Jan 21, 2023 at 03:00:52PM +0100, Stefan Wahren wrote:
> Adjust the compatibles for the APF28Dev board in order to fix the
> dtbs_check warning:
>
> DTC_CHK arch/arm/boot/dts/imx28-apf28dev.dtb
> /home/stefanw/torvalds/arch/arm/boot/dts/imx28-apf28dev.dtb: /: compatible:
> oneOf' conditional failed, one must be fixed:
> ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too long
> ['armadeus,imx28-apf28dev', 'armadeus,imx28-apf28', 'fsl,imx28'] is too short
> ...
>
> Fixes: 3d735471d066 ("dt-bindings: arm: Document Armadeus SoM and Dev boards devicetree binding")
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied both, thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread