[RFC PATCH net-next 0/2] Add support for ICSSG on AM64x EVM

[RFC PATCH net-next 0/2] Add support for ICSSG on AM64x EVM

[MD Danish Anwar]

This series adds support for ICSSG driver on AM64x EVM.

First patch of the series adds compatible for AM64x EVM in icssg-prueth
dt binding. Second patch adds support for AM64x compatible in the ICSSG 
driver.

This series depends on [1] which is posted as RFC.

[1] https://lore.kernel.org/all/20230830110847.1219515-1-danishanwar@ti.com/

Thanks and Regards,
Md Danish Anwar

MD Danish Anwar (2):
  dt-bindings: net: Add compatible for AM64x in ICSSG
  net: ti: icssg-prueth: Add AM64x icssg support

 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 1 +
 drivers/net/ethernet/ti/icssg/icssg_prueth.c               | 5 +++++
 2 files changed, 6 insertions(+)

-- 
2.34.1

[RFC PATCH net-next 1/2] dt-bindings: net: Add compatible for AM64x in ICSSG

[MD Danish Anwar]

Add compatible for AM64x in icssg-prueth dt bindings. AM64x supports
ICSSG similar to AM65x SR2.0.

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
index 311c570165f9..13371159515a 100644
--- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
+++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
@@ -20,6 +20,7 @@ properties:
   compatible:
     enum:
       - ti,am654-icssg-prueth  # for AM65x SoC family
+      - ti,am642-icssg-prueth  # for AM64x SoC family
 
   sram:
     $ref: /schemas/types.yaml#/definitions/phandle
-- 
2.34.1

Re: [RFC PATCH net-next 1/2] dt-bindings: net: Add compatible for AM64x in ICSSG

[Krzysztof Kozlowski]

On 30/08/2023 13:37, MD Danish Anwar wrote:
> Add compatible for AM64x in icssg-prueth dt bindings. AM64x supports
> ICSSG similar to AM65x SR2.0.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
> ---
>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> index 311c570165f9..13371159515a 100644
> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
> @@ -20,6 +20,7 @@ properties:
>    compatible:
>      enum:
>        - ti,am654-icssg-prueth  # for AM65x SoC family
> +      - ti,am642-icssg-prueth  # for AM64x SoC family

Keep the list ordered, probably alphanumerically.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [RFC PATCH net-next 1/2] dt-bindings: net: Add compatible for AM64x in ICSSG

[Md Danish Anwar]

On 30/08/23 8:16 pm, Krzysztof Kozlowski wrote:
> On 30/08/2023 13:37, MD Danish Anwar wrote:
>> Add compatible for AM64x in icssg-prueth dt bindings. AM64x supports
>> ICSSG similar to AM65x SR2.0.
>>
>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>> ---
>>  Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> index 311c570165f9..13371159515a 100644
>> --- a/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,icssg-prueth.yaml
>> @@ -20,6 +20,7 @@ properties:
>>    compatible:
>>      enum:
>>        - ti,am654-icssg-prueth  # for AM65x SoC family
>> +      - ti,am642-icssg-prueth  # for AM64x SoC family
> 
> Keep the list ordered, probably alphanumerically.
> 

Sure. I will change the order to alphanumeric when I drop the RFC and post it
as PATCH.

> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Thanks for the ack.

> Best regards,
> Krzysztof
> 

-- 
Thanks and Regards,
Danish.

[RFC PATCH net-next 2/2] net: ti: icssg-prueth: Add AM64x icssg support

[MD Danish Anwar]

Add AM64x ICSSG support which is similar to am65x SR2.0, but required:
- all ring configured in exposed ring mode
- always fill both original and buffer fields in cppi5 desc

Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
---
 drivers/net/ethernet/ti/icssg/icssg_prueth.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 3236af45aa4e..c2d1d0c7deb0 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -2676,8 +2676,13 @@ static const struct prueth_pdata am654_icssg_pdata = {
 	.switch_mode = 1,
 };
 
+static const struct prueth_pdata am64x_icssg_pdata = {
+	.fdqring_mode = K3_RINGACC_RING_MODE_RING,
+};
+
 static const struct of_device_id prueth_dt_match[] = {
 	{ .compatible = "ti,am654-icssg-prueth", .data = &am654_icssg_pdata },
+	{ .compatible = "ti,am642-icssg-prueth", .data = &am64x_icssg_pdata },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, prueth_dt_match);
-- 
2.34.1

Re: [RFC PATCH net-next 2/2] net: ti: icssg-prueth: Add AM64x icssg support

[Andrew Lunn]

On Wed, Aug 30, 2023 at 05:07:24PM +0530, MD Danish Anwar wrote:
> Add AM64x ICSSG support which is similar to am65x SR2.0, but required:
> - all ring configured in exposed ring mode
> - always fill both original and buffer fields in cppi5 desc
> 
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [RFC PATCH net-next 0/2] Add support for ICSSG on AM64x EVM

[Roger Quadros]

On 30/08/2023 14:37, MD Danish Anwar wrote:
> This series adds support for ICSSG driver on AM64x EVM.
> 
> First patch of the series adds compatible for AM64x EVM in icssg-prueth
> dt binding. Second patch adds support for AM64x compatible in the ICSSG 
> driver.
> 
> This series depends on [1] which is posted as RFC.
> 
> [1] https://lore.kernel.org/all/20230830110847.1219515-1-danishanwar@ti.com/
> 
> Thanks and Regards,
> Md Danish Anwar
> 
> MD Danish Anwar (2):
>   dt-bindings: net: Add compatible for AM64x in ICSSG
>   net: ti: icssg-prueth: Add AM64x icssg support

For this series:

Reviewed-by: Roger Quadros <rogerq@kernel.org>

-- 
cheers,
-roger