Re: [PATCH 4/4] dt-bindings: led: add virtual LED bindings

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/10/2025 17:43, Jonathan Brophy wrote:
> From: Jonathan Brophy <professor_jonny@hotmail.com>
> 
> Add device tree binding for virtual LED groups.
> 
> Co-developed-by: Radoslav Tsvetkov <rtsvetkov@gradotech.eu>

Incomplete chain. See submitting patches.

> Signed-off-by: Jonathan Brophy <professor_jonny@hotmail.com>
> ---
>  include/dt-bindings/leds/common.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h
> index 4f017bea0123..39c34d585a47 100644
> --- a/include/dt-bindings/leds/common.h
> +++ b/include/dt-bindings/leds/common.h
> @@ -63,6 +63,10 @@
>       "lp5523:{r,g,b}" (Nokia N900) */
>  #define LED_FUNCTION_STATUS "status"
> 
> +/* Virtual system LEDs Used for virtual LED groups, multifunction RGB
> +	 indicators or status LEDs that reflect complex system states */
> +#define LED_FUNCTION_VIRTUAL_STATUS "virtual-status"

Nothing explains why status and virtual status are supposed to be
different for users. You have entire commit msg to explain WHY you are
doing it, WHY we want this patch. I see no explanation and patch is not
looking like something correct, so please make your case in the commit msg.

> +
>  #define LED_FUNCTION_MICMUTE "micmute"
>  #define LED_FUNCTION_MUTE "mute"
> 
> --
> 2.43.0


Best regards,
Krzysztof