From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description
Date: Sat, 22 Sep 2018 21:59:17 +0300 [thread overview]
Message-ID: <25f1511a-2a2c-4991-0bc3-cce5bb11814f@cogentembedded.com> (raw)
In-Reply-To: <2aaa98bd-475c-08dd-ee34-d41fb960952e@cogentembedded.com>
Hello!
On 09/21/2018 11:45 PM, Sergei Shtylyov wrote:
> The "compatible" property description contradicts even the example given:
> it only says that there must be a single value while the example has the
> fallback value too -- which makes much more sense. Moreover, the generic
> property value is misdocumented as being R-Car (and RZ/G1) specific...
>
> Fixes: 382457e562bb ("pwm: renesas-tpu: Add DT support")
> Fixes: 3ba111a01822 ("dt-bindings: pwm: renesas-tpu: Document r8a774[35] support")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against Linus' repo -- the 'fixes' branch in Thierry Reding's
> repo is very outdated...
>
> Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> ===================================================================
> --- linux.orig/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> +++ linux/Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.txt
> @@ -2,13 +2,14 @@
>
> Required Properties:
>
> - - compatible: should be one of the following.
> + - compatible: must contain one or more of the following:
> - "renesas,tpu-r8a73a4": for R8A73A4 (R-Mobile APE6) compatible PWM controller.
> - "renesas,tpu-r8a7740": for R8A7740 (R-Mobile A1) compatible PWM controller.
> - "renesas,tpu-r8a7743": for R8A7743 (RZ/G1M) compatible PWM controller.
> - "renesas,tpu-r8a7745": for R8A7745 (RZ/G1E) compatible PWM controller.
> - "renesas,tpu-r8a7790": for R8A7790 (R-Car H2) compatible PWM controller.
> - - "renesas,tpu": for generic R-Car and RZ/G1 TPU PWM controller.
> + - "renesas,tpu": for the generic TPU PWM controller; this is a fallback for
> + the above .
Oops, forgot to refresh the patch. :-(
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-09-22 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 20:45 [PATCH] dt-bindings: pwm: renesas: tpu: fix "compatible" prop description Sergei Shtylyov
2018-09-22 18:59 ` Sergei Shtylyov [this message]
2018-09-24 15:32 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f1511a-2a2c-4991-0bc3-cce5bb11814f@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).