From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Brian Masney <bmasney@redhat.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: correct TLMM gpio-ranges
Date: Fri, 3 Feb 2023 00:45:49 +0100 [thread overview]
Message-ID: <25f5a750-b51c-7d7b-0d50-5b2f78de8512@linaro.org> (raw)
In-Reply-To: <Y9xAEoc0QXe222D0@x1>
On 2.02.2023 23:58, Brian Masney wrote:
> On Wed, Feb 01, 2023 at 04:50:56PM +0100, Krzysztof Kozlowski wrote:
>> Correct the number of GPIOs in TLMM pin controller.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index fa2d0d7d1367..17e8c26a9ae6 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -3533,7 +3533,7 @@ tlmm: pinctrl@f100000 {
>> #gpio-cells = <2>;
>> interrupt-controller;
>> #interrupt-cells = <2>;
>> - gpio-ranges = <&tlmm 0 0 230>;
>> + gpio-ranges = <&tlmm 0 0 228>;
Won't that kill the UFS pins?
>> };
>
> I verified that this count matches what's in downstream.
>
> Reviewed-by: Brian Masney <bmasney@redhat.com>
>
>
> However, I noticed in upstream that we're using this reg property:
>
> reg = <0 0x0f100000 0 0x300000>;
>
> Downstream has a different base address and a wider size. Note: I added
> spaces for easy comparison.
>
> reg = < 0x0F000000 0x1000000>;
>
> I don't have access to the appropriate documents to see which is
> correct. I assume the base address in upstream is at least correct since
> pinctrl is working on this platform.
Downstream offsets things in the driver
https://git.codelinaro.org/clo/la/kernel/msm-5.4/-/blob/LV.AU.1.2.3.r1-03600-gen3meta.0/drivers/pinctrl/qcom/pinctrl-direwolf.c#L20
Notice how UFS/QDSD pins addresses differ by 0x1000... up- and downstream too.
I'd imagine Bjorn/Johan/whoever did that used magic PDFs instead of not-very-
tested downstream sources.
Another note, the downstream driver may be incomplete/wrong, as Linux was
not exactly the main usecase of 8280xp so the testing there was most likely
only basic.
Konrad
>
> Brian
>
next prev parent reply other threads:[~2023-02-02 23:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 15:50 [RFT PATCH 00/14] ARM/arm64: dts: qcom: correct TLMM gpio-ranges Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 01/14] ARM: dts: qcom: sdx55: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 02/14] ARM: dts: qcom: sdx65: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 03/14] arm64: dts: qcom: msm8953: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 04/14] arm64: dts: qcom: sc7180: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 05/14] arm64: dts: qcom: sc8280xp: " Krzysztof Kozlowski
2023-02-02 22:58 ` Brian Masney
2023-02-02 23:45 ` Konrad Dybcio [this message]
2023-02-02 23:59 ` Brian Masney
2023-02-03 0:05 ` Konrad Dybcio
2023-02-03 0:15 ` Brian Masney
2023-02-03 7:10 ` Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 06/14] arm64: dts: qcom: sdm670: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 07/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2023-02-01 15:50 ` [RFT PATCH 08/14] arm64: dts: qcom: sm6115: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 09/14] arm64: dts: qcom: sm6125: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 10/14] arm64: dts: qcom: sm6350: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 11/14] arm64: dts: qcom: sm6375: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 12/14] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 13/14] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2023-02-01 15:51 ` [RFT PATCH 14/14] arm64: dts: qcom: sm8550: " Krzysztof Kozlowski
2023-02-02 10:39 ` [RFT PATCH 00/14] ARM/arm64: dts: qcom: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f5a750-b51c-7d7b-0d50-5b2f78de8512@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).