From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC0E263C8A for ; Mon, 24 Mar 2025 17:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742836987; cv=none; b=ej3s2WZ4UwxxItjAp6SGfUqlCZtwqYpsstmom0kdYqtZh6+QYmLsHOOB8ZYnPvl3Z7+Bk4PYD0PPXJZ3y23QB/bUb96XpJCa5OZaGmp8Ph5WmKrWjw/JsuizKypMWXVKkpRTBrsPZnrWZYlZlMRoP8E22RMJKGkuFzlclhS+/xY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742836987; c=relaxed/simple; bh=WzeJaaOIY3qOgasgq2SbP7NzsZnSi26UTmzBlBZdbZQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ldHSe75rv36/RQ/m7z1X/mK4lUyeq+YJeQWTVpDXQPnW8r7C8LnoFMlu2XqWGJgBdTrOdeHVkqXkgQbJAF7Kl9diX1H0IoYYpf+kqMAljM/NuIVt0PS2/fh4TzZNqCFPHMUOZ2SVDiHGabjrO4bKxUV2zayHqJb/tT5PGu9Xkzw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U+VDPyKA; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U+VDPyKA" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-399744f74e9so2865113f8f.1 for ; Mon, 24 Mar 2025 10:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742836984; x=1743441784; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WzeJaaOIY3qOgasgq2SbP7NzsZnSi26UTmzBlBZdbZQ=; b=U+VDPyKAxA/0uYzrU73vVChQ2bgZFoGLlSC3ukE7xR+054kYpMfJuiNnw6LzqrhHP5 lo2DvoQ32J94Wb6dqXInz0eXuIOWhFHt2bMPS525/imujMmOTW2DgwZswdjNSew98NvG G51LxM86maSbXZdDqM46uezP9NhyRVH8y/iDfjUzxu8jqCHqFqJCyKaAFHWvU7D6cU1o g0iir9uXWVaF2egHeAzRsGLkIZ4DyIMEWFw/dXv+UVXizRQi+uZGO405YHMIZVc6oo0T MHvNOnvD7KyOU6BbTNx3pXIk7/NaF8dT8aUnD6JwhH1pXYwl380L4Kb8O8r9Y+D9w1kh vy/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742836984; x=1743441784; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WzeJaaOIY3qOgasgq2SbP7NzsZnSi26UTmzBlBZdbZQ=; b=Ie5wNyxSo5sPRlQi2iQ09D5xIZzUi7WLEWe21UeW05KIS6C0YVpx7fzUwuUiE+nNfX c+/qBq2nCbb8ItLgF6nVhT93PIEruhq732wUn9pH4AwVFWjeQEoAvTENymF81w4gL4M9 7I2beR1Zehfj6V3op54p+OTvcKAMnzzo5IdFVeIc4jrq3TmeimoVcuPuM3EEm7X6CEDv 3k+3iIgesgI2TL5pTpU2nKhCr8lr9FGJmVBCjoqBbTXu1kqFZhbXCJygiWohTKZKgHMb 2+m0X+UWeSGvj7PlHYLu9XZzl/fdz5FPgSW1RRduMqY9YeyuP/vCI0jFx2FdtTH5jdEV rsiA== X-Forwarded-Encrypted: i=1; AJvYcCW6lckQ1yKe9yImJmDWYBVzEMove9CIR/pgK76fKbFUTsFm1QCs1TyArGwzmXo4hy6bkO8S+Hnv+tli@vger.kernel.org X-Gm-Message-State: AOJu0Ywn/nWFNp7YSrdiX2ZW5rgUbIOKzmVZgqaGK9BdE2Fuc1xUIbxR AlDbVUH49DPaYo58XFG/eGCOkUlG9Yao2FRTFobLYjoRE3Y0abP3F70cgYomrOA= X-Gm-Gg: ASbGncs18XfSVnqLOdw/GDqMpLN4cxlfOv5wWWZpgpJ40f0SlCt8WCjDPh+peYgEDhf 4lwJ8HfWsvNTPRDDcYLCDLd4heD4W92gEVo8+R7kjDIivaaeUVPhf/nmKs+1Vh4ycBMqojQFrYu ibrKh3F18WP/osMBNslsbgikejq380wuMmGxA5ARxw0OWTJepv+z0b/nEYwAlgkK5MWMj7fMUHq Cosi8avaoX0sIDFBKswZmFbqUSEDtAalFHKyV4kIhql1kS2JTxqXHWCOwFK9mCjylKQpefK7ZJb Jnvi1V37+0/T5F0mtRKa0CtiuvUFN3ZoZaygIQSMyNyklck= X-Google-Smtp-Source: AGHT+IHfEsqVrCp9uQuTAuS3ap1nR417rILjVAh7N1JNOE8t++oFUPwfBJvs4SjxnMYZNeDOSpPNtQ== X-Received: by 2002:a05:6000:18a2:b0:391:3028:c779 with SMTP id ffacd0b85a97d-3997f95956cmr12682045f8f.45.1742836983616; Mon, 24 Mar 2025 10:23:03 -0700 (PDT) Received: from salami.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d43f556a4sm177445795e9.22.2025.03.24.10.23.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 10:23:03 -0700 (PDT) Message-ID: <26037d49069309915d6ac3dc4d0aff90175754de.camel@linaro.org> Subject: Re: [PATCH 01/34] dt-bindings: mfd: samsung,s2mps11: add s2mpg10 From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Rob Herring Cc: Krzysztof Kozlowski , Lee Jones , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni , Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Date: Mon, 24 Mar 2025 17:23:01 +0000 In-Reply-To: <20250324165533.GA521455-robh@kernel.org> References: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> <20250323-s2mpg10-v1-1-d08943702707@linaro.org> <20250324165533.GA521455-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.55.3-1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Rob, Thanks for your review! On Mon, 2025-03-24 at 11:55 -0500, Rob Herring wrote: > On Sun, Mar 23, 2025 at 10:39:17PM +0000, Andr=C3=A9 Draszik wrote: > > The Samsung S2MPG10 PMIC is similar to the existing PMICs supported by > > this binding. > >=20 > > It is a Power Management IC for mobile applications with buck > > converters, various LDOs, power meters, RTC, clock outputs, and > > additional GPIOs interfaces. > >=20 > > Unlike other Samsung PMICs, communication is not via I2C, but via the > > Samsung ACPM firmware, it therefore doesn't need a 'reg' property but a > > handle to the ACPM firmware node instead. >=20 > Can it be a child node of the ACPM node instead? That should work, I'll do that instead so. > >=20 > > S2MPG10 can also act as a system power controller allowing > > implementation of a true cold-reset of the system. > >=20 > > Support for the other components will be added in subsequent future > > patches. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > > --- > > =C2=A0.../devicetree/bindings/mfd/samsung,s2mps11.yaml=C2=A0=C2=A0 | 34= ++++++++++++++++++++-- > > =C2=A01 file changed, 32 insertions(+), 2 deletions(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml= b/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > > index ac5d0c149796b6a4034b5d4245bfa8be0433cfab..ae8adb80b3af7ec3722c2a5= 718ad8fddf0a5df34 100644 > > --- a/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > > +++ b/Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml > > @@ -20,6 +20,7 @@ description: | > > =C2=A0properties: > > =C2=A0=C2=A0 compatible: > > =C2=A0=C2=A0=C2=A0=C2=A0 enum: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - samsung,s2mpg10-pmic > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - samsung,s2mps11-pmic > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - samsung,s2mps13-pmic > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - samsung,s2mps14-pmic > > @@ -43,6 +44,12 @@ properties: > > =C2=A0=C2=A0=C2=A0=C2=A0 description: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 List of child nodes that specify t= he regulators. > > =C2=A0 > > +=C2=A0 exynos,acpm-ipc: > > +=C2=A0=C2=A0=C2=A0 $ref: /schemas/types.yaml#/definitions/phandle > > +=C2=A0=C2=A0=C2=A0 description: | >=20 > Don't need '|' if no formatting to preserve. Oops, yes, sorry. Cheers, Andre' >=20 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Phandle to the ACPM node for when ACPM = is used to communicate with the > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 PMIC, rather than I2C. > > + > > =C2=A0=C2=A0 samsung,s2mps11-acokb-ground: > > =C2=A0=C2=A0=C2=A0=C2=A0 description: | > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Indicates that ACOKB pin of S2MPS1= 1 PMIC is connected to the ground so > > @@ -58,16 +65,39 @@ properties: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reset (setting buck voltages to de= fault values). > > =C2=A0=C2=A0=C2=A0=C2=A0 type: boolean > > =C2=A0 > > +=C2=A0 system-power-controller: true > > + > > =C2=A0=C2=A0 wakeup-source: true > > =C2=A0 > > =C2=A0required: > > =C2=A0=C2=A0 - compatible > > -=C2=A0 - reg > > -=C2=A0 - regulators > > =C2=A0 > > =C2=A0additionalProperties: false > > =C2=A0 > > =C2=A0allOf: > > +=C2=A0 - if: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 contains: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 con= st: samsung,s2mpg10-pmic > > +=C2=A0=C2=A0=C2=A0 then: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 regulators: false > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 samsung,s2mps11-acokb-groun= d: false > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 samsung,s2mps11-wrstbi-grou= nd: false > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - exynos,acpm-ipc > > + > > +=C2=A0=C2=A0=C2=A0 else: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 exynos,acpm-ipc: false > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 system-power-controller: fa= lse > > + > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - reg > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - regulators > > + > > =C2=A0=C2=A0 - if: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > >=20 > > --=20 > > 2.49.0.395.g12beb8f557-goog > >=20