Re: [PATCH 1/9] dt-bindings: arm: fsl: add TQ-Systems LS1021A board

Alexander Stein
2023-01-20T08:58:30Z

Hi Krzysztof,

thanks for your feedback.

Am Donnerstag, 19. Januar 2023, 17:59:20 CET schrieb Krzysztof Kozlowski:
> On 19/01/2023 15:42, Alexander Stein wrote:
> > From: Matthias Schiffer <matthias.schiffer@tq-group.com>
> >
> > TQMLS102xA is a SOM family using NXP LS1021A CPU family.
> > MBLS102xA is an evaluation mainbord for this SOM.
>
> typo: mainboard

Thanks.

> > Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >
> > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml index
> > 3ba354578e8f9..b54a920934c9d 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> >
> > @@ -1164,6 +1164,13 @@ properties:
> > - fsl,ls1021a-twr
> >
> > - const: fsl,ls1021a
> >
> > + - description: TQ-Systems TQMLS1021A SoM on MBLS102xA board
> > + items:
> > + - enum:
> > + - tq,ls1021a-tqmls1021a-mbls102xa
>
> Can mbls102xa come with something else than tqmls1021a?

I don't expect this. MBLS102xa is the starterkit carrier board for TQMLS1021A
module. But the module can come on other custom carrier boards.
This name schema is similar to e.g. imx8mp-tqma8mpql-mba8mpxl.dts

> > + - const: tq,ls1021a-tqmls1021a
>
> Why duplicating ls1021a? Can tqmls1021a come with something else? This
> is redundant.

I agree this is somewhat redundant, but this follows the naming scheme
'<vendor>,<soc>-<module>' which is rather widespread for i.MX boards/modules.
TQMLS1021A is the module name I can't change, actually part of the series
TQMLS102xA.

> > + - const: fsl,ls1021a
> > +
> >
> > - description: LS1028A based Boards
> >
> > items:
> > - enum:
> Best regards,
> Krzysztof

Best regards,
Alexander