Re: [PATCH 1/9] dt-bindings: arm: fsl: add TQ-Systems LS1021A board

Krzysztof Kozlowski
2023-01-19T16:59:28Z

On 19/01/2023 15:42, Alexander Stein wrote:
> From: Matthias Schiffer <matthias.schiffer@tq-group.com>
>
> TQMLS102xA is a SOM family using NXP LS1021A CPU family.
> MBLS102xA is an evaluation mainbord for this SOM.

typo: mainboard

>
> Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 3ba354578e8f9..b54a920934c9d 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1164,6 +1164,13 @@ properties:
> - fsl,ls1021a-twr
> - const: fsl,ls1021a
>
> + - description: TQ-Systems TQMLS1021A SoM on MBLS102xA board
> + items:
> + - enum:
> + - tq,ls1021a-tqmls1021a-mbls102xa

Can mbls102xa come with something else than tqmls1021a?

> + - const: tq,ls1021a-tqmls1021a

Why duplicating ls1021a? Can tqmls1021a come with something else? This
is redundant.

> + - const: fsl,ls1021a
> +
> - description: LS1028A based Boards
> items:
> - enum:

Best regards,
Krzysztof