Re: [PATCH 2/9] ARM: dts: ls1021a: add TQ-Systems MBLS102xA device tree

Krzysztof Kozlowski
2023-01-20T10:21:42Z

On 20/01/2023 11:08, Alexander Stein wrote:
> Thanks, will drop it.
>
>>> +
>>> + stmpe_gpio {
>>
>> No underscores in node names, generic node names, so "gpio". Does
>> anything depend on odd naming?
>
> You are right, node names should have underscores, but in the end I was
> following the bindings (Documentation/devicetree/bindings/input/touchscreen/
> stmpe.txt) naming 'stmpe_touchscreen' and 'stmpe_adc' in the example.

Example is not bindings.

> Each subdevice has it's own compatible, so there should be no issue.
> Using just 'gpio' and 'touchscreen' below I didn't notice any difference.

(...)

>>> +
>>> +&i2c0 {
>>> + status = "okay";
>>> +
>>> + mc34vr500: pmic@8 {
>>> + reg = <0x08>;
>>
>> No compatible? What's this?
>
> That's a DC/DC regulator on the module, currently without any driver support.
> It's controlled by the PMC, see below.
>
> We had an internal discussion as well whether to state clients without a
> driver (and thus no compatible) on the i2c bus. What is the guidelines for DT?
> The benefit stating, even without compatible, is to show there is some device
> on the bus.

Leave a comment, but not empty nodes.

Best regards,
Krzysztof