From: "Heiko Stübner" <heiko@sntech.de>
To: jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
sebastian.reichel@collabora.com,
Shreeya Patel <shreeya.patel@collabora.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, gustavo.padovan@collabora.com,
serge.broslavsky@collabora.com,
Shreeya Patel <shreeya.patel@collabora.com>
Subject: Re: [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning
Date: Sat, 10 Jun 2023 14:56:58 +0200 [thread overview]
Message-ID: <2621715.Lt9SDvczpP@diego> (raw)
In-Reply-To: <20230610122200.161741-1-shreeya.patel@collabora.com>
Am Samstag, 10. Juni 2023, 14:22:00 CEST schrieb Shreeya Patel:
> Fix the dtbs_check warning for 'oneOf' condition failure.
>
> DTC_CHK arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb
> /home/shreeya/linux/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dtb:
> saradc@fec10000: compatible: 'oneOf' conditional failed,
> one must be fixed:
> ['rockchip,rk3588-saradc'] is too short
> 'rockchip,saradc' was expected
> 'rockchip,rk3066-tsadc' was expected
> 'rockchip,rk3399-saradc' was expected
>
Nit: the commit message could explain that the rk3588 in fact isn't
compatible with the rk3399-saradc variant.
Otherwise I checked the implementation, so
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> Fixes: 2daf2ae9793d ("dt-bindings: iio: adc: Add rockchip,rk3588-saradc string")
> Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 11c27ea451c8..aa24b841393c 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -15,13 +15,13 @@ properties:
> - const: rockchip,saradc
> - const: rockchip,rk3066-tsadc
> - const: rockchip,rk3399-saradc
> + - const: rockchip,rk3588-saradc
> - items:
> - enum:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> - rockchip,rk3568-saradc
> - - rockchip,rk3588-saradc
> - rockchip,rv1108-saradc
> - rockchip,rv1126-saradc
> - const: rockchip,rk3399-saradc
>
prev parent reply other threads:[~2023-06-10 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 12:22 [PATCH] dt-bindings: iio: rockchip: Fix 'oneOf' condition failed warning Shreeya Patel
2023-06-10 12:56 ` Heiko Stübner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2621715.Lt9SDvczpP@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.padovan@collabora.com \
--cc=jic23@kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=serge.broslavsky@collabora.com \
--cc=shreeya.patel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).