* [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node
@ 2022-07-07 21:58 Ryan.Wanner
2022-07-07 22:11 ` Conor.Dooley
2022-07-08 15:16 ` Claudiu.Beznea
0 siblings, 2 replies; 3+ messages in thread
From: Ryan.Wanner @ 2022-07-07 21:58 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, claudiu.beznea, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-kernel, devicetree, linux-kernel, Ryan Wanner
From: Ryan Wanner <Ryan.Wanner@microchip.com>
Typo in i2s1 causing errors in dt binding validation.
Changed assigned-parens to assigned-clock-parents and
to match i2s0 node formatting.
Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
---
changes in v2:
-corrected subject and tags
changes in v1:
-corrected formatting issues
arch/arm/boot/dts/sama5d2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 89c71d419f82..659a17fc755c 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
clock-names = "pclk", "gclk";
assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
- assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
+ assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node
2022-07-07 21:58 [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node Ryan.Wanner
@ 2022-07-07 22:11 ` Conor.Dooley
2022-07-08 15:16 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Conor.Dooley @ 2022-07-07 22:11 UTC (permalink / raw)
To: Ryan.Wanner, Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea,
robh+dt, krzysztof.kozlowski+dt
Cc: linux-arm-kernel, devicetree, linux-kernel
Hey Ryan,
Just a couple of nit-pick comments:
On 07/07/2022 22:58, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Typo in i2s1 causing errors in dt binding validation.
> Changed assigned-parens to assigned-clock-parents and
> to match i2s0 node formatting.
Commit messages are usually written in the imperative, so rather
than "changed", we usually say "change" etc.
>
> Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
>
The blank line here isn't needed.
I wouldn't respin a v4 for this unless Nicolas/Claudiu request one.
Thanks,
Conor.
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> changes in v2:
> -corrected subject and tags
> changes in v1:
> -corrected formatting issues
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..659a17fc755c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
> clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
> clock-names = "pclk", "gclk";
> assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
> - assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
> + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node
2022-07-07 21:58 [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node Ryan.Wanner
2022-07-07 22:11 ` Conor.Dooley
@ 2022-07-08 15:16 ` Claudiu.Beznea
1 sibling, 0 replies; 3+ messages in thread
From: Claudiu.Beznea @ 2022-07-08 15:16 UTC (permalink / raw)
To: Ryan.Wanner, Nicolas.Ferre, alexandre.belloni, robh+dt,
krzysztof.kozlowski+dt
Cc: linux-arm-kernel, devicetree, linux-kernel
On 08.07.2022 00:58, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Typo in i2s1 causing errors in dt binding validation.
> Changed assigned-parens to assigned-clock-parents and
> to match i2s0 node formatting.
>
> Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
Applied to at91-fixes, thanks!
> ---
> changes in v2:
> -corrected subject and tags
> changes in v1:
> -corrected formatting issues
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..659a17fc755c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
> clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
> clock-names = "pclk", "gclk";
> assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
> - assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
> + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-08 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-07 21:58 [PATCH v3] ARM: dts: at91: sama5d2: Fix typo in i2s1 node Ryan.Wanner
2022-07-07 22:11 ` Conor.Dooley
2022-07-08 15:16 ` Claudiu.Beznea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).