From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE5C6C001DC for ; Mon, 31 Jul 2023 14:56:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbjGaO4p (ORCPT ); Mon, 31 Jul 2023 10:56:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjGaO4p (ORCPT ); Mon, 31 Jul 2023 10:56:45 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D16DBDB for ; Mon, 31 Jul 2023 07:56:43 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2b9c55e0fbeso62154691fa.2 for ; Mon, 31 Jul 2023 07:56:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690815402; x=1691420202; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Oa1SB02KtfMLxNE4mkxxs1OYoxXlIjwBI7+LigCTgCc=; b=Bps7HKIGU1d7zGk6EnCBSZB+lUHreffolw38t62M9CWeJ/hAtTcLbWEyRGx0OLdxN+ tVMbbmbRF2ohu2WxxLjNYl3IyaP6ok/GnwlqlRN29C3tUtFbSqIks28iNf8Ip0n3TGVQ ZauRAK3cDiIdUD/7Fu+6khTozBYPwXrwsueNQklYPH4vrbltQb4xTuyZ2h2GKYMpFzYh 5Q9Lc9qZWNJwsss83IMWvph8fAq0e2bgQavQ2H3qcjE5rf3kzV+sqjYnCqFfs+Lc8znr R2I9f4B8oxB6w1zJ5akEPy0M0Q7S5mHA5OPRYR+cBxdd/K8CBZV/lFEYIJcLPjhl60FZ ahYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690815402; x=1691420202; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Oa1SB02KtfMLxNE4mkxxs1OYoxXlIjwBI7+LigCTgCc=; b=YHVTTOgM1XIf7z9A//foBcWtcewTBamlLxnVu5DDgOPwL2BqVyOu6+V37jlS8ZOHGK qNT5as4t+pvk4oYJxSgw/aA2oema87HlnYrxQEBBN2qYHnb6mz1DvzR4UvMcfbh1U7c6 RqVlHXOoHD7ArEqGgKyCCM65u6DKadILftIHwi2nhkfOMX7qxmd3jx7Ca8nRMVgjUt9G IfraOeNMpJZv2WHElLqk4abLpTnRpg2lVOO8SezYT9ZcPaV4XS3aeavG4th8uJ8iUwvH U2Yf3tPltyqwoyhxFt8wL26Jm82Oh9hYMq7brERCBMtXEk6kQmZFQep+uLBmOVo3NOVw HgLg== X-Gm-Message-State: ABy/qLZlgZn00QY7iUqtvq6ex9Rv7Q04d8QcLd1mBB5pV3P0pZy4N6fg 9ojH03MQXOLuKIEhitXp67hMhVLJJ3vJu8mEM/o= X-Google-Smtp-Source: APBJJlF7zuWD7Kp6ngSgGXo2OLttXqzIQ2Sxj/NgV2Jy37GYeVH1VK7pokm/jJZBd1ud+kDxL8TYug== X-Received: by 2002:a2e:8e92:0:b0:2b9:edcd:8770 with SMTP id z18-20020a2e8e92000000b002b9edcd8770mr138066ljk.43.1690815402023; Mon, 31 Jul 2023 07:56:42 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.183]) by smtp.gmail.com with ESMTPSA id u17-20020a1709060b1100b00992bea2e9d2sm6335878ejg.62.2023.07.31.07.56.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 07:56:41 -0700 (PDT) Message-ID: <26224f81-9993-0a4c-4c46-91acd1ff5f42@linaro.org> Date: Mon, 31 Jul 2023 16:56:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.1 Subject: Re: [PATCH v3 5/6] ASoC: dt-bindings: mediatek,mt7986-wm8960: add mt7986-wm8960 document From: Krzysztof Kozlowski To: =?UTF-8?B?TWFzbyBIdWFuZyAo6buD5Yqg56u5KQ==?= , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "chenxiangrui@huaqin.corp-partner.google.com" , =?UTF-8?B?VHJldm9yIFd1ICjlkLPmlofoia8p?= , "devicetree@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , "broonie@kernel.org" , =?UTF-8?B?QWxsZW4tS0ggQ2hlbmcgKOeoi+WGoOWLsik=?= , "conor+dt@kernel.org" , "tiwai@suse.com" , "lgirdwood@gmail.com" , "linux-arm-kernel@lists.infradead.org" , "krzysztof.kozlowski+dt@linaro.org" , "matthias.bgg@gmail.com" , "perex@perex.cz" , "arnd@arndb.de" , "angelogioacchino.delregno@collabora.com" , "alsa-devel@alsa-project.org" References: <20230728090819.18038-1-maso.huang@mediatek.com> <20230728090819.18038-6-maso.huang@mediatek.com> <7d70f893-ee75-d355-4b4c-4afe7a72cd7c@linaro.org> <5f794f6d3595e845433aab3c48eb47ec7962c929.camel@mediatek.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/07/2023 10:14, Krzysztof Kozlowski wrote: >>>> + mediatek,audio-codec: >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>>> + description: The phandle of wm8960 codec. >>>> + >>> >>> How did you implement Rob's comment? Or did you just ignore it? >>> >>> Best regards, >>> Krzysztof >>> >> >> Hi Krzysztof, >> >> Sorry, I did not mean to ignore Rob's comment. >> I waited for some suggestion in mail below, but it seems Rob was a >> little busy. >> >> https://lore.kernel.org/lkml/8c6316e79e40406e4d46709f602dcb14a4c00562.camel@mediatek.com/ >> >> After gentle ping last week and receiving your advice, I thought that >> means to send the v3 patch and might discuss dtbingding in v3 series. >> >> So sorry for misunderstanding it, I'll check the details with Rob in v3 >> series then refine it in v4. > > The problem is that you did not reference in this patch any ongoing > discussion and further questions, so comment looks like addressed, while > it was not. > > Rob said: > "in a common schema and reference them " > You said: > "common part yaml and reference to it" > so I think you both agreed on the same. > > The advice would be to create common binding which is then referenced by > other and your bindings. However if you start doing it, you will notice > that it is impossible, because you have conflicting types for > "audio-codec", so you cannot have one definition. > > This leads to the point - property is probably wrong and you need > dai-link with sound-dai property, just like most cards are doing. BTW, might be useful for you, just sent: https://lore.kernel.org/linux-devicetree/20230731094303.185067-1-krzysztof.kozlowski@linaro.org/T/#t Anyway you need dai-links, I think. Best regards, Krzysztof