From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Abel Vesa <abel.vesa@linaro.org>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x4
Date: Tue, 4 Jun 2024 13:37:46 +0200 [thread overview]
Message-ID: <2626e3b0-a407-4e05-9c86-6d7cd40b9307@kernel.org> (raw)
In-Reply-To: <Zl73xRo7JpAZ5ViO@hovoldconsulting.com>
On 04/06/2024 13:17, Johan Hovold wrote:
> On Tue, Jun 04, 2024 at 01:00:35PM +0200, Krzysztof Kozlowski wrote:
>> On 03/06/2024 14:43, Johan Hovold wrote:
>>> On Fri, May 31, 2024 at 07:06:44PM +0300, Abel Vesa wrote:
>>>> The PCIe 6th instance from X1E80100 can be used in both 4-lane mode or
>>>
>>> nit: s/PCIe 6th/sixth PCIe/
>>> nit: s/from/on/
>>> nit: s/both/either/
>>
>> That's really nit-picking and not helpful in getting things merged.
>
> Writing proper commit messages with correct grammar is in no way to be
> asking too much (especially from experienced kernel devs).
Well, many of us are not native English speakers, so when the commit msg
is 100% understandable, pointing out grammar mistakes or style
(6th->sixth) issues is nit-picking and is asking for unnecessary work.
>
> Also, the code does not work so it should not be merged yet anyway.
OK
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-04 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 16:06 [PATCH 0/2] phy: qcom: qmp-pcie: Add support for Gen4 4-lane mode for X1E80100 Abel Vesa
2024-05-31 16:06 ` [PATCH 1/2] dt-bindings: phy: qcom,sc8280xp-qmp-pcie-phy: Document the X1E80100 QMP PCIe PHY Gen4 x4 Abel Vesa
2024-06-01 15:21 ` Krzysztof Kozlowski
2024-06-03 12:43 ` Johan Hovold
2024-06-04 11:00 ` Krzysztof Kozlowski
2024-06-04 11:17 ` Johan Hovold
2024-06-04 11:37 ` Krzysztof Kozlowski [this message]
2024-06-04 12:26 ` Johan Hovold
2024-06-04 12:19 ` Abel Vesa
2024-05-31 16:06 ` [PATCH 2/2] phy: qcom: qmp-pcie: Add X1E80100 Gen4 4-lane mode support Abel Vesa
2024-05-31 19:50 ` Dmitry Baryshkov
2024-06-03 12:46 ` Johan Hovold
2024-06-04 12:25 ` Abel Vesa
2024-06-04 12:47 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2626e3b0-a407-4e05-9c86-6d7cd40b9307@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).