From: Marek Vasut <marek.vasut@mailbox.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>
Subject: Re: [PATCH v5 2/2] usb: dwc3: dwc3-generic-plat: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue
Date: Tue, 1 Sep 2026 04:05:46 +0200 [thread overview]
Message-ID: <2634d23f-42de-48f3-b10b-92158e86fdf7@mailbox.org> (raw)
In-Reply-To: <apYmMt_vK5fbjBUJ@vbox>
On 9/1/26 3:17 AM, Thinh Nguyen wrote:
Hello Thinh,
>>> , but please drop the speed == USB_SPEED_WIRELESS check. This sanity
>>> check is not necessary and would be flagged by dwc3 core if set anyway.
>> Could you please point me to the code which filters the WIRELESS USB out ? I
>> can't seem to find it in either DWC3 core or USB core, but maybe I am not
>> looking for the right thing.
>>
>> Thank you for your help !
>
> You can find this in __dwc3_gadget_set_speed(). The switch statement
> explicitly handles unsupported speeds, and setting the speed to
> USB_SPEED_LOW or USB_SPEED_WIRELESS will trigger a complaint there.
But this is only for the gadget/peripheral mode, correct? The controller
in R-Car X5H is capable of both host and peripheral mode (DRD), so
shouldn't the check be kept in here in case the controller is used in
host mode ?
Thank you for your help !
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2026-09-01 2:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 18:23 [PATCH v5 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller Marek Vasut
2026-08-28 18:23 ` [PATCH v5 2/2] usb: dwc3: dwc3-generic-plat: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue Marek Vasut
2026-08-28 18:30 ` sashiko-bot
2026-08-28 18:36 ` Marek Vasut
2026-08-28 22:40 ` Thinh Nguyen
[not found] ` <1fa4e305-5717-4a99-9e53-3a7fa1c5df1e@mailbox.org>
2026-09-01 1:17 ` Thinh Nguyen
2026-09-01 2:05 ` Marek Vasut [this message]
2026-09-02 2:29 ` Thinh Nguyen
2026-09-03 21:31 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2634d23f-42de-48f3-b10b-92158e86fdf7@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox