From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E726C04A68 for ; Thu, 28 Jul 2022 17:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbiG1RyU (ORCPT ); Thu, 28 Jul 2022 13:54:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbiG1RyU (ORCPT ); Thu, 28 Jul 2022 13:54:20 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 440E87437E for ; Thu, 28 Jul 2022 10:54:19 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id bf9so3878486lfb.13 for ; Thu, 28 Jul 2022 10:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=6MfQt0pBWorRlsAFP8DPl6zHr8P3SDh0xwaF66hHtuo=; b=PSOOhlr1VTqdPCNhNjATTulVhMqFIJ6P/zYsu6rgIGU/c4tXgbVS3GqXW64iQEF2Wz XskiPlFCCSrbuQaBpbciOiaIgIawF8aZA0SM3KUIzRyWV5iIJ9tMSfIsOT/Jr9Hw34nd o7hmXIByqyAhsTgTsdsjmWVaZR/P0w6byYToDcktZpMea+RWSixBTrgYZIP5fm8+Z1N3 SEkduZvIeY2mI5HJ6CehwsTdX26ZHau9Cx7/PL0NmY/sOB+GKEFlODaAcky7Wb8DwYW6 D13neg0HcS00D+iP+q4jb6E8YfwhtQFX9RFwrUdng04m25TR9pJ54HHvwERqKBPzEig+ VJ1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6MfQt0pBWorRlsAFP8DPl6zHr8P3SDh0xwaF66hHtuo=; b=37LEE0ExnYnBBkPOPWgxiKSjd3/Fjj5icaGE4R4mUZtwiaenHsN6w44A4mUTfevr1Q MJd2XJBQDbV2Lx6oMnXn+ax03KmC6LWz1MCHZIoqtcFnDpsZqD6Q93PtYwfSh9ejRMy4 5IOMNhADEADFZ2CAJ20k/iAhStchMdomOXmiZGDrPI/2vs+MUbvJQIZnRoyn31ViNB2f 3xN5sDM9GtR+J1PFs2G7LqhycVdQyXiNF9XKi5VSdnrjXpJL+Q+cTzlZXpzgD7E4/+Dq rC5yMFo7JncE08aC0tk/YMmZ0DNH7JsivD/s3DdQ4mSXpcxfepB4SiqOoKR86/oDk9i2 CzsA== X-Gm-Message-State: AJIora+14nbgLLcTMDI0xjhkp13ZQ9leZaj/RynjK0mZ++cw1pjYL9T2 TdkXzYJ/13YpOrWJYs2UPvEjCA== X-Google-Smtp-Source: AGRyM1uC9AUPOcDFCyJbmlXK6r4q8xIOp/Zk9fpaBMmiBcH1i15Ev3nqouRr0FKDDD/Eu3JOB5MlwA== X-Received: by 2002:a05:6512:2622:b0:481:5b17:58e7 with SMTP id bt34-20020a056512262200b004815b1758e7mr3513lfb.600.1659030857234; Thu, 28 Jul 2022 10:54:17 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id b3-20020a056512304300b0048a7ebb3151sm292023lfb.181.2022.07.28.10.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 10:54:13 -0700 (PDT) Message-ID: <2640c637-68c7-641d-9b15-c57bdd5adca2@linaro.org> Date: Thu, 28 Jul 2022 19:54:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3] arm64: dts: mt8173-oak: Switch to SMC watchdog Content-Language: en-US To: Pin-yen Lin , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Eizan Miyamoto , Evan Benn , Hsin-Yi Wang , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org References: <20220728153913.2652153-1-treapking@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20220728153913.2652153-1-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/07/2022 17:39, Pin-yen Lin wrote: > Switch to SMC watchdog because we need direct control of HW watchdog > registers from kernel. The corresponding firmware was uploaded in > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/3405. > > Signed-off-by: Pin-yen Lin > --- > > Changes in v3: > - Remove /delete-node/ and create a new node for SMC watchdog. > > Changes in v2: > - Move the modifications to mt8173-elm.dtsi and add some comments. > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > index e21feb85d822..fc8203297bac 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi > @@ -161,6 +161,19 @@ hdmi_connector_in: endpoint { > }; > }; > }; > + > + Why? > + smc_watchdog { No, you need to read the comment you receive one more time. So to be clear: "watchdog" Best regards, Krzysztof