From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C4AC433EF for ; Sun, 24 Apr 2022 10:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239172AbiDXLBH (ORCPT ); Sun, 24 Apr 2022 07:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232783AbiDXLBG (ORCPT ); Sun, 24 Apr 2022 07:01:06 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F3EC12A83 for ; Sun, 24 Apr 2022 03:58:06 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id g6so1627652ejw.1 for ; Sun, 24 Apr 2022 03:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dcNY2DH36HPv7NbH4purwsl1q+khfyhVwK0k3NHViJQ=; b=KCChKWY3LlDWgFSBqGp9yeG4T9gr43DDNemWkKzBgI7Koo72cNSdkdmgD8N29EFfwu 3y/8KEI93fLbbeCmaQjILvMimg+TDsF+7UevM71yuisnE6oNQNhEEHEugeQ8wGRkoDEp lfmQAcL/guRAbuS9F5y6ldlpurqt25X9MVdJE8mQk0nH5XH+Gs0YlVBn99JGraozOXNI OEhOKkDjysukELr7lVM/FLjw3bRMGMFeuwpGzpQkzpHpZDSkfWMRL2eccdjUBESBguhC 6uVrQ8FdlZI7AfkGxtxe96CpbNfqPdx/XxeL/IS9VPgcoxvZLeJ9W4QN0OWjBVTYmKwV mrNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dcNY2DH36HPv7NbH4purwsl1q+khfyhVwK0k3NHViJQ=; b=wkVmRsU/HAgjS34yi5bdqxgPlFdYd+nIC7uddpPP1XaVDzc01wMTbvv0S5Z7KTcYQ/ SymJozCz/GR6pnBKg6ACUE19otCSgpuCrSlg4nQyzCEKfbJMTURc7LUWUYik5U2GAXDI 56u0zw8BrXKkTLzUQ6FcvsdgIP0M03IE6c1iuXz0UOBfhQGHX4B/4GIF1E5nu+xOtVIo Gt8Y3CjPyweAr8Rq9xH1nHMMQUE55D3umvmbOGtl06XS4GjoQgm0xaGra47HAqzqhybW 7zwyqGLWdUCYEpgrumbLxq45PC97kUbdLmCrE4g53p48WkLbp3IOVDxL+HSl3Ie7hGII we8A== X-Gm-Message-State: AOAM530cp/l+ceEvqObukOtukNey7wQZJejR5mmEmvY1uJYczLsONgrt LctOeemC7MauRWmaTSbemRVPjQ== X-Google-Smtp-Source: ABdhPJyUFJ0vMQAvNuwElDV7zr/Z3xxqNhh5KELlIMnFlY1Kk/PGfBGshVXfd3Me0GasMv02FUY1+A== X-Received: by 2002:a17:906:94d6:b0:6e8:d608:c960 with SMTP id d22-20020a17090694d600b006e8d608c960mr11929923ejy.96.1650797884710; Sun, 24 Apr 2022 03:58:04 -0700 (PDT) Received: from [192.168.0.235] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id y3-20020a50ce03000000b00425bfb7f940sm2997125edi.11.2022.04.24.03.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Apr 2022 03:58:04 -0700 (PDT) Message-ID: <2642dc72-81c3-b535-a658-025eb23679d7@linaro.org> Date: Sun, 24 Apr 2022 12:58:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/5] dt-bindings: mtd: samsung-onenand: Add new binding Content-Language: en-US To: Jonathan Bakker , Miquel Raynal Cc: Kyungmin Park , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring References: <20220423034316.366488-2-xc-racer2@live.ca> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/04/2022 05:45, Jonathan Bakker wrote: > Add a yaml binding document for the Samsung OneNAND controller. > It is found in several older Samsung SoC, notably the S5PV210. > > Signed-off-by: Jonathan Bakker > --- > .../bindings/mtd/samsung,onenand.yaml | 89 +++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/samsung,onenand.yaml > > diff --git a/Documentation/devicetree/bindings/mtd/samsung,onenand.yaml b/Documentation/devicetree/bindings/mtd/samsung,onenand.yaml > new file mode 100644 > index 000000000000..25012248add6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/samsung,onenand.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mtd/samsung,onenand.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung OneNAND controller > + > +maintainers: > + - Jonathan Bakker > + > +properties: > + compatible: > + enum: > + - samsung,s3c6400-onenand > + - samsung,s3c6410-onenand > + - samsung,s5pv210-onenand > + > + reg: > + maxItems: 3 Please describe the items or add reg-names. > + > + interrupts: > + maxItems: 1 > + > + clock-names: > + items: > + - const: bus > + - const: onenand > + > + clocks: > + minItems: 2 > + maxItems: 2 Drop minItems. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 Don't need these, they come from nand-controller. > + > +allOf: > + - $ref: nand-controller.yaml > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - samsung,s5pv210-onenand > + then: > + required: > + - interrupts > + - clock-names > + - clocks Others require it as well, don't they? > + > +patternProperties: > + "^nand@[a-f0-9]+$": > + type: object > + properties: > + reg: > + minimum: 0 > + maximum: 1 > + > + additionalProperties: false Also not needed. > + > +required: > + - compatible > + - reg > + > +additionalProperties: false With dropping all duplicated properties from nand-controller, this can be unevaluatedProperties:false. Unless for some reason parts of nand-controller schema are not valid here? > + > +examples: > + - | > + #include > + onenand: nand-controller@b0600000 { > + compatible = "samsung,s5pv210-onenand"; > + reg = <0xb0600000 0x2000>, > + <0xb0000000 0x20000>, > + <0xb0040000 0x20000>; Align the entries with first <> entry. > + interrupt-parent = <&vic1>; > + interrupts = <31>; > + clocks = <&clocks CLK_NANDXL>, <&clocks DOUT_FLASH>; > + clock-names = "bus", "onenand"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + nand@0 { > + reg = <0>; > + }; > + }; Best regards, Krzysztof