From: Arnd Bergmann <arnd@arndb.de>
To: Ding Tianhong <dingtianhong@huawei.com>
Cc: davem@davemloft.net, grant.likely@linaro.org,
sergei.shtylyov@cogentembedded.com,
linux-arm-kernel@lists.infradead.org, eric.dumazet@gmail.com,
zhangfei.gao@linaro.org, joe@perches.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux@arm.linux.org.uk
Subject: Re: [PATCH net-next 5/6] net: hip04: remove the unnecessary check
Date: Wed, 15 Apr 2015 16:14:26 +0200 [thread overview]
Message-ID: <2645626.sX8mP7tn7R@wuerfel> (raw)
In-Reply-To: <1429101008-9464-6-git-send-email-dingtianhong@huawei.com>
On Wednesday 15 April 2015 20:30:07 Ding Tianhong wrote:
> diff --git a/drivers/net/ethernet/hisilicon/hip04_eth.c b/drivers/net/ethernet/hisilicon/hip04_eth.c
> index ff9d19c..a7ab1d9 100644
> --- a/drivers/net/ethernet/hisilicon/hip04_eth.c
> +++ b/drivers/net/ethernet/hisilicon/hip04_eth.c
> @@ -440,7 +440,7 @@ static int hip04_tx_reclaim(struct net_device *ndev, bool force)
> smp_wmb(); /* Ensure tx_tail visible to xmit */
>
> out:
> - if (pkts_compl || bytes_compl)
> + if (bytes_compl)
> netdev_completed_queue(ndev, pkts_compl, bytes_compl);
>
> if (unlikely(netif_queue_stopped(ndev)) && (count < (TX_DESC_NUM - 1)))
> --
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2015-04-15 14:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 12:30 [PATCH net-next 0/6] net: hip04: fix some problem for hip04 drivers Ding Tianhong
2015-04-15 12:30 ` [PATCH net-next 1/6] net: hip04: Set more appropriate value for tx coalesce num Ding Tianhong
2015-04-15 14:11 ` Arnd Bergmann
[not found] ` <1429101008-9464-1-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 12:30 ` [PATCH net-next 2/6] net: hip04: use the big endian for tx and rx desc Ding Tianhong
[not found] ` <1429101008-9464-3-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:13 ` Arnd Bergmann
2015-04-16 6:25 ` Ding Tianhong
2015-04-15 12:30 ` [PATCH net-next 3/6] net: hip04: Solve the problem of the skb memory allocation failure Ding Tianhong
[not found] ` <1429101008-9464-4-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:17 ` Arnd Bergmann
2015-04-15 12:30 ` [PATCH net-next 5/6] net: hip04: remove the unnecessary check Ding Tianhong
2015-04-15 14:14 ` Arnd Bergmann [this message]
2015-04-15 12:30 ` [PATCH net-next 6/6] net: hip04: add ratelimit for rx/tx drops skb Ding Tianhong
[not found] ` <1429101008-9464-7-git-send-email-dingtianhong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-04-15 14:20 ` Arnd Bergmann
2015-04-15 12:30 ` [PATCH net-next 4/6] net: hip04: Don't free the tx skb when the buffer is not ready for xmit Ding Tianhong
2015-04-15 14:19 ` Arnd Bergmann
2015-04-16 6:26 ` Ding Tianhong
2015-04-16 8:41 ` Arnd Bergmann
2015-04-16 9:38 ` Ding Tianhong
2015-04-15 14:25 ` [PATCH net-next 0/6] net: hip04: fix some problem for hip04 drivers Arnd Bergmann
2015-04-16 6:28 ` Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2645626.sX8mP7tn7R@wuerfel \
--to=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dingtianhong@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=grant.likely@linaro.org \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox