From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v2 2/9] dmaengine: st_fdma: Add st fdma platform specific header Date: Fri, 11 Sep 2015 22:32:36 +0200 Message-ID: <2654563.3IzPKrUkAU@wuerfel> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <1441980871-24475-3-git-send-email-peter.griffin@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1441980871-24475-3-git-send-email-peter.griffin@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, vinod.koul@intel.com, lee.jones@linaro.org, robh+dt@kernel.org, dmaengine@vger.kernel.org, devicetree@vger.kernel.org, Ludovic Barre List-Id: devicetree@vger.kernel.org On Friday 11 September 2015 15:14:24 Peter Griffin wrote: > Signed-off-by: Ludovic Barre > Signed-off-by: Peter Griffin > --- > include/linux/platform_data/dma-st_fdma.h | 72 +++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 include/linux/platform_data/dma-st_fdma.h > This clearly needs an explanation of which platforms require the header. On ARM, all new platforms use DT, so it's obviously not one of them. Also, it would make sense to split the portions that are needed for defining the platform device from the portions that are used by the slave device definitions. Arnd