From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: devicetree@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org
Subject: Re: [RFC PATCHv2 2/9] dt-bindings: display/ti: add k2g-dss bindings
Date: Tue, 24 Jul 2018 17:29:13 +0300 [thread overview]
Message-ID: <2654733.mVEzccOoVi@avalon> (raw)
In-Reply-To: <20180618132242.8673-3-tomi.valkeinen@ti.com>
Hi Tomi,
Thank you for the patch.
On Monday, 18 June 2018 16:22:35 EEST Tomi Valkeinen wrote:
> Add DT bindings for Texas Instruments K2G SoC Display Subsystem. The DSS
> is quite simple, with a single plane and a single output.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: devicetree@vger.kernel.org
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/display/ti/ti,k2g-dss.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/display/ti/ti,k2g-dss.txt
>
> diff --git a/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.txt
> b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.txt new file mode
> 100644
> index 000000000000..1af11425eda3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ti/ti,k2g-dss.txt
> @@ -0,0 +1,15 @@
> +Texas Instruments K2G Display Subsystem
> +=======================================
> +
> +Required properties:
> +- compatible: "ti,k2g-dss"
> +- reg: address and length of the register spaces for DSS submodules
> +- reg-names: "cfg", "common", "vid1", "ovr1", "vp1"
When seeing multiple register ranges for a DT node I always suspect that we
describe multiple IP cores that could be better modeled as independent nodes.
What prompted you not to model the DISPC as a separate DT node (possibly a
child of the DSS DT node) ?
Furthermore, "cfg" corresponds to the DSS registers, so I wonder whether it
shouldn't be named "dss". Similarly, "common" really sounds like DSS common
registers, while it relates to the DISPC.
> +- clocks: phandle to fclk and vp1 clocks
> +- clock-names: "fck", "vp1"
> +- interrupts: phandle to the DISPC interrupt
> +
> +The DSS outputs are described using the device graphs as documented in
> +Documentation/devicetree/bindings/graph.txt. K2G DSS has a single DPI
> output as
> +port 0.
Both SPRUHY8H and SPRSP07D document a DPI output and a DBI output. Am I
looking at the wrong document ?
> +
Extra blank line ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-24 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180618132242.8673-1-tomi.valkeinen@ti.com>
2018-06-18 13:22 ` [RFC PATCHv2 2/9] dt-bindings: display/ti: add k2g-dss bindings Tomi Valkeinen
2018-07-24 14:29 ` Laurent Pinchart [this message]
2018-07-30 11:29 ` Tomi Valkeinen
2018-06-18 13:22 ` [RFC PATCHv2 3/9] dt-bindings: display/ti: add am65x-dss bindings Tomi Valkeinen
2018-06-25 18:59 ` Rob Herring
2018-06-26 8:15 ` Tomi Valkeinen
2018-07-29 23:04 ` Laurent Pinchart
2018-07-30 11:00 ` Tomi Valkeinen
2018-06-18 13:22 ` [RFC PATCHv2 8/9] ARM: dts: keystone-k2g: add DSS node Tomi Valkeinen
2018-06-19 6:19 ` Tony Lindgren
2018-06-19 7:09 ` Tomi Valkeinen
2018-06-19 7:12 ` Tony Lindgren
2018-06-18 13:22 ` [RFC PATCHv2 9/9] ARM: dts: keystone-k2g-evm: add LCD and HDMI displays Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2654733.mVEzccOoVi@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).