From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29000C433F5 for ; Mon, 7 Mar 2022 11:03:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240679AbiCGLEX (ORCPT ); Mon, 7 Mar 2022 06:04:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239843AbiCGLDp (ORCPT ); Mon, 7 Mar 2022 06:03:45 -0500 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26F4BB57B; Mon, 7 Mar 2022 02:25:21 -0800 (PST) Received: by mail-ed1-f53.google.com with SMTP id g20so19174594edw.6; Mon, 07 Mar 2022 02:25:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=9BEIE4LEowvxQSSTz3f1Y8ar8ZR223l9KKCc1D8mpx0=; b=b9aZBfH56V+XBTe7CPuU/cUIDBU1GRaRExLqYO+6wYwTnNXlQGuJf3W5JoK5qDSmnX OrH+LD8zv8k40XPUZufA2YofFNmtrIGYQfV1Z9YUZ/WLYIyBVu8X9+Zo5rxQREYd6MUd 6pGSW4ovlVv3mXJZaZdjWuFobuIHOxsjcZpkSg9b9Z6QwdorBfzdDY+gULuJB57aKjNm JsEq7qDafiS1JVDN5bkUHIRvUw53UGYSNamLJO6/G82xK3ChiaVNq4+n2OGRi/V/NcVh hymH3dc3PDvKKSVmUoGx62bW/2vSwRsWSAzcGqqUlFRRvudjxJEwC/rMnuCkmY5unEtQ skCA== X-Gm-Message-State: AOAM532aYumjGI926lmJkL7XW8JAooVEqq9vqcShxFv5CXXoiR+UAy1s oQDKjSP/KOkv6T3e6kTE0l0= X-Google-Smtp-Source: ABdhPJwIkS5RGTudyYpPKaC8uoCHh20OFgMnawdAASKR32kUeYvdzWByRI3rumxyl4AavNo2ImHiRw== X-Received: by 2002:a05:6402:3712:b0:416:13bf:4fc5 with SMTP id ek18-20020a056402371200b0041613bf4fc5mr10687450edb.115.1646648710572; Mon, 07 Mar 2022 02:25:10 -0800 (PST) Received: from [192.168.0.141] (xdsl-188-155-174-239.adslplus.ch. [188.155.174.239]) by smtp.googlemail.com with ESMTPSA id rh13-20020a17090720ed00b006da69254082sm4558682ejb.135.2022.03.07.02.25.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Mar 2022 02:25:10 -0800 (PST) Message-ID: <2669852c-5bb6-1edf-bf58-ea815f54d50f@kernel.org> Date: Mon, 7 Mar 2022 11:25:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 3/3] arm64: dts: nuvoton: Add initial support for MA35D1 Content-Language: en-US To: Jacky Huang , robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, arnd@arndb.de, olof@lixom.net Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, soc@kernel.org, linux-arm-kernel@lists.infradead.org References: <20220307091923.9909-1-ychuang3@nuvoton.com> <20220307091923.9909-4-ychuang3@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <20220307091923.9909-4-ychuang3@nuvoton.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/03/2022 10:19, Jacky Huang wrote: > Add the initial device tree files for Nuvoton MA35D1 Soc. > > Signed-off-by: Jacky Huang > --- > arch/arm64/boot/dts/Makefile | 1 + > arch/arm64/boot/dts/nuvoton/Makefile | 2 + > arch/arm64/boot/dts/nuvoton/ma35d1-evb.dts | 23 +++++ > arch/arm64/boot/dts/nuvoton/ma35d1.dtsi | 106 +++++++++++++++++++++ > 4 files changed, 132 insertions(+) > create mode 100644 arch/arm64/boot/dts/nuvoton/Makefile > create mode 100644 arch/arm64/boot/dts/nuvoton/ma35d1-evb.dts > create mode 100644 arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > > diff --git a/arch/arm64/boot/dts/Makefile b/arch/arm64/boot/dts/Makefile > index 639e01a4d855..28e01442094f 100644 > --- a/arch/arm64/boot/dts/Makefile > +++ b/arch/arm64/boot/dts/Makefile > @@ -30,3 +30,4 @@ subdir-y += synaptics > subdir-y += ti > subdir-y += toshiba > subdir-y += xilinx > +subdir-y += nuvoton > diff --git a/arch/arm64/boot/dts/nuvoton/Makefile b/arch/arm64/boot/dts/nuvoton/Makefile > new file mode 100644 > index 000000000000..e1e0c466bf5e > --- /dev/null > +++ b/arch/arm64/boot/dts/nuvoton/Makefile > @@ -0,0 +1,2 @@ > +# SPDX-License-Identifier: GPL-2.0 > +dtb-$(CONFIG_ARCH_NUVOTON) += ma35d1-evb.dtb ARCH_NUVOTON does not exist. > diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1-evb.dts b/arch/arm64/boot/dts/nuvoton/ma35d1-evb.dts > new file mode 100644 > index 000000000000..38e4f734da0f > --- /dev/null > +++ b/arch/arm64/boot/dts/nuvoton/ma35d1-evb.dts > @@ -0,0 +1,23 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Device Tree Source for MA35D1 Evaluation Board (EVB) > + * > + * Copyright (C) 2021 Nuvoton Technology Corp. > + */ > + > +/dts-v1/; > +#include "ma35d1.dtsi" > + > +/ { > + model = "Nuvoton MA35D1-EVB"; > + > + chosen { > + bootargs = "console=ttyS0,115200n8"; No bootargs. "chosen", please. > + }; You need compatible and bindings. > + > + memory@80000000 { > + device_type = "memory"; > + reg = <0x00000000 0x80000000 0 0x10000000>; > + }; > +}; > + > diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > new file mode 100644 > index 000000000000..27adac4975c3 > --- /dev/null > +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi > @@ -0,0 +1,106 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2022 Nuvoton Technology Corp. > + */ > + > +#include > +#include > +#include > +#include > + > +/ { > + compatible = "nuvoton,ma35d1"; Please run checkpatch. This compatible looks undocumented. > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + core1 { > + cpu = <&cpu1>; > + }; > + }; > + }; Line break between each nodes, here and below. > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35"; > + reg = <0x0 0x0>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + cpu1: cpu@1 { > + device_type = "cpu"; > + compatible = "arm,cortex-a35"; > + reg = <0x0 0x1>; > + enable-method = "psci"; > + next-level-cache = <&L2_0>; > + }; > + L2_0: l2-cache0 { > + compatible = "cache"; > + cache-level = <2>; > + }; > + }; > + > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>, > + + IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <12000000>; > + }; > + > + sys: system-controller@40460000 { > + compatible = "nuvoton,ma35d1-sys", "syscon", "simple-mfd"; > + reg = <0x0 0x40460000 0x0 0x200>; > + }; > + > + reset: reset-controller { > + compatible = "nuvoton,ma35d1-reset"; > + nuvoton,ma35d1-sys = <&sys>; > + #reset-cells = <1>; > + }; > + > + clk: clock-controller@40460200 { > + compatible = "nuvoton,ma35d1-clk"; > + reg = <0x00000000 0x40460200 0x0 0x100>; > + #clock-cells = <1>; > + assigned-clocks = <&clk DDRPLL>, > + <&clk APLL>, > + <&clk EPLL>, > + <&clk VPLL>; > + assigned-clock-rates = <266000000>, > + <180000000>, > + <500000000>, > + <102000000>; > + clock-pll-mode = <1>, <0>, <0>, <0>; > + }; > + > + gic: interrupt-controller@50800000 { > + compatible = "arm,gic-400"; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupt-controller; > + reg = <0x0 0x50801000 0 0x1000>, > + <0x0 0x50802000 0 0x2000>, > + <0x0 0x50804000 0 0x2000>, > + <0x0 0x50806000 0 0x2000>; > + interrupts = + IRQ_TYPE_LEVEL_HIGH)>; > + }; > +}; > -- > 2.17.1 > > ________________________________ > ________________________________ > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. > Your cooperation is highly appreciated... Cooperation seems futile... :) Best regards, Krzysztof