Re: [PATCH v3 1/3] dt-bindings: net: ath10k: fix node name and device type in qcom ath10k example

[Bhagavathi Perumal S <bperumal-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>]

On 2018-12-11 04:55, Rob Herring wrote:
> On Tue, Dec 11, 2018 at 12:01:29AM +0530, Bhagavathi Perumal S wrote:
>> In qcom,ath10k documentation, ath10k is used as node name in the 
>> example of
>> pci based device. Normally, node name shoud be class of device and not 
>> the model
> 
> s/shoud/should/
Thanks, Will correct typo error and send v4 patch.
> 
>> name, so fix it to node name "wifi". And remove the property 
>> device_type pci
>> since only pci bridges should have this property.
>> 
>> Signed-off-by: Bhagavathi Perumal S <bperumal-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
>> ---
>>  Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 3 
>> +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt 
>> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> index 2196d1a..ef60f25 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
>> @@ -74,9 +74,8 @@ pci {
>>  		#address-cells = <3>;
>>  		device_type = "pci";
>> 
>> -		ath10k@0,0 {
>> +		wifi@0,0 {
>>  			reg = <0 0 0 0 0>;
>> -			device_type = "pci";
>>  			qcom,ath10k-calibration-data = [ 01 02 03 ... ];
>>  		};
>>  	};
>> --
>> 1.9.1
>>