From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
michal.simek@xilinx.com, michal.simek@amd.com,
devicetree@vger.kernel.org, andrew@lunn.ch, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: git@amd.com, srinivas.goud@amd.com, shubhrajyoti.datta@amd.com,
manion05gk@gmail.com,
Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Subject: Re: [PATCH V4 7/9] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to
Date: Thu, 2 Feb 2023 10:46:28 +0100 [thread overview]
Message-ID: <266a4dec-ec2c-3c21-975e-301e3a7bb5f3@linaro.org> (raw)
In-Reply-To: <1675330898-563-8-git-send-email-manikanta.guntupalli@amd.com>
On 02/02/2023 10:41, Manikanta Guntupalli wrote:
> From: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
Your subject is corrupted
>
> compatible
>
> Added the xilinx I2C new version 'xlnx,axi-iic-2.1' string to compatible
> Added clock-frequency as optional property.
Use imperative, not past tense.
>
> Signed-off-by: Raviteja Narayanam <raviteja.narayanam@xilinx.com>
> Signed-off-by: Manikanta Guntupalli <manikanta.guntupalli@amd.com>
> Acked-by: Michal Simek <michal.simek@amd.com>
> ---
> Changes for v4:
> Added description for clock-frequency in xlnx,xps-iic-2.00.a.yaml
> ---
> .../devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml
> index 8d241a703d85..92cb9006e8b7 100644
> --- a/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml
> +++ b/Documentation/devicetree/bindings/i2c/xlnx,xps-iic-2.00.a.yaml
> @@ -14,7 +14,9 @@ allOf:
>
> properties:
> compatible:
> - const: xlnx,xps-iic-2.00.a
> + enum:
> + - xlnx,xps-iic-2.00.a
> + - xlnx,axi-iic-2.1
Keep the list sorted alphabetically
>
> reg:
> maxItems: 1
> @@ -30,6 +32,10 @@ properties:
> description: |
> Input clock name.
>
> + clock-frequency:
> + description:
> + Optional I2C SCL clock frequency.
Is maximum known? If this is optional, you should have here default.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-02 9:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:41 [PATCH V4 0/9] Added Standard mode and SMBus support Manikanta Guntupalli
2023-02-02 9:41 ` [PATCH V4 1/9] i2c: xiic: Add standard mode support for > 255 byte Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 2/9] i2c: xiic: Fix Rx and Tx paths in standard mode Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 3/9] i2c: xiic: Switch to Xiic standard mode for i2c-read Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 4/9] i2c: xiic: Add wait for FIFO empty in send_tx Manikanta Guntupalli
2023-02-03 16:35 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 5/9] i2c: xiic: Add smbus_block_read functionality Manikanta Guntupalli
2023-02-03 16:37 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 6/9] i2c: xiic: Remove interrupt enable/disable in Rx path Manikanta Guntupalli
2023-02-03 16:37 ` Wolfram Sang
2023-02-02 9:41 ` [PATCH V4 7/9] dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to Manikanta Guntupalli
2023-02-02 9:46 ` Krzysztof Kozlowski [this message]
2023-02-02 9:41 ` [PATCH V4 8/9] i2c: xiic: Update compatible with new IP version Manikanta Guntupalli
2023-02-02 9:41 ` [PATCH V4 9/9] i2c: xiic: Add SCL frequency configuration support Manikanta Guntupalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=266a4dec-ec2c-3c21-975e-301e3a7bb5f3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=manion05gk@gmail.com \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=raviteja.narayanam@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.goud@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).