devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: Add dvs-gpios to rk3288-veyron-jerry
@ 2019-03-22 16:52 Douglas Anderson
  2019-03-25 12:30 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Douglas Anderson @ 2019-03-22 16:52 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: mka, ryandcase, Douglas Anderson, devicetree, linux-kernel,
	linux-rockchip, Rob Herring, Mark Rutland, linux-arm-kernel

When the rk3288-jerry device tree was first submitted we left out the
dvs-gpios because I pointed out that the property "dvs-gpios" wasn't
yet supported upstream [1].  Soon after that the property was added in
commit bad47ad2eef3 ("regulator: rk808: fixed the overshoot when
adjust voltage").  ...but we forgot to go back and add the property to
the jerry device tree file.  Let's do so now.

NOTE: without this patch, jerry is likely still stable (thanks to the
fallback of making many small jumps in the rk808 regulator code) but
it'll take quite a bit longer to make voltage transitions.

[1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=WwFgjzbk9xF5TU_ie6UnHQMyrZ176D4+jJTWWOoaKC2Q@mail.gmail.com/

Fixes: f3ee390e4ef2 ("ARM: dts: rockchip: add veyron-jerry board")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---

 arch/arm/boot/dts/rk3288-veyron-jerry.dts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/rk3288-veyron-jerry.dts b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
index 2ba89895c33a..cc3019dc38e1 100644
--- a/arch/arm/boot/dts/rk3288-veyron-jerry.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-jerry.dts
@@ -61,7 +61,9 @@
 
 &rk808 {
 	pinctrl-names = "default";
-	pinctrl-0 = <&pmic_int_l>;
+	pinctrl-0 = <&pmic_int_l &dvs_1 &dvs_2>;
+	dvs-gpios = <&gpio7 RK_PB4 GPIO_ACTIVE_HIGH>,
+		    <&gpio7 RK_PB7 GPIO_ACTIVE_HIGH>;
 
 	regulators {
 		mic_vcc: LDO_REG2 {
-- 
2.21.0.392.gf8f6787159e-goog

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: Add dvs-gpios to rk3288-veyron-jerry
  2019-03-22 16:52 [PATCH] ARM: dts: rockchip: Add dvs-gpios to rk3288-veyron-jerry Douglas Anderson
@ 2019-03-25 12:30 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2019-03-25 12:30 UTC (permalink / raw)
  To: Douglas Anderson
  Cc: mka, ryandcase, devicetree, linux-kernel, linux-rockchip,
	Rob Herring, Mark Rutland, linux-arm-kernel

Am Freitag, 22. März 2019, 17:52:09 CET schrieb Douglas Anderson:
> When the rk3288-jerry device tree was first submitted we left out the
> dvs-gpios because I pointed out that the property "dvs-gpios" wasn't
> yet supported upstream [1].  Soon after that the property was added in
> commit bad47ad2eef3 ("regulator: rk808: fixed the overshoot when
> adjust voltage").  ...but we forgot to go back and add the property to
> the jerry device tree file.  Let's do so now.
> 
> NOTE: without this patch, jerry is likely still stable (thanks to the
> fallback of making many small jumps in the rk808 regulator code) but
> it'll take quite a bit longer to make voltage transitions.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=WwFgjzbk9xF5TU_ie6UnHQMyrZ176D4+jJTWWOoaKC2Q@mail.gmail.com/
> 
> Fixes: f3ee390e4ef2 ("ARM: dts: rockchip: add veyron-jerry board")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>

applied for 5.2

Thanks
Heiko

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-25 12:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-22 16:52 [PATCH] ARM: dts: rockchip: Add dvs-gpios to rk3288-veyron-jerry Douglas Anderson
2019-03-25 12:30 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).