From: Luca Weiss <luca@z3ntu.xyz>
To: Rob Herring <robh+dt@kernel.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shunqian Zheng <zhengsq@rock-chips.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 2/3] media: dt-bindings: ov2685: convert to dtschema
Date: Wed, 19 Apr 2023 17:54:29 +0200 [thread overview]
Message-ID: <2675347.mvXUDI8C0e@z3ntu.xyz> (raw)
In-Reply-To: <CAL_JsqLB37Y-V-8uWPdnc_YaActtQUhJArv50Rz8K_CF5cbNhw@mail.gmail.com>
On Mittwoch, 19. April 2023 01:54:18 CEST Rob Herring wrote:
> On Thu, Mar 23, 2023 at 12:58 PM Luca Weiss <luca@z3ntu.xyz> wrote:
> > Convert the text-based dt-bindings to yaml.
> >
> > Changes from original txt:
> > * Take wording for various properties from other yaml bindings, this
> >
> > removes e.g. volt amount from schema since it isn't really relevant
> > and the datasheet is a better source.
> >
> > * Don't make reset-gpios a required property since it can be tied to
> >
> > DOVDD instead.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> > ---
> >
> > .../devicetree/bindings/media/i2c/ov2685.txt | 41 ---------
> > .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101
> > +++++++++++++++++++++ MAINTAINERS
> > | 1 +
> > 3 files changed, 102 insertions(+), 41 deletions(-)
>
> Now warning in linux-next:
>
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/rockchip
> -isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema:
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovti
> ,ov2685.yaml
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovt
> i,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is
> too short
> From schema:
> /builds/robherring/linux-dt/Documentation/devicetree/bindings/media/i2c/ovti
> ,ov2685.yaml
Right, since Sakari changed maxItems=1 to maxItems=2, now minItems is also 2
but it should be 1. I'll send a patch to fix this.
Regards
Luca
next prev parent reply other threads:[~2023-04-19 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 17:57 [PATCH v4 0/3] Improvements for OmniVision OV2685 Luca Weiss
2023-03-23 17:57 ` [PATCH v4 1/3] media: dt-bindings: media: rkisp1: complete ov2685 example Luca Weiss
2023-03-23 17:57 ` [PATCH v4 2/3] media: dt-bindings: ov2685: convert to dtschema Luca Weiss
2023-03-31 8:39 ` Sakari Ailus
2023-03-31 9:18 ` Luca Weiss
2023-03-31 9:39 ` Sakari Ailus
2023-04-18 23:54 ` Rob Herring
2023-04-19 15:54 ` Luca Weiss [this message]
2023-03-23 17:57 ` [PATCH v4 3/3] media: i2c: ov2685: Make reset gpio optional Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2675347.mvXUDI8C0e@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=zhengsq@rock-chips.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).