From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74F9DC4332F for ; Fri, 21 Oct 2022 00:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbiJUAuN (ORCPT ); Thu, 20 Oct 2022 20:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbiJUAuM (ORCPT ); Thu, 20 Oct 2022 20:50:12 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A50796233 for ; Thu, 20 Oct 2022 17:50:05 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id p11so829977qvr.12 for ; Thu, 20 Oct 2022 17:50:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DNhuHakSL+A+C95nv/zMK27Kss6ODk0L9tiW1PQtBR0=; b=wLqcY/sjAMnkPEwBatGvm+Q2YSCvv6BJKkwbiMpB43S31G+TFf7qj8wChiLYEseF50 iXsQyJOmqmwUAK7oSzuN1yuD0UHLdfTyRetLW+gAX9i4v245SE1H7K3COCQm6m7IbHv/ 0tfMrHEbUOqPyFJ5nyWtneshzJbebIaCz/QOvpzrun68S9Sh71LCc6N/EIEaSrlKMcyF 3WQfTnNLsZYbUDsCymrGX06q3Gppz1JpS1dVqhAcn67bT/BrMjzex6qtcf2F7cNcF8Fx tyWTAPz5wsKbQX7AMsoBlod8BrLGHsdcr66nXBM1Nfj5odUPcAihLOqrVK3FuVMn6K2e VPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DNhuHakSL+A+C95nv/zMK27Kss6ODk0L9tiW1PQtBR0=; b=uoXpO5gzYod2MwzTsIJkrR8OZ9oqA16/uv7n4oiIu91ppOah+GmbL/iVonJn0uGn/W 0W/Jw2qyO6hHTPNIQKBzUVKTvz76lj255YBBRRN+FLHZjChq4QwXWZzywN0UdOSQBRGT zbA2HMDNp59muhPVrye8yWsis5TZjxHLcg6uUT4Vc7cM79v5Y4fAMKtOPjN7Vij8C3/S BOKSJtfyzRk5SY7Jv4a2QWSI0qgJM8W5KDrPLcGz4+D2dUOMDxXo11fJJDvJ+lV3ibac VkntO2HL8CquY6pENqJQjbnYzfvGaFMBm+sMgOBAPhCdU6QipxK5bFqnh7uNSNiY1A/b AO0Q== X-Gm-Message-State: ACrzQf1xh/xKeWYS/8t5Qk4rdlGeO7NMFQuvQP0km5KUas7THKC2aXDY wiPRLgi0vdA1bJLTMOpzx2QZfA== X-Google-Smtp-Source: AMsMyM7swZnwLYLIkpvx9eQc6XXcJZPEDmpHNzly9yTXyyG2dSm5SDSgtDd75mPbfxF32tgdOipsBA== X-Received: by 2002:ad4:5f4f:0:b0:4b1:db1e:6c01 with SMTP id p15-20020ad45f4f000000b004b1db1e6c01mr14267727qvg.100.1666313404703; Thu, 20 Oct 2022 17:50:04 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id p6-20020a05620a132600b006ee7923c187sm8265946qkj.42.2022.10.20.17.50.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 20 Oct 2022 17:50:04 -0700 (PDT) Message-ID: <2694afda-fe53-8f6c-85dd-390b42a39d93@linaro.org> Date: Thu, 20 Oct 2022 20:50:02 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v2 1/2] dt-bindings: phy: renesas: Document Renesas Ethernet SERDES Content-Language: en-US To: Yoshihiro Shimoda , kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20221019083449.933005-1-yoshihiro.shimoda.uh@renesas.com> <20221019083449.933005-2-yoshihiro.shimoda.uh@renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20221019083449.933005-2-yoshihiro.shimoda.uh@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/10/2022 04:34, Yoshihiro Shimoda wrote: > Document Renesas Etherent SERDES for R-Car S4-8 (r8a779f0). > > Signed-off-by: Yoshihiro Shimoda > --- > .../phy/renesas,r8a779f0-ether-serdes.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml > > diff --git a/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml b/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml > new file mode 100644 > index 000000000000..ea392cd6e947 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/renesas,r8a779f0-ether-serdes.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/renesas,r8a779f0-ether-serdes.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas Ethernet SERDES > + > +maintainers: > + - Yoshihiro Shimoda > + > +properties: > + compatible: > + const: renesas,r8a779f0-ether-serdes > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + '#phy-cells': > + description: Port number of SERDES. > + const: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - resets > + - power-domains > + - '#phy-cells' > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + serdes@e6444000 { Phy devices are usually named "phy" and you use it as a phy device. As serdes I guess you refer to actual hardware implementation, but still the role is phy, isn't it? > + compatible = "renesas,r8a779f0-ether-serdes"; Use 4 spaces for example indentation. > + reg = <0xe6444000 0xc00>; > + clocks = <&cpg CPG_MOD 1506>; > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > + resets = <&cpg 1506>; > + #phy-cells = <1>; > + }; Best regards, Krzysztof