From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 923073E7140 for ; Thu, 23 Apr 2026 11:13:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776942791; cv=none; b=e322++uH8pIUbKXOXsZ82sHQKnv/Xq7s7t2pxzg9q/uPzmnOkKMjKNORDdzudDY14nRjjCjaU6GbfmSVuA0LgBmUFe/y9RmzScan+hniwQODgflOc5W3KagArHOM0yUDnLmLRct1s74TKxh6Y8YI7wHDAeGCAB4cs3BNYrnJZUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776942791; c=relaxed/simple; bh=gw6X5v14HsR1yPEPi8cmZoNjyQt53JZZt7VmNyKfMDc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EBsrbSnCQONujnhl9uxim3njTUmRrMtzH55y/z4ZYJukiGJ3C1sTT406Ga7qt2jQgEu7HWRov7MY+0OPnZdX/N5UICRMF8mD3TQ2umrV0j5V5AnRs5CLjOS1urEzlddNwygiRnsstOMfvX2QIBhc4X08ART9psfSvyukXNCO/RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mqbmyKzQ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GfpuyOa9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mqbmyKzQ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GfpuyOa9" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uG503044149 for ; Thu, 23 Apr 2026 11:13:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pPX1s4ZBBC0Y0Zs94AvDgZwI1JUIyluWWR+MfmZt+SA=; b=mqbmyKzQgrYyk07r YzsfVOBB38KJ3ntF+YjZDp9KB/iPWV9uldFZeG8vdJNDyh5Pj3Xav1r4hpCdByHH FbNS8rzHjlJ9XQJeurumT9qt6ORMW0jKd++OUrS1SyW+1hu6R6/a+NBCghaFEQtV vjV+4VN1m+Wz7PkeLi0qAAr/Wo7OZP9erlQd802W17dY1ZvxDT8zI1gsBJUxxi3g FfgmGYCa3ulE1kFLmWFFfKcFvmBfCnekKk3ry/JSPb2BlJIJdQlfBcxi7hlLTF3V uFTor6a/xhCZzBwIrVrfeqcUF1FNl3onLO1JRCMnYnWh0xyfzoxye/7rpOKPiyvd f2U6jw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq1jh3jba-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 11:13:09 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50fad7b0ae2so12795101cf.2 for ; Thu, 23 Apr 2026 04:13:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776942789; x=1777547589; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pPX1s4ZBBC0Y0Zs94AvDgZwI1JUIyluWWR+MfmZt+SA=; b=GfpuyOa9SSXic+EINya77p/Th3N+lZv/tI4r+melpPyd9FNcHP5P2lBVRhGcZDYEHP oD4m8rX9W8JTtpJdR4jqbwx4GZ4E7NcV6RpYyVu11XltDv1NlmHzXJw8VUYduWkelpDa T6i5ldgPUFlqBMr1mld93jSsJ+WutsIe9s6t5TSBXKOeGj7v0nn5/FO1T2LkL4VXfFZU cpxUugUmIOkiYYImAB8V3gFoAoIN+DviApR+0qVy21nL7YK9VF2Qf4edcLEPwWVwd1IA KGVhlnRpEaMakslGJoYEF0EybLng42xOo7SfKAZ0svmxoaZ6Em0HXQk86GEsvdHyxYyk cI0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776942789; x=1777547589; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pPX1s4ZBBC0Y0Zs94AvDgZwI1JUIyluWWR+MfmZt+SA=; b=fPQ1mqvyzeDGX6jlHJeLOzgvx0s5kZPnrogN9KwD28iQIFQjSJyNsivc3MdjvTIZou xUUluKnpFAC94UZ/pGfwVuwRXmHjkF6tq9pISHG3d+KoC9anh2+ubUSh7y0pTB9FHs9m vC+6FhUr/XB+d0MRqLV3+waSZ2CX+0Lh5xTQD3lN+KNlkKXX5o/8FhaB5eihECGduqks F1mi7V8j06GnvItZk+xTgNpiL16d53Orc4Q0fioZbx9G8tEYSnc4W4y1U/iAyTJDP08+ Zdxe3CeVb8xzeaU/S0g1JLNMjSHbxMUroA8Tr/SWNpBrsZpcWnmQwnQBPIcK+s1JXc9j 7CEQ== X-Forwarded-Encrypted: i=1; AFNElJ9g9Hb6nkKU3M38UBld6g7o1Lk7nlTiCzWMlqaZkHCidDLrEVVCRlN8G+vXDF4R5mBaNpI+6TYVTgZD@vger.kernel.org X-Gm-Message-State: AOJu0YwCn4vLWTPeZPZZbFMYbMAKnL49QOcCuJVufOgQCFgjmC3S6jwZ D7UuD7prvCF2hLYAbD/Jt5pq1kJDLH43rJ3AKV1TV4mCFk5RFR40PZRBKZvX21lwzVQor7o+9Wm gWMkA3xDawr9fKiDsfmOpPGeiZK6/y18o+q8QfqdHOOGLU32XSTamF9PZG0bXCE5Q X-Gm-Gg: AeBDiety35MWdCXXyI8qT9KrZIz6EbKRce761oaSAGcpoD7bjR4zfXr56PW1baMCw77 a080ZRbhEvANu9TOKOKKXHoq9G7BBaNQvgyUhMX9QttRVHtOQBHwKXGmwPuYA+gCrJB3D2x42BN PxkWVanBwMsFs300JLfWllZoTP7gaw1xDx3Elyx/cHAAG9JRjsXm5KEEGLIyWgRng71QzrXK1wd dmOnrvmpF03Yvb3RWPvkX7HTOpFDpmgri8O5wSDOJTIjX5dwiTsrOZXvtRfWIFE+kRfBRiTUptA 73gtkMgYFEmPLU4weDZmRR+TyB09ftyIBnTcFyTVwskSzf/tJdsaR/oNbtwWCayFznlP72TcuOw FcL6tclSdWqAlahLQWeivGHgmZP5JvIZxOdURj/lgfx9mpZIXiCT0NILyynWGeEsfp14pl7Q5dj tQsDT3XLxRyFaqTA== X-Received: by 2002:a05:622a:38e:b0:50d:714d:e966 with SMTP id d75a77b69052e-50e3669e233mr267073651cf.0.1776942788760; Thu, 23 Apr 2026 04:13:08 -0700 (PDT) X-Received: by 2002:a05:622a:38e:b0:50d:714d:e966 with SMTP id d75a77b69052e-50e3669e233mr267073131cf.0.1776942788285; Thu, 23 Apr 2026 04:13:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba451be2c9bsm661013166b.23.2026.04.23.04.13.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 04:13:07 -0700 (PDT) Message-ID: <269bdec3-6340-4b27-9b38-3fc1dfc958c8@oss.qualcomm.com> Date: Thu, 23 Apr 2026 13:13:04 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] clk: qcom: clk-alpha-pll: Add support to skip PLL configuration To: Dmitry Baryshkov , Jagadeesh Kona Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Neil Armstrong , Lee Jones , Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Maulik Shah , Taniya Das References: <20260420-cesta-sm870-dispcc-v1-0-eb27d845df9c@oss.qualcomm.com> <20260420-cesta-sm870-dispcc-v1-7-eb27d845df9c@oss.qualcomm.com> <5vkpjjuq6vh2mr4lcq5cwqd4h5cbserf3n756d465kheuwl5fk@tu3amjwe5k57> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <5vkpjjuq6vh2mr4lcq5cwqd4h5cbserf3n756d465kheuwl5fk@tu3amjwe5k57> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDExMSBTYWx0ZWRfX+lH7+5OuPhKO Tw0/71rxKUA3aUkPnWZFtdiHFERDnBReihPOh53yv/mLUIWdqCdBmp0T0KdjkITct9CeKx2yMom lNgvNPVGQfFeC+8CMxu+7Ljibb1DNfAtckQYm1F2q/RwD4tMnAOK8yTMxuyMZ1JQg8nKGiaqYvk Zdzb2dH5WrfQaMOKFm3qdE/4jj7npmWqRvEIxQyh67+iw8BIpwlctM7WPqjbemlbFGMMPokjzCu pkC4nvqifE8qmv6zCQ126F9f63M0MbbwPMKAK/zohokZewhxRJ8XNwmbfp8a1i4yHFE71szNvNJ HFwfKDSCwbJVyr3VQMY5LIAy/heWxZfSgo2j2WlUBY7fx6BvRuT6UJ1kvRFDMXRxVg9QrTE7rvw vfc0138z+Klv9L8o/QNs0qfA7e4H//NsOiuf0OcfHEycvoLsD/aYhMFwR5sMSqVaTCQV0/N829e BjAMfPdPc4aRxOKBo9Q== X-Authority-Analysis: v=2.4 cv=OeyoyBTY c=1 sm=1 tr=0 ts=69e9fec5 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=ejO83hDQy6DSrCu7mY0A:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: Wx81OH1Dygyzp5VR_f_T1y4-XdXVoId5 X-Proofpoint-ORIG-GUID: Wx81OH1Dygyzp5VR_f_T1y4-XdXVoId5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230111 On 4/22/26 8:28 PM, Dmitry Baryshkov wrote: > On Mon, Apr 20, 2026 at 09:59:00PM +0530, Jagadeesh Kona wrote: >> Some PLLs are already configured as part of CRM(CESTA Resource >> manager) initialization. Add support to skip PLL reconfiguration >> for such PLLs that are already configured. >> >> Signed-off-by: Jagadeesh Kona >> --- >> drivers/clk/qcom/clk-alpha-pll.c | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c >> index 67fc97739d0d4c26aec0bac5d43d1b87d297bc6a..2f4ebf4d3884b92c981dbe0e67245704a88881ad 100644 >> --- a/drivers/clk/qcom/clk-alpha-pll.c >> +++ b/drivers/clk/qcom/clk-alpha-pll.c >> @@ -2332,7 +2332,7 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_zonda_ops); >> void clk_lucid_evo_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap, >> const struct alpha_pll_config *config) >> { >> - u32 lval = config->l; >> + u32 lval = config->l, regval; >> >> /* >> * If the bootloader left the PLL enabled it's likely that there are >> @@ -2343,6 +2343,12 @@ void clk_lucid_evo_pll_configure(struct clk_alpha_pll *pll, struct regmap *regma >> return; >> } >> >> + /* Return early if PLL is already configured */ >> + regmap_read(regmap, PLL_L_VAL(pll), ®val); >> + regval &= LUCID_EVO_PLL_L_VAL_MASK; >> + if (regval) >> + return; >> + > > Why is it being applied only to Lucid EVO PLLs? These clocks already have a an .is_enabled() callback, could that be treated as equivalent? Konrad