From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48400C433EF for ; Tue, 14 Jun 2022 14:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237898AbiFNOoU (ORCPT ); Tue, 14 Jun 2022 10:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356391AbiFNOnr (ORCPT ); Tue, 14 Jun 2022 10:43:47 -0400 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B43C71ADB4 for ; Tue, 14 Jun 2022 07:43:45 -0700 (PDT) Received: by mail-pf1-x434.google.com with SMTP id u37so337219pfg.3 for ; Tue, 14 Jun 2022 07:43:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=4cFnRvgmCgZilg+kua2nS8hJF1hI6XababS0iH20TWo=; b=wBDys1FsoPdSRBO3RkTw5jlPlUveLtj70wIv5jWeDeDLEXnPegBmCF3tkiBJbp6xmr kcnSZ9qvtjIuBe7II3as/t5SoZ1juk65X+SVmJ9SOmJ/DN+edJzpzYzN/UY1U8ydxEy4 qNdG/90Ex/j6q6jZ6FPsB+YADxJK5BpFKLhyNaj2ZEinXendLg5kraR7ulE8m0frtNm2 /dILb8+Azt2pGcQ4CXh1KORlJIOxo7q47pTt9HYRGfNdcgxZuJZ3IpLrNAYlbreaC/f9 jrq1sKedHCX/0IVWRvzdOBW93TTTpD+39TZicokOhiMCldjMxSosTQPQnmgVMVAZ4PEx X8Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4cFnRvgmCgZilg+kua2nS8hJF1hI6XababS0iH20TWo=; b=RwzfWIM+nb66M1au2qi3wqdacwY80IFK1TwHRWpR5cHmkPx9XSDKIe8tBCA4okvOGy r7xd/on12+Yf8w6IB4ic0xq3lksFmn5ihhz/Q8JoLF6ojDCpGKt0xhsAlbEGubFadhMQ ZIZaA8KE6NSXCCJdKBMiCJj5Gh9yhBYV1o2rT8p4AYxvJtw9Ku3RYpPauYrSDxe7og1f YrmGrTya9RxvUJv62NCSUj1E9ZoRZGvOZbvFAZjHLdQWwB4H8pusaBiJtPYVqHkEwFnG BRZ2Gj6oddwB+QKfEWE44GzReB7vfA+rSUA9nkmFs5YYvwoiO4xfQg//Y/cKrYxbOncQ ciWQ== X-Gm-Message-State: AOAM530t+f2rtp33V1B3X/tmFVNuoCzdwJRiDiQa18y3U05ewQxkLq6h iUoeC0/oFvxlbO8Rvf9SvJdGhQ== X-Google-Smtp-Source: ABdhPJypR8vjAMFkGvsZC+cplFp5gkSzlPo/jUCX+Nh+gTxI9BNzxBVZce/Kf+3LESVZiCbBz1Stcg== X-Received: by 2002:a05:6a00:a21:b0:522:9134:c620 with SMTP id p33-20020a056a000a2100b005229134c620mr4853896pfh.68.1655217824803; Tue, 14 Jun 2022 07:43:44 -0700 (PDT) Received: from [172.20.0.51] ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id g7-20020a63ad07000000b003db822e2170sm7866328pgf.23.2022.06.14.07.43.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jun 2022 07:43:44 -0700 (PDT) Message-ID: <26dc329e-b663-e779-a30f-b495206ced48@linaro.org> Date: Tue, 14 Jun 2022 07:43:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] media: i2c: imx412: Add imx577 compatible string Content-Language: en-US To: Sakari Ailus Cc: jacopo@jmondi.org, paul.j.murphy@intel.com, daniele.alessandrelli@intel.com, mchehab@kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dmitry.baryshkov@linaro.org, konrad.dybcio@somainline.org, andrey.konovalov@linaro.org References: <20220607134057.2427663-1-bryan.odonoghue@linaro.org> <20220607134057.2427663-3-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/06/2022 05:00, Sakari Ailus wrote: > Thanks for the patch. > > Surely the sensors still have some differences. They do, they absolutely do, the imx577 has a whole bunch of extra modes. We don't have any reference code or access to documentation for those modes. My reference is the qualcomm camx code for the rb5 board, which includes a imx577 sensor. That stack uses the same init code as for the 412. So for that baseline mode, the imx412 driver works perfectly. > Even if the same registers would work as-is (the imx577 might still benefit > from different MSRs?), the user should know which sensor it is. I.e. please > set the media entity name accordingly. See e.g. the CCS driver for an > example. Agreed, I'll do that. --- bod