From: Neil Armstrong <neil.armstrong@linaro.org>
To: Jianhua Lu <lujianhua000@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523
Date: Fri, 10 Mar 2023 17:57:24 +0100 [thread overview]
Message-ID: <26e7dd52-215b-ce55-394d-b0730d5015b4@linaro.org> (raw)
In-Reply-To: <20230310132144.2241-2-lujianhua000@gmail.com>
Hi,
On 10/03/2023 14:21, Jianhua Lu wrote:
> Add a driver for panels using the Novatek NT36523 display driver IC.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> Changes in v4:
> - add multiple modes support
> - use dev_err_probe helper
> - fix dsi_info type string
> - reimplement mipi_dsi_dual_dcs_write_seq() macro
>
> Changes in v3:
> - Refactor source code
>
> Changes in v2:
> - Refactor and clean up source code
>
> MAINTAINERS | 7 +
> drivers/gpu/drm/panel/Kconfig | 10 +
> drivers/gpu/drm/panel/Makefile | 1 +
> drivers/gpu/drm/panel/panel-novatek-nt36523.c | 771 ++++++++++++++++++
> 4 files changed, 789 insertions(+)
> create mode 100644 drivers/gpu/drm/panel/panel-novatek-nt36523.c
>
<snip>
It looks great now, Konrad do you have some comments on this revision ?
Neil
next prev parent reply other threads:[~2023-03-10 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 13:21 [PATCH v4 1/2] dt-bindings: display: panel: Add Novatek NT36523 bindings Jianhua Lu
2023-03-10 13:21 ` [PATCH v4 2/2] drm/panel: Add driver for Novatek NT36523 Jianhua Lu
2023-03-10 16:57 ` Neil Armstrong [this message]
2023-03-10 18:07 ` Jianhua Lu
2023-03-10 18:10 ` Konrad Dybcio
2023-03-10 18:35 ` Jianhua Lu
2023-03-10 22:50 ` Linus Walleij
2023-03-11 10:05 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26e7dd52-215b-ce55-394d-b0730d5015b4@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox