[PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse

devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
@ 2017-05-12  2:44 Finley Xiao
       [not found] ` <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Finley Xiao @ 2017-05-12  2:44 UTC (permalink / raw)
  To: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	huangtao-TNX95d0MmH7DzftRWevZcw, tony.xie-TNX95d0MmH7DzftRWevZcw,
	cl-TNX95d0MmH7DzftRWevZcw, frank.wang-TNX95d0MmH7DzftRWevZcw,
	Finley Xiao

This adds the necessary data for handling eFuse on the rk322x.

Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
 Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
 drivers/nvmem/rockchip-efuse.c                             | 4 ++++
 2 files changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
index 94aeeea..194926f 100644
--- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
+++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
@@ -4,6 +4,7 @@ Required properties:
 - compatible: Should be one of the following.
   - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
   - "rockchip,rk3188-efuse" - for RK3188 SoCs.
+  - "rockchip,rk322x-efuse" - for RK322x SoCs.
   - "rockchip,rk3288-efuse" - for RK3288 SoCs.
   - "rockchip,rk3399-efuse" - for RK3399 SoCs.
 - reg: Should contain the registers location and exact eFuse size
diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
index 423907b..a0d4ede 100644
--- a/drivers/nvmem/rockchip-efuse.c
+++ b/drivers/nvmem/rockchip-efuse.c
@@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
 	{
+		.compatible = "rockchip,rk322x-efuse",
+		.data = (void *)&rockchip_rk3288_efuse_read,
+	},
+	{
 		.compatible = "rockchip,rk3288-efuse",
 		.data = (void *)&rockchip_rk3288_efuse_read,
 	},
-- 
2.7.4


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 4+ messages in thread

[parent not found: <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>]

* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
       [not found] ` <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
@ 2017-05-15 20:45   ` Rob Herring
  2017-06-05  3:51   ` Frank Wang
  2017-06-15 15:12   ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2017-05-15 20:45 UTC (permalink / raw)
  To: Finley Xiao
  Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A,
	mark.rutland-5wv7dgnIgG8, heiko-4mtYJXux2i+zQB+pC5nmwQ,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	huangtao-TNX95d0MmH7DzftRWevZcw, tony.xie-TNX95d0MmH7DzftRWevZcw,
	cl-TNX95d0MmH7DzftRWevZcw, frank.wang-TNX95d0MmH7DzftRWevZcw

On Fri, May 12, 2017 at 10:44:20AM +0800, Finley Xiao wrote:
> This adds the necessary data for handling eFuse on the rk322x.
> 
> Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
>  drivers/nvmem/rockchip-efuse.c                             | 4 ++++
>  2 files changed, 5 insertions(+)

Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
       [not found] ` <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  2017-05-15 20:45   ` Rob Herring
@ 2017-06-05  3:51   ` Frank Wang
  2017-06-15 15:12   ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Frank Wang @ 2017-06-05  3:51 UTC (permalink / raw)
  To: Finley Xiao, heiko-4mtYJXux2i+zQB+pC5nmwQ
  Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	huangtao-TNX95d0MmH7DzftRWevZcw, tony.xie-TNX95d0MmH7DzftRWevZcw,
	cl-TNX95d0MmH7DzftRWevZcw, wmc-TNX95d0MmH7DzftRWevZcw

Hi Finley,

On 2017/5/12 10:44, Finley Xiao wrote:
> This adds the necessary data for handling eFuse on the rk322x.
>
> Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>   Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
>   drivers/nvmem/rockchip-efuse.c                             | 4 ++++
>   2 files changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 94aeeea..194926f 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
>   - compatible: Should be one of the following.
>     - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
>     - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> +  - "rockchip,rk322x-efuse" - for RK322x SoCs.

As the comments from Heiko in other patches, compatibles should not 
contain wildcards, so could you please make this
     "rockchip,rk3228-efuse"
instead?

>     - "rockchip,rk3288-efuse" - for RK3288 SoCs.
>     - "rockchip,rk3399-efuse" - for RK3399 SoCs.
>   - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index 423907b..a0d4ede 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
>   		.data = (void *)&rockchip_rk3288_efuse_read,
>   	},
>   	{
> +		.compatible = "rockchip,rk322x-efuse",
> +		.data = (void *)&rockchip_rk3288_efuse_read,
> +	},

The same as above.


BR.
Frank

> +	{
>   		.compatible = "rockchip,rk3288-efuse",
>   		.data = (void *)&rockchip_rk3288_efuse_read,
>   	},


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse
       [not found] ` <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
  2017-05-15 20:45   ` Rob Herring
  2017-06-05  3:51   ` Frank Wang
@ 2017-06-15 15:12   ` Heiko Stuebner
  2 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2017-06-15 15:12 UTC (permalink / raw)
  To: Finley Xiao
  Cc: srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, mark.rutland-5wv7dgnIgG8,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	huangtao-TNX95d0MmH7DzftRWevZcw, tony.xie-TNX95d0MmH7DzftRWevZcw,
	cl-TNX95d0MmH7DzftRWevZcw, frank.wang-TNX95d0MmH7DzftRWevZcw

Am Freitag, 12. Mai 2017, 10:44:20 CEST schrieb Finley Xiao:
> This adds the necessary data for handling eFuse on the rk322x.
> 
> Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt | 1 +
>  drivers/nvmem/rockchip-efuse.c                             | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> index 94aeeea..194926f 100644
> --- a/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-efuse.txt
> @@ -4,6 +4,7 @@ Required properties:
>  - compatible: Should be one of the following.
>    - "rockchip,rk3066a-efuse" - for RK3066a SoCs.
>    - "rockchip,rk3188-efuse" - for RK3188 SoCs.
> +  - "rockchip,rk322x-efuse" - for RK322x SoCs.

should be rockchip,rk3228-efuse.

While rk3228 and rk3229 are pratically the same soc, the compatible still
shouldn't contain placeholders.


Heiko

>    - "rockchip,rk3288-efuse" - for RK3288 SoCs.
>    - "rockchip,rk3399-efuse" - for RK3399 SoCs.
>  - reg: Should contain the registers location and exact eFuse size
> diff --git a/drivers/nvmem/rockchip-efuse.c b/drivers/nvmem/rockchip-efuse.c
> index 423907b..a0d4ede 100644
> --- a/drivers/nvmem/rockchip-efuse.c
> +++ b/drivers/nvmem/rockchip-efuse.c
> @@ -170,6 +170,10 @@ static const struct of_device_id rockchip_efuse_match[] = {
>  		.data = (void *)&rockchip_rk3288_efuse_read,
>  	},
>  	{
> +		.compatible = "rockchip,rk322x-efuse",
> +		.data = (void *)&rockchip_rk3288_efuse_read,
> +	},
> +	{
>  		.compatible = "rockchip,rk3288-efuse",
>  		.data = (void *)&rockchip_rk3288_efuse_read,
>  	},
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-06-15 15:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-12  2:44 [PATCH] nvmem: rockchip-efuse: add support for rk322x-efuse Finley Xiao
     [not found] ` <1494557060-105230-1-git-send-email-finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-15 20:45   ` Rob Herring
2017-06-05  3:51   ` Frank Wang
2017-06-15 15:12   ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).