From: Luca Weiss <luca@z3ntu.xyz>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 09/11] ARM: dts: qcom: msm8974: drop 'regulator' property from SAW2 device
Date: Tue, 12 Dec 2023 18:32:31 +0100 [thread overview]
Message-ID: <2708106.mvXUDI8C0e@z3ntu.xyz> (raw)
In-Reply-To: <20231208004417.3393299-10-dmitry.baryshkov@linaro.org>
On Freitag, 8. Dezember 2023 01:44:15 CET Dmitry Baryshkov wrote:
> The SAW2 device should describe the regulator constraints rather than
> just declaring that it has the regulator.
>
> Drop the 'regulator' property. If/when CPU voltage scaling is
> implemented for this platform, proper regulator node show be added
> instead.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> arch/arm/boot/dts/qcom/qcom-msm8974.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi index ee202f3f161e..3e1e88d69c2e
> 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974.dtsi
> @@ -349,7 +349,6 @@ apcs: syscon@f9011000 {
> saw_l2: power-controller@f9012000 {
> compatible = "qcom,saw2";
Hi Dmitry,
With the patches touching the dt bindings I don't see this "qcom,saw2"
compatible without a second one being accepted by the bindings? Do you have a
suggestion what do to there? Also thinking about msm8226 which also has a
saw_l2.
Thanks for working on this old stuff!
Regards
Luca
> reg = <0xf9012000 0x1000>;
> - regulator;
> };
>
> watchdog@f9017000 {
next prev parent reply other threads:[~2023-12-12 17:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 0:44 [PATCH v6 00/11] soc: qcom: spm: add support for SPM regulator Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 01/11] dt-bindings: soc: qcom: merge qcom,saw2.txt into qcom,spm.yaml Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 02/11] dt-bindings: soc: qcom: qcom,saw2: define optional regulator node Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 03/11] soc: qcom: spm: remove driver-internal structures from the driver API Dmitry Baryshkov
2023-12-11 10:51 ` Konrad Dybcio
2023-12-08 0:44 ` [PATCH v6 04/11] soc: qcom: spm: add support for voltage regulator Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 05/11] ARM: dts: qcom: apq8064: rename SAW nodes to power-manager Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 06/11] ARM: dts: qcom: apq8064: declare SAW2 regulators Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 07/11] ARM: dts: qcom: msm8960: " Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 08/11] ARM: dts: qcom: apq8084: drop 'regulator' property from SAW2 device Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 09/11] ARM: dts: qcom: msm8974: " Dmitry Baryshkov
2023-12-12 17:32 ` Luca Weiss [this message]
2023-12-08 0:44 ` [PATCH v6 10/11] ARM: dts: qcom: ipq4019: drop 'regulator' property from SAW2 devices Dmitry Baryshkov
2023-12-08 0:44 ` [PATCH v6 11/11] ARM: dts: qcom: ipq8064: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2708106.mvXUDI8C0e@z3ntu.xyz \
--to=luca@z3ntu.xyz \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).