From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: [PATCH 3/3] power: gpio-charger: do not use gpio value directly Date: Wed, 12 Mar 2014 14:48:56 +0100 Message-ID: <2723546.irh9ZUoKUN@phil> References: <12569216.pGctOhkhxz@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <12569216.pGctOhkhxz@phil> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Eremin-Solenikov Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , David Woodhouse , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org From: Heiko Stuebner Some gpio implementations return interesting values for gpio_get_value when the value is not 0 - as seen on a imx6sl board. Therefore do not use the value returned from gpio_get_value directly but simply check for 0 or not 0. Signed-off-by: Heiko Stuebner --- drivers/power/gpio-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c index 64d31a8..e665993 100644 --- a/drivers/power/gpio-charger.c +++ b/drivers/power/gpio-charger.c @@ -57,7 +57,7 @@ static int gpio_charger_get_property(struct power_supply *psy, switch (psp) { case POWER_SUPPLY_PROP_ONLINE: - val->intval = gpio_get_value_cansleep(pdata->gpio); + val->intval = gpio_get_value_cansleep(pdata->gpio) ? 1 : 0; val->intval ^= pdata->gpio_active_low; break; default: -- 1.8.5.3