Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Robert Marko <robimarko@gmail.com>,
	Guru Das Srinagesh <linux@gurudas.dev>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: firmware: qcom,scm: Add minidump SRAM property
Date: Fri, 8 May 2026 12:42:53 +0200	[thread overview]
Message-ID: <27247bee-0c82-412c-995a-fcc0c717abcb@oss.qualcomm.com> (raw)
In-Reply-To: <20260507080727.3227367-2-mukesh.ojha@oss.qualcomm.com>

On 5/7/26 10:07 AM, Mukesh Ojha wrote:
> On most Qualcomm SoCs where minidump is supported, a word in always-on
> SRAM is shared between the kernel and boot firmware. Before DDR is
> initialised on the warm reset following a crash, firmware reads this
> word to decide if minidump is enabled and collect a minidump and where
>  to deliver it (USB upload to a host, or save to local storage).
> 
> Add 'sram' and 'sram-names' properties to the SCM binding to describe
> a region in always-on SRAM where the minidump download destination
> value could be written. Boot firmware reads it before DDR is initialised
> on a warm reset to decide where to store the minidump either to host
> PC or to on device storage.
> 
> Most of the Qualcomm SoC supporting minidump supports this, added the
> kaanapali SoC for now.
> 
> Suggested-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Thank you for the attribution, but I don't think it applies here - 
Suggested-by would be fitting if I said "hey Mukesh, could you please
do XYZ ABC [which you weren't planning on doing]", this is more of a
normal review feedback

Konrad

  parent reply	other threads:[~2026-05-08 10:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-07  8:07 [PATCH 0/4] firmware: qcom: scm: Add minidump SRAM destination support Mukesh Ojha
2026-05-07  8:07 ` [PATCH 1/4] dt-bindings: firmware: qcom,scm: Add minidump SRAM property Mukesh Ojha
2026-05-07  9:40   ` Rob Herring (Arm)
2026-05-08 10:42   ` Konrad Dybcio [this message]
2026-05-08 10:50   ` Konrad Dybcio
2026-05-08 12:09     ` Rob Herring
2026-05-08 12:07   ` Rob Herring
2026-05-07  8:07 ` [PATCH 2/4] firmware: qcom: scm: use dev_err_probe() for dload address failure Mukesh Ojha
2026-05-07 13:47   ` Dmitry Baryshkov
2026-05-07 14:01   ` Bjorn Andersson
2026-05-08 10:51   ` Konrad Dybcio
2026-05-07  8:07 ` [PATCH 3/4] firmware: qcom: scm: Add minidump SRAM support Mukesh Ojha
2026-05-07 13:50   ` Dmitry Baryshkov
2026-05-07 15:02     ` Mukesh Ojha
2026-05-08 10:40     ` Konrad Dybcio
2026-05-07  8:07 ` [PATCH 4/4] arm64: dts: qcom: kaanapali: Add minidump SRAM config to SCM node Mukesh Ojha
2026-05-07 10:18 ` [PATCH 0/4] firmware: qcom: scm: Add minidump SRAM destination support Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27247bee-0c82-412c-995a-fcc0c717abcb@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@gurudas.dev \
    --cc=mukesh.ojha@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=robimarko@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox