From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3251662E7 for ; Sun, 16 Nov 2025 14:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763301928; cv=none; b=SewclQ2jmcfkDm48+jgYNwjo81cTko+Z5fXHHFsPspYRkexolrC22ktGAm1Mb2GD9QTx0HkQawc9wDcymq9TU1XlKUiazA7K64wzxKf0PNVZQ57WYgwlY7LyWVFKZan4E/W6+oKW9qIAKg/Pt1ZyeoGy9y3Xvv12PUhZC4gCKdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763301928; c=relaxed/simple; bh=33PsQ/AUwCz47Q2ktn9ehaEhowKUCamtoyxGLZNVHbg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tXK8BeAGsyAMp0ZW/IoCqJsrP4ep65tpjevssCW5wHNLf2mu7jtJFv6BdEx5qoiUG0PeGQe5paUPi35+WcHYFv8xheLylBmiRhrT6Be56FPbqd+JrViXeCFSMGe3gC8yUMEu/E9ZzV1exkNoCv/p4UZxI/mRSZfLlikFUqipTRs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K5Xx6azY; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K5Xx6azY" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47755de027eso24886015e9.0 for ; Sun, 16 Nov 2025 06:05:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763301924; x=1763906724; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=esnGEzkzX0sNjqmrcTq8CE3mLuOzfAPZ58BKs3L8zSY=; b=K5Xx6azY6CiiLH3TyMOB1jAjRN8zh9DpVd9pRVJbgGdq0n0k98XNHIU4IwjezrQINz 0zGsad18mM8WjiLWKEUnF1XAobDBZC1S8BpxyG6y+p97BlPiWkZpq2u6dB16RUYtwW10 Yvb3/hOzuqjgjUjeIkhYhPlo9ZuDSTKN9n+16rAwkfhygMP+zENg/T4cg+NngPY46qxu PpteisL6ZIAR/coCqBXKbsaO+xXf27PEwBQ6WxLmdHSN4EJrS2RZRsPvN9bhid2kLDBU uj2Noa3ICf6Rx6+IgBIV0N2gTGUOrWLcp7Cmo/Nuw9Oegck0jorx2ELC78Uq1QAKZPjr mSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763301924; x=1763906724; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=esnGEzkzX0sNjqmrcTq8CE3mLuOzfAPZ58BKs3L8zSY=; b=Geqsmfn0c28793o6pASSRMamRZYooGalcLI/tmV+dKoMg4bOzWApn/VE3lumCeZbWl bF++a8fZSaSBqrREW//4vagtwvt2mGJijfbtJDZCpUv9Jk4m7g+jYpruvoj6Yz0nmIIw ua1Zq6sOZBJ00fkq3D9fLDxGoHSL6+iw7bOOVBBaMNuO6FUclk9xUIGMik+2BaOfmSFv cyKd00SsdOhwjZUrT5JVM3XUOAASxK8f8QjNavwuv5L5iP10TeUKjukxuYZf0TrUR1Bc IrxbdXnAoLBhsd0QlngEvrRCy8vS57+g/QlgolS41CvQJpV6juqjpPL48QAYa+TJ6Bvc 1NYw== X-Forwarded-Encrypted: i=1; AJvYcCUnVe8rsF9dnQTtbSEig/BTMWGiILdXAyMiDCWSrw6Vto8dZWkxlptLtnqpDa01vfN1p5ASALiVnui0@vger.kernel.org X-Gm-Message-State: AOJu0YyKXzDZb/HvZWErrymL4R9mdhE6iXgNhXqnLm4aCWoMZ3/nlwr7 tYqWBwiNNPS1TPOyGDIe/sYXBGOEkb2WEu/iKxGARzc94UXD2tzRdYwxIbUTfcdoHUU= X-Gm-Gg: ASbGnctT+utPx1up/QM78rAYCuKKTApWKssDO67hwGgs4kyOQWko50Uss2QsnIeLkBo 7KH31XeuwX2wISqAah9cvurAResW33QSXRB/0F9nSTp6IYu1pIpq5GK4eXWoJ/JdvL9HXtfUjri gMB8Fx1QW1GrdlF8p3yUndGtgkPT9GN/+pOApFoaFHWVEjMq/HnUVBkQlbrEzBtEu9qIWV8WjGX TlEA/UoTSnFuEaP+FloM33+UMXFI/aL+vUx8hL4y0kXIVUhZTUkkWdEXFJuPQ1Axl1U+MjczRCh 43HFDiC3iQ6LT/aWLxk7NUScfRWtGeZVk7fMdAFY0Cui59BKpTUuFgioxDJMUgOYm4RDbvxL5Oy kUeA06oY0F9dlW8rVy8eBiRhb0K8xBZNJ5yflcJP/kpNXnSOpb1wY5Lj8TBpVRT6nS4OIzEipDA FhZvA4EcTppa+g8P0losb92d1esCTiszxAWNXJY9LqixYlsGpqV9nkURE0jiCIJwzwnmZ+vANeD Q== X-Google-Smtp-Source: AGHT+IE3mxx6tPSCmtFXKoJKqSi4TG4BM2tsrg1pYC1GBPuLQl9xVgLREUBWwVTx+ulT9jDCuzJmog== X-Received: by 2002:a05:600c:1c16:b0:476:4efc:8ed4 with SMTP id 5b1f17b1804b1-4778fe49c3bmr92644605e9.11.1763301923841; Sun, 16 Nov 2025 06:05:23 -0800 (PST) Received: from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47787e8e6acsm265181565e9.9.2025.11.16.06.05.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 16 Nov 2025 06:05:23 -0800 (PST) Message-ID: <272d039c-25a0-4db5-96a3-c28907882cd2@linaro.org> Date: Sun, 16 Nov 2025 14:05:20 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: media: camss: Add qcom,sm6350-camss To: Vladimir Zapolskiy , Bryan O'Donoghue , Luca Weiss , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251114-sm6350-camss-v2-0-d1ff67da33b6@fairphone.com> <20251114-sm6350-camss-v2-1-d1ff67da33b6@fairphone.com> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/11/2025 17:06, Vladimir Zapolskiy wrote: > On 11/14/25 18:09, Bryan O'Donoghue wrote: >> On 14/11/2025 13:06, Luca Weiss wrote: >>> Hi Vladimir, >>> >>> On Fri Nov 14, 2025 at 1:40 PM CET, Vladimir Zapolskiy wrote: >>>> Hi Luca. >>>> >>>> On 11/14/25 13:15, Luca Weiss wrote: >>>>> Add bindings for the Camera Subsystem on the SM6350 SoC. >>>>> >>>>> Signed-off-by: Luca Weiss >>>>> --- >>>>>     .../bindings/media/qcom,sm6350-camss.yaml          | 349 ++++++ >>>>> +++++++++++++++ >>>>>     1 file changed, 349 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm6350- >>>>> camss.yaml b/Documentation/devicetree/bindings/media/qcom,sm6350- >>>>> camss.yaml >>>>> new file mode 100644 >>>>> index 000000000000..d812b5b50c05 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm6350-camss.yaml >>>>> @@ -0,0 +1,349 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/media/qcom,sm6350-camss.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Qualcomm SM6350 Camera Subsystem (CAMSS) >>>>> + >>>>> +maintainers: >>>>> +  - Luca Weiss >>>>> + >>>>> +description: >>>>> +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm >>>>> platforms. >>>>> + >>>>> +properties: >>>>> +  compatible: >>>>> +    const: qcom,sm6350-camss >>>>> + >>>>> +  reg: >>>>> +    maxItems: 12 >>>>> + >>>>> +  reg-names: >>>>> +    items: >>>>> +      - const: csid0 >>>>> +      - const: csid1 >>>>> +      - const: csid2 >>>>> +      - const: csid_lite >>>>> +      - const: csiphy0 >>>>> +      - const: csiphy1 >>>>> +      - const: csiphy2 >>>>> +      - const: csiphy3 >>>>> +      - const: vfe0 >>>>> +      - const: vfe1 >>>>> +      - const: vfe2 >>>>> +      - const: vfe_lite >>>>> + >>>>> +  clocks: >>>>> +    maxItems: 30 >>>>> + >>>>> +  clock-names: >>>>> +    items: >>>>> +      - const: cam_ahb_clk >>>>> +      - const: cam_axi >>>>> +      - const: soc_ahb >>>>> +      - const: camnoc_axi >>>>> +      - const: core_ahb >>>>> +      - const: cpas_ahb >>>>> +      - const: csiphy0 >>>>> +      - const: csiphy0_timer >>>>> +      - const: csiphy1 >>>>> +      - const: csiphy1_timer >>>>> +      - const: csiphy2 >>>>> +      - const: csiphy2_timer >>>>> +      - const: csiphy3 >>>>> +      - const: csiphy3_timer >>>>> +      - const: slow_ahb_src >>>>> +      - const: vfe0_axi >>>>> +      - const: vfe0 >>>>> +      - const: vfe0_cphy_rx >>>>> +      - const: vfe0_csid >>>>> +      - const: vfe1_axi >>>>> +      - const: vfe1 >>>>> +      - const: vfe1_cphy_rx >>>>> +      - const: vfe1_csid >>>>> +      - const: vfe2_axi >>>>> +      - const: vfe2 >>>>> +      - const: vfe2_cphy_rx >>>>> +      - const: vfe2_csid >>>>> +      - const: vfe_lite >>>>> +      - const: vfe_lite_cphy_rx >>>>> +      - const: vfe_lite_csid >>>> >>>> The sorting order of this list does not follow the sorting order >>>> accepted >>>> in the past. >>> >>> What file should I best reference? >> >> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml >> >>>> >>>> I'm very sorry for the vagueness, but I can not pronounce the accepted >>>> sorting order name, because it triggers people. >>>> >>>>> + >>>>> +  interrupts: >>>>> +    maxItems: 12 >>>>> + >>>>> +  interrupt-names: >>>>> +    items: >>>>> +      - const: csid0 >>>>> +      - const: csid1 >>>>> +      - const: csid2 >>>>> +      - const: csid_lite >>>>> +      - const: csiphy0 >>>>> +      - const: csiphy1 >>>>> +      - const: csiphy2 >>>>> +      - const: csiphy3 >>>>> +      - const: vfe0 >>>>> +      - const: vfe1 >>>>> +      - const: vfe2 >>>>> +      - const: vfe_lite >>>>> + >>>>> +  interconnects: >>>>> +    maxItems: 4 >>>>> + >>>>> +  interconnect-names: >>>>> +    items: >>>>> +      - const: ahb >>>>> +      - const: hf_mnoc >>>>> +      - const: sf_mnoc >>>>> +      - const: sf_icp_mnoc >>>> >>>> Please remove sf_mnoc and sf_icp_mnoc, they are not needed for enabling >>>> IP to produce raw images, and one day you may use them somewhere else. >>> >>> Ack, will give it a try. >> >> Disagree with this. >> >> See the Kanaapali patches. I'm asking new submissions to be as complete >> as possible, instead of limiting the hardware description to the RDI. >> >> So listing the ICP noc is the right thing to do. >> >> So please include register banks for >> >> - bps >> - cdm >> - icp >> - ipe >> - jpeg >> - lrme > > This suggests to get a DT backward compatibility lock forever, I'm not entirely sure what this comment means. The objective here is to get a full and complete DT describing camera hardware that can be consumed by - CAMSS RDI - CAMSS RDI + future goodness - FreeBSD - Any other DT consumer of upstream data perhaps even CamX which > makes it > a very bad advice, which is favourable for just the single interested > party, > which offers an alternative to the upstream CAMSS. > > Anybody who wants to get support of any CAMSS ISP functionality above RAW > images shall not add anything unrelated and unsupported. > > The asked inclusion shall be done later on safely, if ever needed. As I say the objective is to fully describe the hardware in DT, not to describe only the RDI path. >>>> I believe this clock is critical, and it is set so in the SM6350 GCC >>>> driver, >>>> therefore it should not be added here. >>> >>> True, gcc_camera_ahb_clk has CLK_IS_CRITICAL in gcc-sm6350.c >> >> DT describes hardware, not the happenstance of Linux driver setup. >> >> On that basis omitting <&gcc GCC_CAMERA_AHB_CLK> from the clock list is >> not correct. > > This has been already discussed, an enumerous amount of Qualcomm/MSM > specific resourced like clocks enabled in ABL, Linux etc. are considered > critical and not described in the dtb. I still think the argument for that is tenuous wrong in fact but, I know you are right, this is a lost argument. @Luca please _do_ include the full array of registers/clocks/nocs as you find them and yeah drop the AXI clock from that description because reasons. https://lore.kernel.org/linux-arm-msm/20251113-add-support-for-camss-on-kaanapali-v6-1-1e6038785a8e@oss.qualcomm.com/ --- bod