From: "Heiko Stübner" <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Kaison Deng <dkx@t-chip.com.cn>
Cc: Wayne Chou <zxf@t-chip.com.cn>,
Quentin Schulz <quentin.schulz@cherry.de>,
Dragan Simic <dsimic@manjaro.org>,
Jonas Karlman <jonas@kwiboo.se>, FUKAUMI Naoki <naoki@radxa.com>,
Peter Robinson <pbrobinson@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Kaison Deng <dkx@t-chip.com.cn>
Subject: Re: [PATCH] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT
Date: Fri, 05 Sep 2025 11:19:25 +0200 [thread overview]
Message-ID: <2744084.BddDVKsqQX@diego> (raw)
In-Reply-To: <20250905090115.718622-1-dkx@t-chip.com.cn>
Hi,
Am Freitag, 5. September 2025, 11:01:15 Mitteleuropäische Sommerzeit schrieb Kaison Deng:
> The Firefly ROC-RK3588-RT is RK3588 based SBC featuring:
On the webpage it is unclear about the soc, both rk3588 and rk3588s are
mentioned?
https://en.t-firefly.com/product/industry/rocrk3588rt
>
> - TF card slot
> - NVME 2242 socket
> - 1x USB 3.0 Port, 1x USB 2.0 Port, 1x Typec Port
> - 1x HDMI 2.1 out, 1x HDMI 2.0 out
> - 2x Gigabit Ethernet, 1x 2.5G Ethernet
> - M.2 E-KEY for Extended WiFI and Bluetoolh
> - ES8388 on-board sound codec - jack in/out
> - RTC
> - LED: WORK, DIY
> - BTB connector for PCie, UART, USB, CAN, SARADC, GPIO
>
> Signed-off-by: Kaison Deng <dkx@t-chip.com.cn>
you definitly need a 2nd patch adding an entry to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/arm/rockchip.yaml
The rest looked pretty good on a short glance :-)
Heiko
next prev parent reply other threads:[~2025-09-05 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 9:01 [PATCH] arm64: dts: rockchip: Add devicetree for the ROC-RK3588-RT Kaison Deng
2025-09-05 9:19 ` Heiko Stübner [this message]
2025-09-08 2:42 ` Kaison Deng
2025-09-05 17:45 ` Rob Herring (Arm)
2025-09-06 1:50 ` Jimmy Hon
2025-09-08 3:16 ` Kaison Deng
2025-09-08 16:36 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2744084.BddDVKsqQX@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkx@t-chip.com.cn \
--cc=dsimic@manjaro.org \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=zxf@t-chip.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox