From: Florian Fainelli <f.fainelli@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Sugaya Taichi <sugaya.taichi@socionext.com>,
Olof Johansson <olof@lixom.net>, Andrew Jeffery <andrew@aj.id.au>,
Lubomir Rintel <lkundrak@v3.sk>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>
Subject: Re: [PATCH 11/12] dt-bindings: arm: Document Broadcom SoCs 'secondary-boot-reg'
Date: Mon, 3 Feb 2020 21:29:30 -0800 [thread overview]
Message-ID: <2744136e-a6e7-de19-4142-04f7edf0c6ea@gmail.com> (raw)
In-Reply-To: <20200203083403.6wmuduxqsv7quujp@gilmour.lan>
On 2/3/2020 12:34 AM, Maxime Ripard wrote:
> On Sun, Feb 02, 2020 at 01:18:26PM -0800, Florian Fainelli wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml
>> index c23c24ff7575..6f56a623c1cd 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml
>> @@ -272,6 +272,22 @@ properties:
>> While optional, it is the preferred way to get access to
>> the cpu-core power-domains.
>>
>> + secondary-boot-reg:
>> + $ref: '/schemas/types.yaml#/definitions/uint32'
>> + description: |
>> + Required for systems that have an "enable-method" property value of
>> + "brcm,bcm11351-cpu-method", "brcm,bcm23550" or "brcm,bcm-nsp-smp".
>> +
>> + This includes the following SoCs: |
>> + BCM11130, BCM11140, BCM11351, BCM28145, BCM28155, BCM21664, BCM23550
>> + BCM58522, BCM58525, BCM58535, BCM58622, BCM58623, BCM58625, BCM88312
>> +
>> + The secondary-boot-reg property is a u32 value that specifies the
>> + physical address of the register used to request the ROM holding pen
>> + code release a secondary CPU. The value written to the register is
>> + formed by encoding the target CPU id into the low bits of the
>> + physical start address it should jump to.
>> +
>
> You can make the requirement explicit (and enforced by the schemas) using:
>
> if:
> properties:
> enable-method:
> contains:
> enum:
> - brcm,bcm11351-cpu-method
> - brcm,bcm23550
> - brcm,bcm-nsp-smp
>
> then:
> required:
> - secondary-boot-reg
Thanks! That was exactly what I was looking for, it seems to be matching
a bit too greedily though:
DTC arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
CHECK arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml
/home/ff944844/dev/linux/arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml:
cpu@0: 'secondary-boot-reg' is a required property
/home/ff944844/dev/linux/arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml:
cpu@1: 'secondary-boot-reg' is a required property
/home/ff944844/dev/linux/arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml:
cpu@2: 'secondary-boot-reg' is a required property
/home/ff944844/dev/linux/arch/arm/boot/dts/bcm2836-rpi-2-b.dt.yaml:
cpu@3: 'secondary-boot-reg' is a required property
DTC arch/arm/boot/dts/bcm2837-rpi-3-a-plus.dt.yaml
not sure why though as your example appears correct.
--
Florian
next prev parent reply other threads:[~2020-02-04 5:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 21:18 [PATCH 00/12] dt-bindings: arm: bcm: Convert boards to YAML Florian Fainelli
2020-02-02 21:18 ` [PATCH 01/12] dt-bindings: arm: bcm: Convert Cygnus " Florian Fainelli
2020-02-03 8:29 ` Maxime Ripard
2020-02-02 21:18 ` [PATCH 02/12] dt-bindings: arm: bcm: Convert Hurricane 2 " Florian Fainelli
2020-02-02 21:18 ` [PATCH 03/12] dt-bindings: arm: bcm: Convert Northstar Plus " Florian Fainelli
2020-02-02 21:18 ` [PATCH 04/12] dt-bindings: arm: bcm: Convert Northstar 2 " Florian Fainelli
2020-02-02 21:18 ` [PATCH 05/12] dt-bindings: arm: bcm: Convert Stingray " Florian Fainelli
2020-02-02 21:18 ` [PATCH 06/12] dt-bindings: arm: bcm: Convert BCM21664 " Florian Fainelli
2020-02-03 8:30 ` Maxime Ripard
2020-02-02 21:18 ` [PATCH 07/12] dt-bindings: arm: bcm: Convert BCM23550 " Florian Fainelli
2020-02-02 21:18 ` [PATCH 08/12] dt-bindings: arm: bcm: Convert BCM4708 " Florian Fainelli
2020-02-03 8:31 ` Maxime Ripard
2020-02-02 21:18 ` [PATCH 09/12] dt-bindings: arm: bcm: Convert BCM11351 " Florian Fainelli
2020-02-02 21:18 ` [PATCH 10/12] dt-bindings: arm: bcm: Convert Vulcan " Florian Fainelli
2020-02-02 21:30 ` Rob Herring
2020-02-02 21:18 ` [PATCH 11/12] dt-bindings: arm: Document Broadcom SoCs 'secondary-boot-reg' Florian Fainelli
2020-02-03 8:34 ` Maxime Ripard
2020-02-04 5:29 ` Florian Fainelli [this message]
2020-02-04 9:19 ` Maxime Ripard
2020-02-02 21:18 ` [PATCH 12/12] dt-bindings: arm: bcm: Convert BCM2835 firmware binding to YAML Florian Fainelli
2020-02-03 10:14 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2744136e-a6e7-de19-4142-04f7edf0c6ea@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@aj.id.au \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
--cc=maxime@cerno.tech \
--cc=nsaenzjulienne@suse.de \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=sugaya.taichi@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).