From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E5913F58C9 for ; Tue, 4 Aug 2026 05:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785823018; cv=none; b=ljyqctBtwa/LvhqKoSBuaX0aqJ/XrasVIz4tV5UfK6RnDNtk9+nWU7m2KBa1MtQfHzCpTT9kVNFctLJSajkG02g/RqftexFmN64WkKd6d2UAvbTj29uW3ezWkEoQbKCLrHd8dxGDl4orIYbwIcnlfMb9Q5JK+i5Vb1OfL4WGFXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785823018; c=relaxed/simple; bh=258eEU9ggVkuDaLgqMtjjawoLrp5quPNHESnFmj8quQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=o+ZP4WWDjbsTGHo4tgQIkFVNu35KisYq8gIkyQPVYsuip8efQz80mcl4Ae3QjXuKKz1x3HCvIGa7tkRSTErxMr9Gj/fe/nOjvH2F1eA9RdHcifZX7znb+TxmWEQPkOuQgxZ5PQtBDDxzzrfI3IPftfKI8LlZ3/R6uVyyAvpMMRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nZSNcG/h; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d0zWsN1d; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nZSNcG/h"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d0zWsN1d" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67416rT52028007 for ; Tue, 4 Aug 2026 05:56:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CnkLpGEMBHT8USstxtuf9MhLdUsmmHDnwcAbAYMQAak=; b=nZSNcG/hn5T5GmvR GM3WJ4xNuTtJerPkOckmnVf5sdVy5gfNlSEppu4EDVrptKj4XaW9Xr06UXNV5hmX BHmNMVDRYtLaSOfIUq0H5/qfG+aIyTtjtUcyqrsn/+7njbg6l5T0Ie69lpaYmMbC cWQ+qzC8UNPyNSbPYYGV5RV68e8IQ/TeABCK/Rl5v7Sdr8E9SYmWx9n6SSjp4wxI gXTQZBsw9mTtorC4tHGhIyUpgvfj8omani7HOUVb7yocJCG7oALFSFbKA7CqONL3 cX7TmsxQ9yisJNBuUecj7c0/juELoZcdafDHHnzEQ1KAqTJcBGE4nJgAS/Jdrvuq d5toqg== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fu2syhnbj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 05:56:55 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-52769fc3f2eso46784291cf.0 for ; Mon, 03 Aug 2026 22:56:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785823014; x=1786427814; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CnkLpGEMBHT8USstxtuf9MhLdUsmmHDnwcAbAYMQAak=; b=d0zWsN1dt0q03ygG8LQPtPxsYYMCw3pxsvCSSfmekn2j+Gk6NQzewmV4DfFdFuv7gd 1DUsE8u9/sEPvOvcmb+mJWYhIseiQJqcXTHmM29NHDiIv1rAYV7jafLnnP97EP6NP94G rG+YwdllW7A54/Gx2V9QNG7pK0J4WGqHTKC5hGOT+Uj+mts8CRrGtKOhO9ZAgvFY5voT PfR0KyH2CMumpHIA2UkuvtY6gIf48jtg8VahS/CBYOinXbjywAI69zWfKqXJ+qfvn4O5 Wn4EDVqsiUF/do6GmogG6n623lBfTxn81lF06IrIdWFUdrqTObM6gL+59INWsaoxF4+B w1Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785823014; x=1786427814; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CnkLpGEMBHT8USstxtuf9MhLdUsmmHDnwcAbAYMQAak=; b=nwX0ld1oD3Bj/vlbX6foZiAYYJqQHFGNy+UfJCqQodbNE1jO5K2jNlRGM/jJeRokoj WevWAnQ/Q/WofIiO7AcYSbMkY/eQeM4nLzppa6rI93njK6n9gsykUCF+f0FOdzr4aTMr w873lv1+cqHQ9Cq/qubuy890dStivEgYefnNcajL7R2e5Fy8GcshcFj2zLzKz0uQsq4/ sd2IMjuuhLPhSxKvN3HAzyDSqsAxcsFmMpUGT9BywGVroaOGRU4W9xwvnDQ3qHFd27se cePuS0MUwmVwflzw5kRhG2/ARPmOc46BIdwKocTawzvtyJlR1kkdPODdy7HW+xFKHZAi 8kPw== X-Forwarded-Encrypted: i=1; AHgh+RoL6QElorudf4aE8UIfvz9KljeKKkc82Vcs2i/thoN283/zWQvoVU42cV6NbKWT/oh1FHh0YYdhcK2M@vger.kernel.org X-Gm-Message-State: AOJu0Yz9nPcIgOoLElEuT5v+m+DR8304SMVrQq4uNWwDqatNxEpTYhWn jvhv9iXWMvhGa5EfUAfvrZ+l2HaObTDjZhh4MSJalLHknTQR80pi+734tqn2GzIcCdM2K2UDVWx XoZVFHliFe92mEVz3UA5sK8804c89BBKrfpCe3wCko/KOe6zcmn44Q0ptUBmNw7n/ X-Gm-Gg: AR+sD11SorJ35O1ybZjK2HzXUMOVTjsPGobBYIhVycc5DSicUh8QwDOYFnLZatEgYs+ sY6WUNhh/8GNrh7nKP4MGFyG/4VaO/9F9oh0JI5ng9D5JzS4hREhVHzLDS0BCsoT9yu2PxSHguq p02JnYNwKbBXj39n8uPxDtx/Ij5zLO+lb5zyk26M9kUFL2WRbA/Ms/6h5P7tPLvWnQ0MXjRXo6Q lk8M7wqjLy/QOmLjjcY1UV26B6nlncznRvU3PpFNdaFC6VD/3BomywOD86048zh1puPqgU+cylk 4Iv35RlJ9/F4SlZI5eMM/MogvuYMCWssbVPRwZQw5UlkITnnyfJcVpaQ1/LAEY/Gc3c84iyWuzz PUEG5qKI/J9ArTE8Sig5EhHqwZDeS5W6/JVBt7YWkWUEfPxyLcn8k+YAdnEjwtvSjueVgakFE X-Received: by 2002:a05:622a:5145:b0:527:43a:2f31 with SMTP id d75a77b69052e-52b566afa58mr262163301cf.15.1785823014154; Mon, 03 Aug 2026 22:56:54 -0700 (PDT) X-Received: by 2002:a05:622a:5145:b0:527:43a:2f31 with SMTP id d75a77b69052e-52b566afa58mr262163121cf.15.1785823013571; Mon, 03 Aug 2026 22:56:53 -0700 (PDT) Received: from [192.168.1.31] ([85.196.172.179]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c5b1a66sm6954381a12.10.2026.08.03.22.56.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 22:56:52 -0700 (PDT) Message-ID: <275a6cee-08d1-477b-8803-e57992d49052@oss.qualcomm.com> Date: Tue, 4 Aug 2026 08:56:49 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/3] dt-bindings: media: qcom: Add JPEG encoder binding To: Dmitry Baryshkov Cc: Atanas Filipov , linux-media@vger.kernel.org, bod@kernel.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, loic.poulain@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260730150524.2659577-1-atanas.filipov@oss.qualcomm.com> <20260730150524.2659577-2-atanas.filipov@oss.qualcomm.com> <3cbnmjmit4gsldga5nzct4odg6hpixzlwxbj72elnogyevr2tg@6esyjj2mvyom> Content-Language: en-US From: "Gjorgji Rosikopulos (Consultant)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=TIh1jVla c=1 sm=1 tr=0 ts=6a717f27 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=Q/e3f29T3Hw2hnAEzBPF7w==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=gEfo2CItAAAA:8 a=D19gQVrFAAAA:8 a=EUspDBNiAAAA:8 a=XqDJFxXNpytrKbGnDnMA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=sptkURWiP4Gy88Gu7hUp:22 a=W4TVW4IDbPiebHqcZpNg:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDA0NSBTYWx0ZWRfXyPRh7KoMTEoz syXFKqXh/tE9pRJLsHYRgaWSdqE4z49ile71idU+wW57sgFERciMPkBseytnpZ82OP6yXIL9TbB DJY+Bd6Gu3MZtO/ZK/d5n1G2eQ3NK8s= X-Proofpoint-ORIG-GUID: PKvg-zqIb8xQ0JR01YZT-Ex95wbeIeXj X-Proofpoint-GUID: PKvg-zqIb8xQ0JR01YZT-Ex95wbeIeXj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDA0NSBTYWx0ZWRfXzVpbH4mGQH1C 9VgDyJ5guhjDudSBiOVDS+0ZGSNRQwezbJym/WX6pBAkeqIQyq9q3sfAM9I5xx9bgTZV3HtyXi4 kRfTmJG7N8/RBj7zVlBt1s3RjjAFIb939m7uI2WvnVg74E2Fu59980xt9/yV3s+WI/ABMB9d6ET B1h+sN1UiPRGLbu2JEWyfZCRNKaxBQj8Kmk8zRSmjRIy6FfE1TzfuARUB2XmOa7Hqc++V+GWXEc RrS9tJYORf0p4kll0hUD82p3cLr1dS2z8sL68Ezpbsg68r/LIdQTy2ni5+Fj7Mqxf90JUw4/Wsj LDIL8+mZ+sSsMZqwecn6kpw08IMGvouF2OJ7+vi6+6i67G9F0srJgvX5SdfbjkwomU2BBrWosJm QPFzqHc1J8g6e1+N1kUxDwGeq/elfMSETXzVq/ap1FRuOm+80Qdlc2Rk4gcKurd4oY+dcwlfu/I 851HBlSoHVW+pJFLISg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_01,2026-08-03_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040045 Hi Dmitry, On 8/3/2026 9:16 PM, Dmitry Baryshkov wrote: > On Fri, Jul 31, 2026 at 10:26:39PM +0300, Gjorgji Rosikopulos (Consultant) wrote: >> Hi Dmitry, Atanas, >> >> On 7/30/2026 7:24 PM, Atanas Filipov wrote: >>> On 7/30/2026 6:39 PM, Dmitry Baryshkov wrote: >>>> On Thu, Jul 30, 2026 at 06:05:22PM +0300, Atanas Filipov wrote: >>>>> Add device-tree binding for the Qualcomm JPEG encoder hardware block >>>>> present in SM8250 (Kona) SoCs. >>>>> >>>>> The JPEG encoder is a standalone hardware IP within the camera subsystem >>>>> that performs JPEG compression in memory-to-memory fashion. It is >>>>> separate from the CAMSS ISP pipeline and has its own register space, >>>>> interrupt, clocks, power domain, IOMMU streams, and interconnect paths. >>>>> >>>>> Signed-off-by: Atanas Filipov >>>>> --- >>>>> .../bindings/media/qcom,sm8250-jpeg-enc.yaml | 156 ++++++++++++++++++ >>>>> 1 file changed, 156 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-jpeg-enc.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-jpeg-enc.yaml b/Documentation/devicetree/bindings/media/qcom,sm8250-jpeg-enc.yaml >>>>> new file mode 100644 >>>>> index 000000000000..70f573100573 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-jpeg-enc.yaml >>>>> @@ -0,0 +1,156 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/media/qcom,sm8250-jpeg-enc.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Qualcomm JPEG Encoder >>>>> + >>>>> +maintainers: >>>>> + - Atanas Filipov >>>>> + >>>>> +description: >>>>> + Qualcomm JPEG Encoder is the JPEG encode hardware present in Qualcomm SoCs. >>>>> + The encoder is a standalone hardware IP within the camera subsystem that >>>>> + performs JPEG compression in memory-to-memory fashion. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - qcom,sm8250-jpeg-enc >>>>> + >>>>> + reg: >>>>> + maxItems: 1 >>>>> + >>>>> + interrupts: >>>>> + maxItems: 1 >>>>> + >>>>> + clocks: >>>>> + maxItems: 5 >>>>> + >>>>> + clock-names: >>>>> + items: >>>>> + - const: sf_axi >>>>> + - const: core_ahb >>>>> + - const: cpas_ahb >>>>> + - const: cnoc_axi >>>>> + - const: jpeg >>>>> + >>>>> + power-domains: >>>>> + maxItems: 3 >>>>> + >>>>> + power-domain-names: >>>>> + items: >>>>> + - const: titan_top >>>>> + - const: mmcx >>>>> + - const: mx >>>>> + >>>>> + interconnects: >>>>> + maxItems: 2 >>>>> + >>>>> + interconnect-names: >>>>> + items: >>>>> + - const: cpu-cfg >>>>> + - const: sf-mnoc >>>>> + >>>>> + iommus: >>>>> + description: >>>>> + SMMU stream ID for the JPEG hardware. The stream ID 0x2040 is used >>>>> + for the JPEG core engine on SM8250. >>>>> + maxItems: 1 >>>>> + >>>>> + operating-points-v2: true >>>>> + >>>>> + opp-table: >>>>> + type: object >>>>> + >>>>> +required: >>>>> + - compatible >>>>> + - reg >>>>> + - clocks >>>>> + - clock-names >>>>> + - interrupts >>>>> + - power-domains >>>>> + - power-domain-names >>>>> + - interconnects >>>>> + - interconnect-names >>>>> + - iommus >>>>> + >>>>> +additionalProperties: false >>>>> + >>>>> +examples: >>>>> + - | >>>>> + #include >>>>> + #include >>>>> + #include >>>>> + #include >>>>> + #include >>>>> + #include >>>>> + >>>>> + jpeg-encoder@ac53000 { >>>>> + compatible = "qcom,sm8250-jpeg-enc"; >>>>> + reg = <0x0ac53000 0x1000>; >>>>> + >>>>> + interrupts = ; >>>>> + >>>>> + power-domains = <&camcc TITAN_TOP_GDSC>, >>>>> + <&rpmhpd RPMHPD_MMCX>, >>>>> + <&rpmhpd RPMHPD_MX>; >>>>> + power-domain-names = "titan_top", "mmcx", "mx"; >>>>> + >>>>> + clocks = <&gcc GCC_CAMERA_SF_AXI_CLK>, >>>>> + <&camcc CAM_CC_CORE_AHB_CLK>, >>>>> + <&camcc CAM_CC_CPAS_AHB_CLK>, >>>>> + <&camcc CAM_CC_CAMNOC_AXI_CLK>, >>>>> + <&camcc CAM_CC_JPEG_CLK>; >>>>> + clock-names = "sf_axi", >>>>> + "core_ahb", >>>>> + "cpas_ahb", >>>>> + "cnoc_axi", >>>>> + "jpeg"; >>>> >>>> What are the pin input names for these clocks on the JPEG side? Can we >>>> use a better name? >> >> The name of the the clock on jpeg side(based on documentation we have) is >> cam_cc_jpeg_clk, There was comment from Krzysztof "https://lkml.org/lkml/2026/5/15/1112" >> to drop cam and clk, so it remains cc_jpeg or only jpeg. >> >> As i can see in ope patches ope_clk is named as "core", do we have some general >> guidance how to name those clocks? or if you have any preference or proposal it will >> be included in next patchset. > > "core" is better. It defines the purpose. They problem with clamping the > "cam_cc_foo_clk" names is that they change from time to time, while the > IP core doesn't actually change. I undestand, ok then we will use core to have similar approach as OPE driver. > >>>>> + >>>>> + jpeg_opp_table: opp-table { >>>>> + compatible = "operating-points-v2"; >>>>> + >>>>> + opp-100000000 { >>>>> + opp-hz = /bits/ 64 <400000000>, >>>>> + /bits/ 64 <100000000>; >>>> >>>> So, you've identified the issue earlier. The shared clocks need to be >>>> scaled, taking all users in account. Please come up with the solution >>>> too. >> >> One proposal is to have camnoc icc clock provider, there is implementation >> available and it will be posted, What is the preference to have different >> patchset or to have camnoc icc provider as part of this patchset new version? > > It definitely can't come _after_ this patch. We already have CAMSS > voting on those clocks, so adding JPEG shoudn't disrupt its > functionality. Ok, then the camnoc icc + changes in camss will came first then on top the JPEG driver. ~Gjorgji