From: Dan Murphy <dmurphy@ti.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
jacek.anaszewski@gmail.com, pavel@ucw.cz,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings
Date: Wed, 9 May 2018 06:34:43 -0500 [thread overview]
Message-ID: <27624117-6a8b-e94c-7dce-c5cb09d733f6@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1805091023520.3379@hadrien>
All
On 05/09/2018 03:26 AM, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
> CC: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> url:
> https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
> I also received the following comment, but no other details. It would be
> good to check what is going on on the mentioned lines.
>
>>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
>
> leds-lm3601x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/leds/leds-lm3601x.c
> +++ b/drivers/leds/leds-lm3601x.c
> @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
>
> ret = -EINVAL;
> goto out;
> - };
> + }
>
I will fix this in v3 of the patch submission.
Dan
> if (led->strobe_timeout != current_timeout)
> ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
>
--
------------------
Dan Murphy
prev parent reply other threads:[~2018-05-09 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:26 [PATCH] leds: lm3601x: fix semicolon.cocci warnings Julia Lawall
2018-05-09 11:34 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27624117-6a8b-e94c-7dce-c5cb09d733f6@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox