devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Vivek Yadav <vivek.2311@samsung.com>,
	rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org,
	wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	pankaj.dubey@samsung.com, ravi.patel@samsung.com,
	alim.akhtar@samsung.com, linux-fsd@tesla.com, robh+dt@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	aswani.reddy@samsung.com, sriranjani.p@samsung.com
Subject: Re: [PATCH v2 1/6] dt-bindings: Document the SYSREG specific compatibles found on FSD SoC
Date: Thu, 10 Nov 2022 13:11:42 +0100	[thread overview]
Message-ID: <277004ed-3b6b-4ee5-39e4-beb75a272e60@linaro.org> (raw)
In-Reply-To: <000001d8f4f6$1c7e96e0$557bc4a0$@samsung.com>

On 10/11/2022 12:18, Vivek Yadav wrote:
>>> +maintainers:
>>> +  - Alim Akhtar <alim.akhtar@samsung.com>
>>> +
>>> +description: |
>>> +  This is a system control registers block, providing multiple low
>>> +level
>>> +  platform functions like board detection and identification,
>>> +software
>>> +  interrupt generation.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    oneOf:
>>
>> No need for oneOf.
>>
> Removing this results into dt_binding_check error, so this is required.

No, this is not required. You do not have more than one condition for oneOf.

>>> +      - items:
>>> +          - enum:
>>> +              - tesla,sysreg_fsys0
>>> +              - tesla,sysreg_peric
>>
>> From where did you get underscores in compatibles?
>>
> I have seen in MCAN Driver <drivers/net/can/m_can/m_can_platform.c> and also too many other yaml files.
> Do you have any ref standard guideline of compatible which says underscore is not allowed.

git grep compatible arch/arm64/boot/dts/exynos/ | grep _
git grep compatible arch/arm/boot/dts/exynos* | grep _

Both give 0 results. For few other SoCs there such cases but that's
really, really exception. Drop underscores.


Best regards,
Krzysztof


  reply	other threads:[~2022-11-10 12:11 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20221109100240epcas5p2cdd73ae96d91a5e915f3ac9a42091620@epcas5p2.samsung.com>
2022-11-09 10:09 ` [PATCH v2 0/6] can: mcan: Add MCAN support for FSD SoC Vivek Yadav
     [not found]   ` <CGME20221109100245epcas5p38a01aed025f491d39a09508ebcdcef84@epcas5p3.samsung.com>
2022-11-09 10:09     ` [PATCH v2 1/6] dt-bindings: Document the SYSREG specific compatibles found on " Vivek Yadav
2022-11-09 11:08       ` Krzysztof Kozlowski
2022-11-10 11:18         ` Vivek Yadav
2022-11-10 12:11           ` Krzysztof Kozlowski [this message]
2022-11-11  4:06             ` Vivek Yadav
2022-11-11  7:54               ` Krzysztof Kozlowski
2022-11-16 16:43           ` Rob Herring
     [not found]   ` <CGME20221109100249epcas5p142a0a9f7e822c466f7ca778cd341e6d9@epcas5p1.samsung.com>
2022-11-09 10:09     ` [PATCH v2 2/6] dt-bindings: can: mcan: Add ECC functionality to message ram Vivek Yadav
2022-11-09 11:11       ` Krzysztof Kozlowski
     [not found]   ` <CGME20221109100254epcas5p48c574876756f899875df8ac71464ce11@epcas5p4.samsung.com>
2022-11-09 10:09     ` [PATCH v2 3/6] arm64: dts: fsd: add sysreg device node Vivek Yadav
2022-11-09 11:16       ` Krzysztof Kozlowski
2022-11-09 11:17       ` Sam Protsenko
2022-11-10 12:54         ` Krzysztof Kozlowski
     [not found]   ` <CGME20221109100258epcas5p2966d5e93e00d2a5b4e4a3096dc5a5ec6@epcas5p2.samsung.com>
2022-11-09 10:09     ` [PATCH v2 4/6] arm64: dts: fsd: Add MCAN " Vivek Yadav
2022-11-09 11:18       ` Krzysztof Kozlowski
     [not found]   ` <CGME20221109100302epcas5p276282a3a320649661939dcb893765fbf@epcas5p2.samsung.com>
2022-11-09 10:09     ` [PATCH v2 5/6] can: m_can: Add ECC functionality for message RAM Vivek Yadav
2022-11-09 11:20       ` Krzysztof Kozlowski
     [not found]   ` <CGME20221109100309epcas5p4bc1ddd62048098d681ba8af8d35e2e73@epcas5p4.samsung.com>
2022-11-09 10:09     ` [PATCH v2 6/6] arm64: dts: fsd: Add support for error correction code " Vivek Yadav
2022-11-09 11:21       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=277004ed-3b6b-4ee5-39e4-beb75a272e60@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=aswani.reddy@samsung.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-fsd@tesla.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=ravi.patel@samsung.com \
    --cc=rcsekar@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=sriranjani.p@samsung.com \
    --cc=vivek.2311@samsung.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).