devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie
@ 2024-10-07 10:07 Macpaul Lin
  2024-10-07 14:08 ` Matthias Brugger
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Macpaul Lin @ 2024-10-07 10:07 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, Jieyy Yang, Jian Yang,
	Jianguo Zhang, Alexandre Mergnat
  Cc: Bear Wang, Pablo Sun, Macpaul Lin, Macpaul Lin, Sen Chu,
	Chris-qj chen, MediaTek Chromebook Upstream, Chen-Yu Tsai

Enable PCIE, PCIEPHY and related Pinctrls for mt8390-genio-700-evk
board.

Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
---
 .../dts/mediatek/mt8390-genio-700-evk.dts     | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

Changes for v1:
 - This patch depends on the pcie patch of mt8188.dtsi
   [1] https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/

diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
index 3e77f59f2c74..bb68665f0b2d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
@@ -393,6 +393,16 @@ &mt6359codec {
 	mediatek,mic-type-1 = <3>; /* DCC */
 };
 
+&pcie {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie_pins_default>;
+	status = "okay";
+};
+
+&pciephy {
+	status = "okay";
+};
+
 &pio {
 	audio_default_pins: audio-default-pins {
 		pins-cmd-dat {
@@ -758,6 +768,15 @@ pins-rst {
 		};
 	};
 
+	pcie_pins_default: pcie-default {
+		mux {
+			pinmux = <PINMUX_GPIO47__FUNC_I1_WAKEN>,
+				 <PINMUX_GPIO48__FUNC_O_PERSTN>,
+				 <PINMUX_GPIO49__FUNC_B1_CLKREQN>;
+			bias-pull-up;
+		};
+	};
+
 	rt1715_int_pins: rt1715-int-pins {
 		pins_cmd0_dat {
 			pinmux = <PINMUX_GPIO12__FUNC_B_GPIO12>;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie
  2024-10-07 10:07 [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie Macpaul Lin
@ 2024-10-07 14:08 ` Matthias Brugger
  2024-10-08  8:20 ` AngeloGioacchino Del Regno
  2024-10-14 10:41 ` AngeloGioacchino Del Regno
  2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2024-10-07 14:08 UTC (permalink / raw)
  To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	AngeloGioacchino Del Regno, devicetree, linux-kernel,
	linux-arm-kernel, linux-mediatek, Jieyy Yang, Jian Yang,
	Jianguo Zhang, Alexandre Mergnat
  Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
	MediaTek Chromebook Upstream, Chen-Yu Tsai



On 07/10/2024 12:07, Macpaul Lin wrote:
> Enable PCIE, PCIEPHY and related Pinctrls for mt8390-genio-700-evk
> board.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   .../dts/mediatek/mt8390-genio-700-evk.dts     | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> Changes for v1:
>   - This patch depends on the pcie patch of mt8188.dtsi
>     [1] https://lore.kernel.org/all/20241004081218.55962-3-fshao@chromium.org/
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> index 3e77f59f2c74..bb68665f0b2d 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-700-evk.dts
> @@ -393,6 +393,16 @@ &mt6359codec {
>   	mediatek,mic-type-1 = <3>; /* DCC */
>   };
>   
> +&pcie {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pcie_pins_default>;
> +	status = "okay";
> +};
> +
> +&pciephy {
> +	status = "okay";
> +};
> +
>   &pio {
>   	audio_default_pins: audio-default-pins {
>   		pins-cmd-dat {
> @@ -758,6 +768,15 @@ pins-rst {
>   		};
>   	};
>   
> +	pcie_pins_default: pcie-default {
> +		mux {
> +			pinmux = <PINMUX_GPIO47__FUNC_I1_WAKEN>,
> +				 <PINMUX_GPIO48__FUNC_O_PERSTN>,
> +				 <PINMUX_GPIO49__FUNC_B1_CLKREQN>;
> +			bias-pull-up;
> +		};
> +	};
> +
>   	rt1715_int_pins: rt1715-int-pins {
>   		pins_cmd0_dat {
>   			pinmux = <PINMUX_GPIO12__FUNC_B_GPIO12>;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie
  2024-10-07 10:07 [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie Macpaul Lin
  2024-10-07 14:08 ` Matthias Brugger
@ 2024-10-08  8:20 ` AngeloGioacchino Del Regno
  2024-10-14 10:41 ` AngeloGioacchino Del Regno
  2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-08  8:20 UTC (permalink / raw)
  To: Macpaul Lin, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Matthias Brugger, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, Jieyy Yang, Jian Yang, Jianguo Zhang,
	Alexandre Mergnat
  Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
	MediaTek Chromebook Upstream, Chen-Yu Tsai

Il 07/10/24 12:07, Macpaul Lin ha scritto:
> Enable PCIE, PCIEPHY and related Pinctrls for mt8390-genio-700-evk
> board.
> 
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie
  2024-10-07 10:07 [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie Macpaul Lin
  2024-10-07 14:08 ` Matthias Brugger
  2024-10-08  8:20 ` AngeloGioacchino Del Regno
@ 2024-10-14 10:41 ` AngeloGioacchino Del Regno
  2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-10-14 10:41 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
	Jieyy Yang, Jian Yang, Jianguo Zhang, Alexandre Mergnat,
	Macpaul Lin
  Cc: Bear Wang, Pablo Sun, Macpaul Lin, Sen Chu, Chris-qj chen,
	MediaTek Chromebook Upstream, Chen-Yu Tsai

On Mon, 07 Oct 2024 18:07:49 +0800, Macpaul Lin wrote:
> Enable PCIE, PCIEPHY and related Pinctrls for mt8390-genio-700-evk
> board.
> 
> 

Applied to mediatek-next, thanks!

[1/1] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie
      (no commit info)

Cheers,
Angelo



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-10-14 10:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 10:07 [PATCH] arm64: dts: mediatek: mt8390-genio-700-evk: enable pcie Macpaul Lin
2024-10-07 14:08 ` Matthias Brugger
2024-10-08  8:20 ` AngeloGioacchino Del Regno
2024-10-14 10:41 ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).