From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0641D5CC9; Sun, 28 Dec 2025 17:41:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766943711; cv=none; b=XejJcOVGeb0EEjUKWfbIlLVDFcmcYuxsYEiK85QPaPETQdKoHjYoowiTAVDfRjIp9J6xNInJ27aww6hvqnnSr/NeZc25XgiKYVx9ign6swTR/NJrXS7Quc+ncepBFCr1wbUiDz+xWbI55YA9egO3on8zQ4naySUDfUCuUgCgD4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766943711; c=relaxed/simple; bh=VE5TuYGamsbnhYkhmyxIfwR14ngrv1/BcmDk7ikuQzU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iEXcuP3559rsPQkaxK4p8AiFGNk2WwEE83ZR5cIYoWdn6K4ttAi6fapqdD0huW2rMJ3eoK6wbsUacxDyeNK+7yPMyBTmJtDiGyhy6WN5SCJTtPgfDdRY9s93aDf/HxesKLpkpi+Rxr74vf9TbqbfBTyDukT2YkoU9jg8FSN0qOU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=WHZlmT6Z; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="WHZlmT6Z" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=ZUQu9H3WOitPzhsM/on3IIDEdJMpjoQS/NL13XajIJo=; b=WHZlmT6ZqPwvymsvsdX7U4GOme 6fXTq9+nNj5l1mj8weFPe7Lv2qIJ7R+7rzeqKj0CIn/Ghm5Hk5I8SBt/RCNZTuN3EDKR7UDmwQjLD p0DfueNyach9h/Shjh3mrILmgpjAPMJ4r4g0LDuK2eOCUb0cafS1Q6rQP4nltnzZYtx8tXmU6Im52 11dH5ihSkg3VhfzjaB/1Lx2sUfn8W5VEVSjGnFJyeEPCLjxlVRsJayZtgRzH5/Iq98U5aOQjfaSaN itxrDDQ2rTwfyfzUtf5KEmAFHow2/b/WKe3bYotuB14170LgNf0Gu2Vh7yGelJljXEHeNTgwFRr9i XOoqR8nA==; Received: from i53875bca.versanet.de ([83.135.91.202] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vZulP-000Ta3-Dc; Sun, 28 Dec 2025 18:41:08 +0100 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Andy Yan , Icenowy Zheng Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Michal Wilczynski , devicetree@vger.kernel.org, Yao Zi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Han Gao , linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 5/9] drm/bridge: add a driver for T-Head TH1520 HDMI controller Date: Sun, 28 Dec 2025 18:41:06 +0100 Message-ID: <2776792.KRxA6XjA2N@diego> In-Reply-To: <3b5fd30554f91bcd083b2dc450cdf7fe2fa395e2.camel@iscas.ac.cn> References: <20251224161205.1132149-1-zhengxingda@iscas.ac.cn> <5ce9d611.1868.19b5e9e7a61.Coremail.andyshrk@163.com> <3b5fd30554f91bcd083b2dc450cdf7fe2fa395e2.camel@iscas.ac.cn> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Samstag, 27. Dezember 2025, 08:22:05 Mitteleurop=C3=A4ische Normalzeit s= chrieb Icenowy Zheng: > =E5=9C=A8 2025-12-27=E6=98=9F=E6=9C=9F=E5=85=AD=E7=9A=84 15:03 +0800=EF= =BC=8CAndy Yan=E5=86=99=E9=81=93=EF=BC=9A > >=20 > >=20 > > Hello=EF=BC=8C > >=20 > > =E5=9C=A8 2025-12-26 21:27:53=EF=BC=8C"Icenowy Zheng" =E5=86=99=E9=81=93=EF=BC=9A > > > =E5=9C=A8 2025-12-25=E6=98=9F=E6=9C=9F=E5=9B=9B=E7=9A=84 19:07 +0800= =EF=BC=8CAndy Yan=E5=86=99=E9=81=93=EF=BC=9A > > > >=20 > > > >=20 > > > > Hello Icenowy: > > > >=20 > > > > At 2025-12-25 00:12:01, "Icenowy Zheng" > > > > wrote: > > > > > From: Icenowy Zheng > > > > >=20 > > > > > T-Head TH1520 SoC contains a Synopsys DesignWare HDMI > > > > > controller > > > > > (paired > > > > > with DesignWare HDMI TX PHY Gen2) that takes the "DP" output > > > > > from > > > > > the > > > > > display controller. > > > > >=20 > > > > > Add a driver for this controller utilizing the common > > > > > DesignWare > > > > > HDMI > > > > > code in the kernel. > > > > >=20 > > > > > Signed-off-by: Icenowy Zheng > > > > > Signed-off-by: Icenowy Zheng > > > > > --- > > > > > No changes in v3, v4. > > > > >=20 > > > > > Changes in v2: > > > > > - Created a new function to set PHY parameters and refactored > > > > > the > > > > > control flow of the configure_phy callback. > > > > >=20 > > > > > MAINTAINERS | 1 + > > > > > drivers/gpu/drm/bridge/Kconfig | 10 ++ > > > > > drivers/gpu/drm/bridge/Makefile | 1 + > > > > > drivers/gpu/drm/bridge/th1520-dw-hdmi.c | 173 > > > > > ++++++++++++++++++++++++ > > > > > 4 files changed, 185 insertions(+) > > > > > create mode 100644 drivers/gpu/drm/bridge/th1520-dw-hdmi.c > > > >=20 > > > >=20 > > > > As this is a Synopsys DesignWare based IP, maybe it's better to > > > > put > > > > it under "drivers/gpu/drm/bridge/synopsys/" > > > > Or just create a dir for thead, I think there will come other > > > > display > > > > related drivers for thead in the future. > > >=20 > > > It's not proper to place vendor glues to synopsys/ . > >=20 > >=20 > > TI has precedents for doing this with Cadence IP=EF=BC=8C see=20 > >=20 > > drivers/gpu/drm/bridge/cadence/cdns-dsi-j721e.c > > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c=20 >=20 > Well for this kind of things, I prefer to hear from the maintainer of > DW HDMI bridges (although it seems that this has no dedicated > MAINTAINERS entry and get_maintainers just returns people for DRM > DRIVERS FOR BRIDGE CHIPS). I think the best way to resolve this question would be to actively ask on the dri-devel IRC channel (on the OFTC network), because people might not even realize this quite interesting question is in here, but I guess most of the relevant people are on there. But probably wait after new years, so people can actually return from all the festivities happening right now. Heiko