public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	charles.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	cody.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	kevan.lan-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	sugar.zhang-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
	wmc-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error
Date: Wed, 17 May 2017 11:01:00 +0200	[thread overview]
Message-ID: <2781249.GNsgFIKA50@diego> (raw)
In-Reply-To: <1494992451-32542-2-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Hi Frank,

Am Mittwoch, 17. Mai 2017, 11:40:49 CEST schrieb Frank Wang:
> From: Sugar Zhang <sugar.zhang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> 
> Refer to Chapter 5.3.2 of rk3229 TRM, we can see that GPIO1A[2,4,5]
> using RK_FUNC_2 not RK_FUNC_1. This patch fixes it.
> 
> Signed-off-by: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

if the patch has another author, you should preserve his/her Signed-off-by
line, so for example this patch would look like:

Signed-off-by: Sugar Zhang <sugar.zhang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Signed-off-by: Frank Wang <frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

Same for all other patches with differing authors in your 2 series from
today. As this touches the developer-certificate-of-origin, this is also
something I cannot really correct myself.


Heiko


> ---
>  arch/arm/boot/dts/rk322x.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 48a0c1c..cc6a27d 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -621,9 +621,9 @@
>  						<0 12 RK_FUNC_1 &pcfg_pull_none>,
>  						<0 13 RK_FUNC_1 &pcfg_pull_none>,
>  						<0 14 RK_FUNC_1 &pcfg_pull_none>,
> -						<1 2 RK_FUNC_1 &pcfg_pull_none>,
> -						<1 4 RK_FUNC_1 &pcfg_pull_none>,
> -						<1 5 RK_FUNC_1 &pcfg_pull_none>;
> +						<1 2 RK_FUNC_2 &pcfg_pull_none>,
> +						<1 4 RK_FUNC_2 &pcfg_pull_none>,
> +						<1 5 RK_FUNC_2 &pcfg_pull_none>;
>  			};
>  		};


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-05-17  9:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-17  3:40 [PATCH 0/3] add and fix some device node for rk322x SoC Frank Wang
2017-05-17  3:40 ` [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error Frank Wang
     [not found]   ` <1494992451-32542-2-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-17  9:01     ` Heiko Stübner [this message]
2017-05-17  9:21       ` Frank Wang
     [not found] ` <1494992451-32542-1-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-17  3:40   ` [PATCH 2/3] arm: dts: rk322x: correct uart2 pinctrl and add another sets Frank Wang
2017-05-17  6:31     ` Kever Yang
     [not found]       ` <3974d438-89ca-04e2-03cd-6d3946dd461e-9Onoh4P/yGk@public.gmane.org>
2017-05-17  7:35         ` Frank Wang
2017-05-17  3:40 ` [PATCH 3/3] arm: dts: rk322x: add watchdog device node Frank Wang
     [not found]   ` <1494992451-32542-4-git-send-email-frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-05-18  3:18     ` kbuild test robot
2017-05-18  3:58       ` Frank Wang
2017-05-18  7:18         ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2781249.GNsgFIKA50@diego \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=charles.chen-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=cody.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=frank.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=kevan.lan-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=sugar.zhang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    --cc=wmc-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox