From: Arnd Bergmann <arnd@arndb.de>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device
Date: Fri, 04 Dec 2015 10:21:23 +0100 [thread overview]
Message-ID: <2782017.y2Eu5VXXnv@wuerfel> (raw)
In-Reply-To: <1449206553-26133-1-git-send-email-vz@mleia.com>
On Friday 04 December 2015 07:22:33 Vladimir Zapolskiy wrote:
> LPC32xx SoC has two independent PWM controllers, they have different
> clock parents, clock gates and slightly different controls, each of
> these two PWM controllers has one output channel.
>
> The change updates device tree binding documentation to reflect two PWM
> devices.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>
The change looks reasonable, but I think you should clarify that this is
an incompatible change, and do it in the same patch as the corresponding
change to set 'npwms' to 1 in the driver.
Arnd
next prev parent reply other threads:[~2015-12-04 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 5:22 [PATCH] dt: lpc32xx: pwm: update documentation of LPC32xx PWM device Vladimir Zapolskiy
2015-12-04 9:21 ` Arnd Bergmann [this message]
2015-12-04 15:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2782017.y2Eu5VXXnv@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox