From mboxrd@z Thu Jan 1 00:00:00 1970 From: aisheng.dong-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org Subject: Re: [PATCH 3/4] arm64: add support for i.MX8M EVK board Date: Thu, 25 Jan 2018 18:10:35 +0800 Message-ID: <278bb44610b8a27826550732095aba03@codeaurora.org> References: <20180117183244.28303-1-l.stach@pengutronix.de> <20180117183244.28303-3-l.stach@pengutronix.de> <20180123103931.GE27764@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180123103931.GE27764@dragon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Lucas Stach , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Catalin Marinas , Will Deacon , patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Rob Herring , kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Fabio Estevam , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, aisheng.dong-3arQi8VN3Tc@public.gmane.org, linux-imx-3arQi8VN3Tc@public.gmane.org List-Id: devicetree@vger.kernel.org On 2018-01-23 18:39, Shawn Guo wrote: > On Wed, Jan 17, 2018 at 07:32:43PM +0100, Lucas Stach wrote: > >> + pinctrl_usdhc2_100mhz: usdhc2grp100mhz { >> + fsl,pins = < >> + MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK 0x85 >> + MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD 0xc5 >> + MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0 0xc5 >> + MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1 0xc5 >> + MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2 0xc5 >> + MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3 0xc5 >> + MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT 0xc1 >> + >; >> + }; > > Bad indentation. > > Shawn > >> + >> + pinctrl_usdhc2_200mhz: usdhc2grp200mhz { >> + fsl,pins = < >> + MX8MQ_IOMUXC_SD2_CLK_USDHC2_CLK 0x87 >> + MX8MQ_IOMUXC_SD2_CMD_USDHC2_CMD 0xc7 >> + MX8MQ_IOMUXC_SD2_DATA0_USDHC2_DATA0 0xc7 >> + MX8MQ_IOMUXC_SD2_DATA1_USDHC2_DATA1 0xc7 >> + MX8MQ_IOMUXC_SD2_DATA2_USDHC2_DATA2 0xc7 >> + MX8MQ_IOMUXC_SD2_DATA3_USDHC2_DATA3 0xc7 >> + MX8MQ_IOMUXC_GPIO1_IO04_USDHC2_VSELECT 0xc1 >> + >; >> + }; AFAIK we switched to generic pinconfig since MX7ULP as maintainer won't access old binding pinctrl drivers. So i wonder if you may have some special reasons to insist on old binding which i may overlooked? (I did not receive your pinctrl patch by accidently. So i can't reply on it before.) Regards Dong Aisheng >> +}; >> -- >> 2.11.0 >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html