From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ramona Alexandra Nechita <ramona.nechita@analog.com>,
linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/1] dt-bindings: iio: adc: add a7779 doc
Date: Fri, 31 May 2024 17:25:13 +0200 [thread overview]
Message-ID: <278ed1f7-7f98-412a-abef-840592e016d4@kernel.org> (raw)
In-Reply-To: <20240531133604.1380-2-ramona.nechita@analog.com>
On 31/05/2024 15:35, Ramona Alexandra Nechita wrote:
> Add dt bindings for adc ad7779.
>
> Signed-off-by: Ramona Alexandra Nechita <ramona.nechita@analog.com>
> ---
> .../ABI/testing/sysfs-bus-iio-adc-ad777x | 23 +++++
> .../bindings/iio/adc/adi,ad7779.yaml | 87 +++++++++++++++++++
> 2 files changed, 110 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-adc-ad777x
> create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad7779.yaml
Why is this sent separately troubles us all... I saw many patches from
analog.com, so maybe there is a person who will help you, in case you do
not want to read submitting patches?
...
> +
> + reg:
> + maxItems: 1
> +
> + '#address-cells':
> + const: 1
> +
> + '#size-cells':
> + const: 0
> +
> + spi-max-frequency: true
Drop
> +
> + clocks:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vref-supply:
> + description:
> + ADC reference voltage supply
> +
> + start-gpios:
> + description:
> + Pin that controls start synchronization pulse.
> + maxItems: 1
> +
> + reset-gpios:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + adc@0 {
> + compatible = "adi,ad7779";
Messed indentation. Keep same for entire example, e.g.
Use 4 spaces for example indentation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-31 15:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 13:35 [PATCH v3 1/1] dt-bindings:iio:adc: correct previous patch Ramona Alexandra Nechita
2024-05-31 13:35 ` [PATCH v3 1/1] dt-bindings: iio: adc: add a7779 doc Ramona Alexandra Nechita
2024-05-31 14:51 ` Conor Dooley
2024-05-31 14:53 ` Conor Dooley
2024-05-31 15:25 ` Krzysztof Kozlowski [this message]
2024-06-02 9:11 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=278ed1f7-7f98-412a-abef-840592e016d4@kernel.org \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramona.nechita@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox