From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:60096 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbeLCVur (ORCPT ); Mon, 3 Dec 2018 16:50:47 -0500 From: Laurent Pinchart Subject: Re: [PATCH 2/2] arm64: dts: renesas: r8a7796: salvator-xs: Convert to new LVDS DT bindings Date: Mon, 03 Dec 2018 23:51:19 +0200 Message-ID: <2791575.DKQRoZFgHM@avalon> In-Reply-To: <20181203151242.25875-3-geert+renesas@glider.be> References: <20181203151242.25875-1-geert+renesas@glider.be> <20181203151242.25875-3-geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Simon Horman , Magnus Damm , Marek Vasut , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org List-ID: Hi Geert, Thank you for the patch. On Monday, 3 December 2018 17:12:42 EET Geert Uytterhoeven wrote: > As of commit 6d2ca85279becdff ("dt-bindings: display: renesas: Deprecate > LVDS support in the DU bindings"), the internal LVDS encoder has DT > bindings separate from the DU. The device trees for all R-Car H3 and > M3-W development boards were ported over to the new model, but > Salvator-XS boards equipped with an R-Car M3-W SoC were forgotten. > > Fixes: 58e8ed2ee9abe718 ("arm64: dts: renesas: Convert to new LVDS DT > bindings") Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. I can't test the patch either but it looks fine to me. Reviewed-by: Laurent Pinchart I assume you will send this directly to Simon, so I don't plan to take the patch in my tree. > --- > arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts index > 8860be65342e4f38..31f12059355ee02b 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7796-salvator-xs.dts > @@ -29,11 +29,10 @@ > clocks = <&cpg CPG_MOD 724>, > <&cpg CPG_MOD 723>, > <&cpg CPG_MOD 722>, > - <&cpg CPG_MOD 727>, > <&versaclock6 1>, > <&x21_clk>, > <&versaclock6 2>; > - clock-names = "du.0", "du.1", "du.2", "lvds.0", > + clock-names = "du.0", "du.1", "du.2", > "dclkin.0", "dclkin.1", "dclkin.2"; > }; -- Regards, Laurent Pinchart